• John Johansen's avatar
    apparmor: cache buffers on percpu list if there is lock contention · ea9bae12
    John Johansen authored
    commit df323337 ("apparmor: Use a memory pool instead per-CPU caches")
    
    changed buffer allocation to use a memory pool, however on a heavily
    loaded machine there can be lock contention on the global buffers
    lock. Add a percpu list to cache buffers on when lock contention is
    encountered.
    
    When allocating buffers attempt to use cached buffers first,
    before taking the global buffers lock. When freeing buffers
    try to put them back to the global list but if contention is
    encountered, put the buffer on the percpu list.
    
    The length of time a buffer is held on the percpu list is dynamically
    adjusted based on lock contention.  The amount of hold time is
    increased and decreased linearly.
    
    v5:
    - simplify base patch by removing: improvements can be added later
      - MAX_LOCAL and must lock
      - contention scaling.
    v4:
    - fix percpu ->count buffer count which had been spliced across a
      debug patch.
    - introduce define for MAX_LOCAL_COUNT
    - rework count check and locking around it.
    - update commit message to reference commit that introduced the
      memory.
    v3:
    - limit number of buffers that can be pushed onto the percpu
      list. This avoids a problem on some kernels where one percpu
      list can inherit buffers from another cpu after a reschedule,
      causing more kernel memory to used than is necessary. Under
      normal conditions this should eventually return to normal
      but under pathelogical conditions the extra memory consumption
      may have been unbouanded
    v2:
    - dynamically adjust buffer hold time on percpu list based on
      lock contention.
    v1:
    - cache buffers on percpu list on lock contention
    Reported-by: default avatarSergey Senozhatsky <senozhatsky@chromium.org>
    Reviewed-by: default avatarGeorgia Garcia <georgia.garcia@canonical.com>
    Signed-off-by: default avatarJohn Johansen <john.johansen@canonical.com>
    ea9bae12
lsm.c 57.8 KB