Commit d867c43e authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman

USB: ksdazzle-sir.c: remove err() usage

err() was a very old USB-specific macro that I thought had
gone away.  This patch removes it from being used in the
driver and uses dev_err() instead.

CC: Samuel Ortiz <samuel@sortiz.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 32279240
...@@ -168,10 +168,10 @@ struct ksdazzle_cb { ...@@ -168,10 +168,10 @@ struct ksdazzle_cb {
static void ksdazzle_speed_irq(struct urb *urb) static void ksdazzle_speed_irq(struct urb *urb)
{ {
/* unlink, shutdown, unplug, other nasties */ /* unlink, shutdown, unplug, other nasties */
if (urb->status != 0) { if (urb->status != 0)
err("ksdazzle_speed_irq: urb asynchronously failed - %d", dev_err(&urb->dev->dev,
urb->status); "ksdazzle_speed_irq: urb asynchronously failed - %d\n",
} urb->status);
} }
/* Send a control request to change speed of the dongle */ /* Send a control request to change speed of the dongle */
...@@ -245,14 +245,16 @@ static void ksdazzle_send_irq(struct urb *urb) ...@@ -245,14 +245,16 @@ static void ksdazzle_send_irq(struct urb *urb)
/* in process of stopping, just drop data */ /* in process of stopping, just drop data */
if (!netif_running(kingsun->netdev)) { if (!netif_running(kingsun->netdev)) {
err("ksdazzle_send_irq: Network not running!"); dev_err(&kingsun->usbdev->dev,
"ksdazzle_send_irq: Network not running!\n");
return; return;
} }
/* unlink, shutdown, unplug, other nasties */ /* unlink, shutdown, unplug, other nasties */
if (urb->status != 0) { if (urb->status != 0) {
err("ksdazzle_send_irq: urb asynchronously failed - %d", dev_err(&kingsun->usbdev->dev,
urb->status); "ksdazzle_send_irq: urb asynchronously failed - %d\n",
urb->status);
return; return;
} }
...@@ -271,7 +273,9 @@ static void ksdazzle_send_irq(struct urb *urb) ...@@ -271,7 +273,9 @@ static void ksdazzle_send_irq(struct urb *urb)
if (kingsun->tx_buf_clear_used > 0) { if (kingsun->tx_buf_clear_used > 0) {
/* There is more data to be sent */ /* There is more data to be sent */
if ((ret = ksdazzle_submit_tx_fragment(kingsun)) != 0) { if ((ret = ksdazzle_submit_tx_fragment(kingsun)) != 0) {
err("ksdazzle_send_irq: failed tx_urb submit: %d", ret); dev_err(&kingsun->usbdev->dev,
"ksdazzle_send_irq: failed tx_urb submit: %d\n",
ret);
switch (ret) { switch (ret) {
case -ENODEV: case -ENODEV:
case -EPIPE: case -EPIPE:
...@@ -320,7 +324,8 @@ static netdev_tx_t ksdazzle_hard_xmit(struct sk_buff *skb, ...@@ -320,7 +324,8 @@ static netdev_tx_t ksdazzle_hard_xmit(struct sk_buff *skb,
kingsun->tx_buf_clear_used = wraplen; kingsun->tx_buf_clear_used = wraplen;
if ((ret = ksdazzle_submit_tx_fragment(kingsun)) != 0) { if ((ret = ksdazzle_submit_tx_fragment(kingsun)) != 0) {
err("ksdazzle_hard_xmit: failed tx_urb submit: %d", ret); dev_err(&kingsun->usbdev->dev,
"ksdazzle_hard_xmit: failed tx_urb submit: %d\n", ret);
switch (ret) { switch (ret) {
case -ENODEV: case -ENODEV:
case -EPIPE: case -EPIPE:
...@@ -355,8 +360,9 @@ static void ksdazzle_rcv_irq(struct urb *urb) ...@@ -355,8 +360,9 @@ static void ksdazzle_rcv_irq(struct urb *urb)
/* unlink, shutdown, unplug, other nasties */ /* unlink, shutdown, unplug, other nasties */
if (urb->status != 0) { if (urb->status != 0) {
err("ksdazzle_rcv_irq: urb asynchronously failed - %d", dev_err(&kingsun->usbdev->dev,
urb->status); "ksdazzle_rcv_irq: urb asynchronously failed - %d\n",
urb->status);
kingsun->receiving = 0; kingsun->receiving = 0;
return; return;
} }
...@@ -430,7 +436,7 @@ static int ksdazzle_net_open(struct net_device *netdev) ...@@ -430,7 +436,7 @@ static int ksdazzle_net_open(struct net_device *netdev)
sprintf(hwname, "usb#%d", kingsun->usbdev->devnum); sprintf(hwname, "usb#%d", kingsun->usbdev->devnum);
kingsun->irlap = irlap_open(netdev, &kingsun->qos, hwname); kingsun->irlap = irlap_open(netdev, &kingsun->qos, hwname);
if (!kingsun->irlap) { if (!kingsun->irlap) {
err("ksdazzle-sir: irlap_open failed"); dev_err(&kingsun->usbdev->dev, "irlap_open failed\n");
goto free_mem; goto free_mem;
} }
...@@ -442,7 +448,7 @@ static int ksdazzle_net_open(struct net_device *netdev) ...@@ -442,7 +448,7 @@ static int ksdazzle_net_open(struct net_device *netdev)
kingsun->rx_urb->status = 0; kingsun->rx_urb->status = 0;
err = usb_submit_urb(kingsun->rx_urb, GFP_KERNEL); err = usb_submit_urb(kingsun->rx_urb, GFP_KERNEL);
if (err) { if (err) {
err("ksdazzle-sir: first urb-submit failed: %d", err); dev_err(&kingsun->usbdev->dev, "first urb-submit failed: %d\n", err);
goto close_irlap; goto close_irlap;
} }
...@@ -590,13 +596,14 @@ static int ksdazzle_probe(struct usb_interface *intf, ...@@ -590,13 +596,14 @@ static int ksdazzle_probe(struct usb_interface *intf,
*/ */
interface = intf->cur_altsetting; interface = intf->cur_altsetting;
if (interface->desc.bNumEndpoints != 2) { if (interface->desc.bNumEndpoints != 2) {
err("ksdazzle: expected 2 endpoints, found %d", dev_err(&intf->dev, "ksdazzle: expected 2 endpoints, found %d\n",
interface->desc.bNumEndpoints); interface->desc.bNumEndpoints);
return -ENODEV; return -ENODEV;
} }
endpoint = &interface->endpoint[KINGSUN_EP_IN].desc; endpoint = &interface->endpoint[KINGSUN_EP_IN].desc;
if (!usb_endpoint_is_int_in(endpoint)) { if (!usb_endpoint_is_int_in(endpoint)) {
err("ksdazzle: endpoint 0 is not interrupt IN"); dev_err(&intf->dev,
"ksdazzle: endpoint 0 is not interrupt IN\n");
return -ENODEV; return -ENODEV;
} }
...@@ -604,13 +611,16 @@ static int ksdazzle_probe(struct usb_interface *intf, ...@@ -604,13 +611,16 @@ static int ksdazzle_probe(struct usb_interface *intf,
pipe = usb_rcvintpipe(dev, ep_in); pipe = usb_rcvintpipe(dev, ep_in);
maxp_in = usb_maxpacket(dev, pipe, usb_pipeout(pipe)); maxp_in = usb_maxpacket(dev, pipe, usb_pipeout(pipe));
if (maxp_in > 255 || maxp_in <= 1) { if (maxp_in > 255 || maxp_in <= 1) {
err("ksdazzle: endpoint 0 has max packet size %d not in range [2..255]", maxp_in); dev_err(&intf->dev,
"ksdazzle: endpoint 0 has max packet size %d not in range [2..255]\n",
maxp_in);
return -ENODEV; return -ENODEV;
} }
endpoint = &interface->endpoint[KINGSUN_EP_OUT].desc; endpoint = &interface->endpoint[KINGSUN_EP_OUT].desc;
if (!usb_endpoint_is_int_out(endpoint)) { if (!usb_endpoint_is_int_out(endpoint)) {
err("ksdazzle: endpoint 1 is not interrupt OUT"); dev_err(&intf->dev,
"ksdazzle: endpoint 1 is not interrupt OUT\n");
return -ENODEV; return -ENODEV;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment