Skip to content

L
linux
Switch branch/tag
  1. 29 Sep, 2015 9 commits
  3. 28 Sep, 2015 3 commits
    • Andreas Dannenberg's avatar
      power: bq24257: Streamline input current limit setup · 9b1cf1e4
      Andreas Dannenberg authored 
      The maximum amount of input current the charger should draw is dependent
on the power supply and should only be (re-)configured when the power
supply gets connected and disconnected. However the driver was also
lowering the bq24257's input current limit setting to 500mA when the
battery was removed and restored the previous setting according to the
power supply capabilities when the battery was reconnected although
these events are not impacting the amount of power that can be drawn
from the supply. Furthermore, a re-configuration of the input current
limit to 500mA when the battery gets disconnected is actually dangerous
if the limit was set higher previously and the system draws more than
500mA in which case the system voltage would be reduced in order to
maintain 500mA which could result in the system getting too low of a
supply to maintain operation. Last but not least the mechanism itself
used for battery re-connection detection did not work in corner cases
such as when the device's input current loop becomes active and the
bq24257 device clears its battery fault error resulting in incorrectly
reporting that the battery got reconnected.

This patches removes the impact the battery removal/insertion has on the
input current limit configured for the bq24257 and simplifies the
associated handler routine.
Signed-off-by: default avatarAndreas Dannenberg <dannenberg@ti.com>
Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
      9b1cf1e4
    • Andreas Dannenberg's avatar
      power: bq24257: Remove IRQ config through stat-gpios · 5ff8c89d
      Andreas Dannenberg authored 
      At the time the driver was written GpioInt resources in ACPI were not
passed to the driver in client->irq, as opposed to DT enumeration. To
accommodate this use case, a "stat-gpios" property was introduced to
allow configuring the IRQ.

However this issue with ACPI was fixed in commit "845c8770 i2c / ACPI:
Assign IRQ for devices that have GpioInt automatically" and makes this
workaround no longer necessary, hence we can remove the support for the
"stat-gpios" property and the associated code from the bq24257 driver.
Signed-off-by: default avatarAndreas Dannenberg <dannenberg@ti.com>
Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
      5ff8c89d
    • Andrzej Hajda's avatar
      power: bq27xxx_battery: fix signedness bug in bq27xxx_battery_read_health() · 2edd69a8
      Andrzej Hajda authored 
      We need flags to be signed for the error handling to work.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576

Fixes: 74aab849 ('power: bq27xxx_battery: Cleanup health checking')
Signed-off-by: default avatarAndrzej Hajda <a.hajda@samsung.com>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-By: default avatarPali Rohár <pali.rohar@gmail.com>
Acked-by: default avatarAndrew F. Davis <afd@ti.com>
Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
      2edd69a8
  5. 26 Sep, 2015 3 commits
  7. 24 Sep, 2015 3 commits
  9. 23 Sep, 2015 7 commits
  11. 22 Sep, 2015 15 commits
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7