1. 04 Jul, 2020 11 commits
    • Christian Brauner's avatar
      arch: remove HAVE_COPY_THREAD_TLS · 140c8180
      Christian Brauner authored
      All architectures support copy_thread_tls() now, so remove the legacy
      copy_thread() function and the HAVE_COPY_THREAD_TLS config option. Everyone
      uses the same process creation calling convention based on
      copy_thread_tls() and struct kernel_clone_args. This will make it easier to
      maintain the core process creation code under kernel/, simplifies the
      callpaths and makes the identical for all architectures.
      
      Cc: linux-arch@vger.kernel.org
      Acked-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
      Acked-by: default avatarGreentime Hu <green.hu@gmail.com>
      Acked-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
      Reviewed-by: default avatarKees Cook <keescook@chromium.org>
      Signed-off-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
      140c8180
    • Christian Brauner's avatar
      unicore: switch to copy_thread_tls() · 8496da09
      Christian Brauner authored
      Use the copy_thread_tls() calling convention which passes tls through a
      register. This is required so we can remove the copy_thread{_tls}() split
      and remove the HAVE_COPY_THREAD_TLS macro.
      
      Cc: Guan Xuetao <gxt@pku.edu.cn>
      Signed-off-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
      8496da09
    • Christian Brauner's avatar
      sh: switch to copy_thread_tls() · 15350c42
      Christian Brauner authored
      Use the copy_thread_tls() calling convention which passes tls through a
      register. This is required so we can remove the copy_thread{_tls}() split
      and remove the HAVE_COPY_THREAD_TLS macro.
      
      Cc: Rich Felker <dalias@libc.org>
      Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
      Cc: linux-sh@vger.kernel.org
      Signed-off-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
      15350c42
    • Christian Brauner's avatar
      nds32: switch to copy_thread_tls() · 1dd966ea
      Christian Brauner authored
      Use the copy_thread_tls() calling convention which passes tls through a
      register. This is required so we can remove the copy_thread{_tls}() split
      and remove the HAVE_COPY_THREAD_TLS macro.
      
      Cc: Greentime Hu <green.hu@gmail.com>
      Cc: Nick Hu <nickhu@andestech.com>
      Cc: Vincent Chen <deanbo422@gmail.com>
      Signed-off-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
      1dd966ea
    • Christian Brauner's avatar
      microblaze: switch to copy_thread_tls() · ad1bb82c
      Christian Brauner authored
      Use the copy_thread_tls() calling convention which passes tls through a
      register. This is required so we can remove the copy_thread{_tls}() split
      and remove the HAVE_COPY_THREAD_TLS macro.
      
      Cc: Michal Simek <monstr@monstr.eu>
      Signed-off-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
      ad1bb82c
    • Christian Brauner's avatar
      hexagon: switch to copy_thread_tls() · 643d48b8
      Christian Brauner authored
      Use the copy_thread_tls() calling convention which passes tls through a
      register. This is required so we can remove the copy_thread{_tls}() split
      and remove the HAVE_COPY_THREAD_TLS macro.
      
      Cc: linux-hexagon@vger.kernel.org
      Acked-by: default avatarBrian Cain <bcain@codeaurora.org>
      Signed-off-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
      643d48b8
    • Christian Brauner's avatar
      c6x: switch to copy_thread_tls() · e0daa22c
      Christian Brauner authored
      Use the copy_thread_tls() calling convention which passes tls through a
      register. This is required so we can remove the copy_thread{_tls}() split
      and remove the HAVE_COPY_THREAD_TLS macro.
      
      CC: Mark Salter <msalter@redhat.com>
      Cc: Aurelien Jacquiot <jacquiot.aurelien@gmail.com>
      Cc: linux-c6x-dev@linux-c6x.org
      Signed-off-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
      e0daa22c
    • Christian Brauner's avatar
      alpha: switch to copy_thread_tls() · 0fdfc53f
      Christian Brauner authored
      Use the copy_thread_tls() calling convention which passes tls through a
      register. This is required so we can remove the copy_thread{_tls}() split
      and remove the HAVE_COPY_THREAD_TLS macro.
      
      Cc: linux-alpha@vger.kernel.org
      Signed-off-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
      0fdfc53f
    • Christian Brauner's avatar
      fork: remove do_fork() · ff2a9112
      Christian Brauner authored
      Now that all architectures have been switched to use _do_fork() and the new
      struct kernel_clone_args calling convention we can remove the legacy
      do_fork() helper completely. The calling convention used to be brittle and
      do_fork() didn't buy us anything. The only calling convention accepted
      should be based on struct kernel_clone_args going forward. It's cleaner and
      uniform.
      
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Al Viro <viro@zeniv.linux.org.uk>
      Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>
      Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>
      Signed-off-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
      ff2a9112
    • Christian Brauner's avatar
      h8300: select HAVE_COPY_THREAD_TLS, switch to kernel_clone_args · adc7092e
      Christian Brauner authored
      This is part of a larger series that aims at getting rid of the
      copy_thread()/copy_thread_tls() split that makes the process creation
      codepaths in the kernel more convoluted and error-prone than they need
      to be.
      I'm converting all the remaining arches that haven't yet switched and
      am collecting individual acks. Once I have them, I'll send the whole series
      removing the copy_thread()/copy_thread_tls() split, the
      HAVE_COPY_THREAD_TLS define and the legacy do_fork() helper. The only
      kernel-wide process creation entry point for anything not going directly
      through the syscall path will then be based on struct kernel_clone_args.
      No more danger of weird process creation abi quirks between architectures
      hopefully, and easier to maintain overall.
      It also unblocks implementing clone3() on architectures not support
      copy_thread_tls(). Any architecture that wants to implement clone3()
      will need to select HAVE_COPY_THREAD_TLS and thus need to implement
      copy_thread_tls(). So both goals are connected but independently
      beneficial.
      
      HAVE_COPY_THREAD_TLS means that a given architecture supports
      CLONE_SETTLS and not setting it should usually mean that the
      architectures doesn't implement it but that's not how things are. In
      fact all architectures support CLONE_TLS it's just that they don't
      follow the calling convention that HAVE_COPY_THREAD_TLS implies. That
      means all architectures can be switched over to select
      HAVE_COPY_THREAD_TLS. Once that is done we can remove that macro (yay,
      less code), the unnecessary do_fork() export in kernel/fork.c, and also
      rename copy_thread_tls() back to copy_thread(). At this point
      copy_thread() becomes the main architecture specific part of process
      creation but it will be the same layout and calling convention for all
      architectures. (Once that is done we can probably cleanup each
      copy_thread() function even more but that's for the future.)
      
      Though h8300 doesn't not suppor the CLONE_SETTLS flag there's no reason to
      not switch to the copy_thread_tls() calling convention. As before
      CLONE_SETTLS with legacy clone will just be ignored. This brings us one
      step closer to getting rid of the copy_thread()/copy_thread_tls() split we
      still have and ultimately the HAVE_COPY_THREAD_TLS define in general. A lot
      of architectures have already converted and h8300 is one of the few hat
      haven't yet. This also unblocks implementing the clone3() syscall on h8300.
      Once that is done we can get of another ARCH_WANTS_* macro.
      
      Once Any architecture that supports HAVE_COPY_THREAD_TLS cannot call the
      do_fork() helper anymore. This is fine and intended since it should be
      removed in favor of the new, cleaner _do_fork() calling convention based
      on struct kernel_clone_args. In fact, most architectures have already
      switched.  With this patch, h8300 joins the other arches which can't use
      the fork(), vfork(), clone(), clone3() syscalls directly and who follow
      the new process creation calling convention that is based on struct
      kernel_clone_args which we introduced a while back. This means less
      custom assembly in the architectures entry path to set up the registers
      before calling into the process creation helper and it is easier to to
      support new features without having to adapt calling conventions. It
      also unifies all process creation paths between fork(), vfork(),
      clone(), and clone3(). (We can't fix the ABI nightmare that legacy
      clone() is but we can prevent stuff like this happening in the future.)
      
      For some more context, please see:
      commit 606e9ad2
      Merge: ac61145a 457677c7
      Author: Linus Torvalds <torvalds@linux-foundation.org>
      Date:   Sat Jan 11 15:33:48 2020 -0800
      
          Merge tag 'clone3-tls-v5.5-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux
      
          Pull thread fixes from Christian Brauner:
           "This contains a series of patches to fix CLONE_SETTLS when used with
            clone3().
      
            The clone3() syscall passes the tls argument through struct clone_args
            instead of a register. This means, all architectures that do not
            implement copy_thread_tls() but still support CLONE_SETTLS via
            copy_thread() expecting the tls to be located in a register argument
            based on clone() are currently unfortunately broken. Their tls value
            will be garbage.
      
            The patch series fixes this on all architectures that currently define
            __ARCH_WANT_SYS_CLONE3. It also adds a compile-time check to ensure
            that any architecture that enables clone3() in the future is forced to
            also implement copy_thread_tls().
      
            My ultimate goal is to get rid of the copy_thread()/copy_thread_tls()
            split and just have copy_thread_tls() at some point in the not too
            distant future (Maybe even renaming copy_thread_tls() back to simply
            copy_thread() once the old function is ripped from all arches). This
            is dependent now on all arches supporting clone3().
      
            While all relevant arches do that now there are still four missing:
            ia64, m68k, sh and sparc. They have the system call reserved, but not
            implemented. Once they all implement clone3() we can get rid of
            ARCH_WANT_SYS_CLONE3 and HAVE_COPY_THREAD_TLS.
      
      Note that in the meantime, m68k has already switched to the new calling
      convention. And I've got sparc patches acked by Dave, patches for ia64, and
      nios2 have been sent out and are ready too.
      
      Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
      Cc: uclinux-h8-devel@lists.sourceforge.jp
      Signed-off-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
      adc7092e
    • Christian Brauner's avatar
      nios2: enable HAVE_COPY_THREAD_TLS, switch to kernel_clone_args · 04bd52fb
      Christian Brauner authored
      This is part of a larger series that aims at getting rid of the
      copy_thread()/copy_thread_tls() split that makes the process creation
      codepaths in the kernel more convoluted and error-prone than they need
      to be.
      I'm converting all the remaining arches that haven't yet switched and
      am collecting individual acks. Once I have them, I'll send the whole series
      removing the copy_thread()/copy_thread_tls() split, the
      HAVE_COPY_THREAD_TLS define and the legacy do_fork() helper. The only
      kernel-wide process creation entry point for anything not going directly
      through the syscall path will then be based on struct kernel_clone_args.
      No more danger of weird process creation abi quirks between architectures
      hopefully, and easier to maintain overall.
      It also unblocks implementing clone3() on architectures not support
      copy_thread_tls(). Any architecture that wants to implement clone3()
      will need to select HAVE_COPY_THREAD_TLS and thus need to implement
      copy_thread_tls(). So both goals are connected but independently
      beneficial.
      
      HAVE_COPY_THREAD_TLS means that a given architecture supports
      CLONE_SETTLS and not setting it should usually mean that the
      architectures doesn't implement it but that's not how things are. In
      fact all architectures support CLONE_TLS it's just that they don't
      follow the calling convention that HAVE_COPY_THREAD_TLS implies. That
      means all architectures can be switched over to select
      HAVE_COPY_THREAD_TLS. Once that is done we can remove that macro (yay,
      less code), the unnecessary do_fork() export in kernel/fork.c, and also
      rename copy_thread_tls() back to copy_thread(). At this point
      copy_thread() becomes the main architecture specific part of process
      creation but it will be the same layout and calling convention for all
      architectures. (Once that is done we can probably cleanup each
      copy_thread() function even more but that's for the future.)
      
      Since nios2 does support CLONE_SETTLS there's no reason to not select
      HAVE_COPY_THREAD_TLS. This brings us one step closer to getting rid of
      the copy_thread()/copy_thread_tls() split we still have and ultimately
      the HAVE_COPY_THREAD_TLS define in general. A lot of architectures have
      already converted and nios2 is one of the few hat haven't yet. This also
      unblocks implementing the clone3() syscall on nios2. Once that is done we
      can get of another ARCH_WANTS_* macro.
      
      Once Any architecture that supports HAVE_COPY_THREAD_TLS cannot call the
      do_fork() helper anymore. This is fine and intended since it should be
      removed in favor of the new, cleaner _do_fork() calling convention based
      on struct kernel_clone_args. In fact, most architectures have already
      switched.  With this patch, nios2 joins the other arches which can't use
      the fork(), vfork(), clone(), clone3() syscalls directly and who follow
      the new process creation calling convention that is based on struct
      kernel_clone_args which we introduced a while back. This means less
      custom assembly in the architectures entry path to set up the registers
      before calling into the process creation helper and it is easier to to
      support new features without having to adapt calling conventions. It
      also unifies all process creation paths between fork(), vfork(),
      clone(), and clone3(). (We can't fix the ABI nightmare that legacy
      clone() is but we can prevent stuff like this happening in the future.)
      
      For some more context, please see:
      commit 606e9ad2
      Merge: ac61145a 457677c7
      Author: Linus Torvalds <torvalds@linux-foundation.org>
      Date:   Sat Jan 11 15:33:48 2020 -0800
      
          Merge tag 'clone3-tls-v5.5-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux
      
          Pull thread fixes from Christian Brauner:
           "This contains a series of patches to fix CLONE_SETTLS when used with
            clone3().
      
            The clone3() syscall passes the tls argument through struct clone_args
            instead of a register. This means, all architectures that do not
            implement copy_thread_tls() but still support CLONE_SETTLS via
            copy_thread() expecting the tls to be located in a register argument
            based on clone() are currently unfortunately broken. Their tls value
            will be garbage.
      
            The patch series fixes this on all architectures that currently define
            __ARCH_WANT_SYS_CLONE3. It also adds a compile-time check to ensure
            that any architecture that enables clone3() in the future is forced to
            also implement copy_thread_tls().
      
            My ultimate goal is to get rid of the copy_thread()/copy_thread_tls()
            split and just have copy_thread_tls() at some point in the not too
            distant future (Maybe even renaming copy_thread_tls() back to simply
            copy_thread() once the old function is ripped from all arches). This
            is dependent now on all arches supporting clone3().
      
            While all relevant arches do that now there are still four missing:
            ia64, m68k, sh and sparc. They have the system call reserved, but not
            implemented. Once they all implement clone3() we can get rid of
            ARCH_WANT_SYS_CLONE3 and HAVE_COPY_THREAD_TLS.
      
      Note that in the meantime, m68k has already switched to the new calling
      convention. And I've got sparc patches acked by Dave and ia64 is already
      done too. You can find a link to a booting qemu nios2 system with all the
      changes here at [1].
      
      [1]: https://asciinema.org/a/333353
      Cc: linux-kernel@vger.kernel.org
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
      Acked-by: default avatarLey Foon Tan <ley.foon.tan@intel.com>
      Signed-off-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
      04bd52fb
  2. 23 Jun, 2020 4 commits
    • Christian Brauner's avatar
      ia64: enable HAVE_COPY_THREAD_TLS, switch to kernel_clone_args · ddb815bd
      Christian Brauner authored
      This is part of a larger series that aims at getting rid of the
      copy_thread()/copy_thread_tls() split that makes the process creation
      codepaths in the kernel more convoluted and error-prone than they need
      to be.
      I'm converting all the remaining arches that haven't yet switched and
      am collecting individual acks. Once I have them, I'll send the whole series
      removing the copy_thread()/copy_thread_tls() split, the
      HAVE_COPY_THREAD_TLS define and the legacy do_fork() helper. The only
      kernel-wide process creation entry point for anything not going directly
      through the syscall path will then be based on struct kernel_clone_args.
      No more danger of weird process creation abi quirks between architectures
      hopefully, and easier to maintain overall.
      It also unblocks implementing clone3() on architectures not support
      copy_thread_tls(). Any architecture that wants to implement clone3()
      will need to select HAVE_COPY_THREAD_TLS and thus need to implement
      copy_thread_tls(). So both goals are connected but independently
      beneficial.
      
      HAVE_COPY_THREAD_TLS means that a given architecture supports
      CLONE_SETTLS and not setting it should usually mean that the
      architectures doesn't implement it but that's not how things are. In
      fact all architectures support CLONE_TLS it's just that they don't
      follow the calling convention that HAVE_COPY_THREAD_TLS implies. That
      means all architectures can be switched over to select
      HAVE_COPY_THREAD_TLS. Once that is done we can remove that macro (yay,
      less code), the unnecessary do_fork() export in kernel/fork.c, and also
      rename copy_thread_tls() back to copy_thread(). At this point
      copy_thread() becomes the main architecture specific part of process
      creation but it will be the same layout and calling convention for all
      architectures. (Once that is done we can probably cleanup each
      copy_thread() function even more but that's for the future.)
      
      Since ia64 does support CLONE_SETTLS there's no reason to not select
      HAVE_COPY_THREAD_TLS. This brings us one step closer to getting rid of
      the copy_thread()/copy_thread_tls() split we still have and ultimately
      the HAVE_COPY_THREAD_TLS define in general. A lot of architectures have
      already converted and ia64 is one of the few hat haven't yet. This also
      unblocks implementing the clone3() syscall on ia64. Once that is done we
      can get of another ARCH_WANTS_* macro.
      
      Once Any architecture that supports HAVE_COPY_THREAD_TLS cannot call the
      do_fork() helper anymore. This is fine and intended since it should be
      removed in favor of the new, cleaner _do_fork() calling convention based
      on struct kernel_clone_args. In fact, most architectures have already
      switched.  With this patch, ia64 joins the other arches which can't use
      the fork(), vfork(), clone(), clone3() syscalls directly and who follow
      the new process creation calling convention that is based on struct
      kernel_clone_args which we introduced a while back. This means less
      custom assembly in the architectures entry path to set up the registers
      before calling into the process creation helper and it is easier to to
      support new features without having to adapt calling conventions. It
      also unifies all process creation paths between fork(), vfork(),
      clone(), and clone3(). (We can't fix the ABI nightmare that legacy
      clone() is but we can prevent stuff like this happening in the future.)
      
      Well, the first version I nothing to test this with. I don't know how to
      reasonably explain what happened but thanks to Adrian I'm now sitting at
      home next to a HP Integrity RX2600. I've done some testing and my initial
      version had a bug that became obvious when I took a closer look. The switch
      stack logic assumes that ar.pfs is stored in r16 and I changed that to r2.
      So with that fixed the following test program runs without any problems:
      
       #ifndef _GNU_SOURCE
       #define _GNU_SOURCE 1
       #endif
       #include <errno.h>
       #include <fcntl.h>
       #include <linux/sched.h>
       #include <sched.h>
       #include <signal.h>
       #include <stdbool.h>
       #include <stdio.h>
       #include <stdlib.h>
       #include <string.h>
       #include <sys/stat.h>
       #include <sys/types.h>
       #include <sys/wait.h>
       #include <syscall.h>
       #include <unistd.h>
      
       #define IA64_SYSCALL_OFFSET 1024
       #ifndef __NR_clone
       #define __NR_clone (104 + IA64_SYSCALL_OFFSET)
       #endif
      
       #ifndef __NR_clone2
       #define __NR_clone2 (189 + IA64_SYSCALL_OFFSET)
       #endif
      
       /*
        * sys_clone(unsigned long flags,
        *	     unsigned long stack,
        *	     int *parent_tidptr,
        *	     int *child_tidptr,
        *	     unsigned long tls)
        */
       static pid_t ia64_raw_clone(void)
       {
       	return syscall(__NR_clone, SIGCHLD, 0, NULL, NULL, 0);
       }
      
       /*
        * sys_clone2(unsigned long flags,
        *	      unsigned long stack,
        *	      unsigned long stack_size,
        *	      int *parent_tidptr,
        *	      int *child_tidptr,
        *	      unsigned long tls)
        */
       static pid_t ia64_raw_clone2(void)
       {
       	return syscall(__NR_clone2, SIGCHLD, 0, 0, NULL, NULL, 0);
       }
      
       /*
        * Let's use the "standard stack limit" (i.e. glibc thread size default) for
        * stack sizes: 8MB.
        */
       #define __STACK_SIZE (8 * 1024 * 1024)
      
       /* This is not always defined in sched.h. */
       extern int __clone2 (int (*__fn) (void *__arg), void *__child_stack_base,
                            size_t __child_stack_size, int __flags, void *__arg, ...);
      
       pid_t libc_clone2(int (*fn)(void *), void *arg)
       {
       	pid_t ret;
       	void *stack;
      
       	stack = malloc(__STACK_SIZE);
       	if (!stack)
       		return -ENOMEM;
      
       	 return __clone2(fn, stack, __STACK_SIZE, SIGCHLD, arg, NULL, NULL, NULL);
       }
      
       static int libc_clone2_child(void *data)
       {
       	fprintf(stderr, "I'll just see myself out\n");
       	_exit(EXIT_SUCCESS);
       }
      
       int main(void)
       {
       	for (int i = 0; i < 1000; i++) {
       		pid_t pid = ia64_raw_clone();
       		if (pid < 0)
       			_exit(EXIT_FAILURE);
      
       		if (pid == 0)
       			_exit(EXIT_SUCCESS);
      
       		if (wait(NULL) != pid)
       			_exit(EXIT_FAILURE);
       		fprintf(stderr, "ia64_raw_clone() passed\n");
      
       		pid = ia64_raw_clone2();
       		if (pid < 0)
       			_exit(EXIT_FAILURE);
      
       		if (pid == 0)
       			_exit(EXIT_SUCCESS);
      
       		if (wait(NULL) != pid)
       			_exit(EXIT_FAILURE);
       		fprintf(stderr, "ia64_raw_clone2() passed\n");
      
       		pid = libc_clone2(libc_clone2_child, NULL);
       		if (pid < 0)
       			_exit(EXIT_FAILURE);
      
       		if (wait(NULL) != pid)
       			_exit(EXIT_FAILURE);
       		fprintf(stderr, "libc_clone2() passed\n");
       	}
      
       	_exit(EXIT_SUCCESS);
       }
      
      For some more context, please see:
      commit 606e9ad2
      Merge: ac61145a 457677c7
      Author: Linus Torvalds <torvalds@linux-foundation.org>
      Date:   Sat Jan 11 15:33:48 2020 -0800
      
          Merge tag 'clone3-tls-v5.5-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux
      
          Pull thread fixes from Christian Brauner:
           "This contains a series of patches to fix CLONE_SETTLS when used with
            clone3().
      
            The clone3() syscall passes the tls argument through struct clone_args
            instead of a register. This means, all architectures that do not
            implement copy_thread_tls() but still support CLONE_SETTLS via
            copy_thread() expecting the tls to be located in a register argument
            based on clone() are currently unfortunately broken. Their tls value
            will be garbage.
      
            The patch series fixes this on all architectures that currently define
            __ARCH_WANT_SYS_CLONE3. It also adds a compile-time check to ensure
            that any architecture that enables clone3() in the future is forced to
            also implement copy_thread_tls().
      
            My ultimate goal is to get rid of the copy_thread()/copy_thread_tls()
            split and just have copy_thread_tls() at some point in the not too
            distant future (Maybe even renaming copy_thread_tls() back to simply
            copy_thread() once the old function is ripped from all arches). This
            is dependent now on all arches supporting clone3().
      
            While all relevant arches do that now there are still four missing:
            ia64, m68k, sh and sparc. They have the system call reserved, but not
            implemented. Once they all implement clone3() we can get rid of
            ARCH_WANT_SYS_CLONE3 and HAVE_COPY_THREAD_TLS.
      
      Note that in the meantime, m68k has already switched to the new calling
      convention. And I've got sparc patches acked by Dave, too.
      Signed-off-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
      Cc: Tony Luck <tony.luck@intel.com>
      Cc: Fenghua Yu <fenghua.yu@intel.com>
      Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
      Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>
      Cc: Qais Yousef <qais.yousef@arm.com>
      Cc: linux-ia64@vger.kernel.org
      Cc: linux-kernel@vger.kernel.org
      Link: https://lore.kernel.org/r/20200517151635.3085756-1-christian.brauner@ubuntu.com
      ddb815bd
    • Christian Brauner's avatar
      sparc: unconditionally enable HAVE_COPY_THREAD_TLS · 7694f514
      Christian Brauner authored
      Now that both sparc and sparc64 support copy_thread_tls() and don't rely
      on do_fork() anymore, turn on HAVE_COPY_THREAD_TLS unconditionally. Once
      all architectures are switched over this macro will be removed and
      the old do_fork() calling convention fully abandoned in favor of the
      cleaner struct kernel_clone_args one.
      Signed-off-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
      Acked-by: default avatarDavid S. Miller <davem@davemloft.net>
      Cc: Arnd Bergmann <arnd@arndb.de>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Guo Ren <guoren@kernel.org>
      Cc: linux-csky@vger.kernel.org
      Cc: linux-kernel@vger.kernel.org
      Cc: sparclinux@vger.kernel.org
      Link: https://lore.kernel.org/r/20200512171527.570109-4-christian.brauner@ubuntu.com
      7694f514
    • Christian Brauner's avatar
      sparc: share process creation helpers between sparc and sparc64 · a4261d4b
      Christian Brauner authored
      As promised in the previous patch, this moves the process creation
      helpers into a common process.c file that is shared between sparc and
      sparc64. It allows us to get rid of quite a bit custom assembler and the
      to remove the separe 32bit specific sparc_do_fork() call.
      
      One thing to note, is that when clone() was called with a separate stack
      for the child the assembler would align it. But copy_thread() has always
      been doing that too so that line wasn't needed and can thus simply be
      removed.
      Signed-off-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
      Acked-by: default avatarDavid S. Miller <davem@davemloft.net>
      Cc: Arnd Bergmann <arnd@arndb.de>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Guo Ren <guoren@kernel.org>
      Cc: linux-csky@vger.kernel.org
      Cc: linux-kernel@vger.kernel.org
      Cc: sparclinux@vger.kernel.org
      Link: https://lore.kernel.org/r/20200512171527.570109-3-christian.brauner@ubuntu.com
      a4261d4b
    • Christian Brauner's avatar
      sparc64: enable HAVE_COPY_THREAD_TLS · dcad2a62
      Christian Brauner authored
      This is part of a larger series that aims at getting rid of the
      copy_thread()/copy_thread_tls() split that makes the process creation
      codepaths in the kernel more convoluted and error-prone than they need
      to be.
      It also unblocks implementing clone3() on architectures not support
      copy_thread_tls(). Any architecture that wants to implement clone3()
      will need to select HAVE_COPY_THREAD_TLS and thus need to implement
      copy_thread_tls(). So both goals are connected but independently
      beneficial.
      
      HAVE_COPY_THREAD_TLS means that a given architecture supports
      CLONE_SETTLS and not setting it should usually mean that the
      architectures doesn't implement it but that's not how things are. In
      fact all architectures support CLONE_TLS it's just that they don't
      follow the calling convention that HAVE_COPY_THREAD_TLS implies. That
      means all architectures can be switched over to select
      HAVE_COPY_THREAD_TLS. Once that is done we can remove that macro (yay,
      less code), the unnecessary do_fork() export in kernel/fork.c, and also
      rename copy_thread_tls() back to copy_thread(). At this point
      copy_thread() becomes the main architecture specific part of process
      creation but it will be the same layout and calling convention for all
      architectures. (Once that is done we can probably cleanup each
      copy_thread() function even more but that's for the future.)
      
      Since sparc does support CLONE_SETTLS there's no reason to not select
      HAVE_COPY_THREAD_TLS. This brings us one step closer to getting rid of
      the copy_thread()/copy_thread_tls() split we still have and ultimately
      the HAVE_COPY_THREAD_TLS define in general. A lot of architectures have
      already converted and sparc is one of the few hat haven't yet. This also
      unblocks implementing the clone3() syscall on sparc which I will follow
      up later (if no one gets there before me). Once that is done we can get
      of another ARCH_WANTS_* macro.
      
      This patch just switches sparc64 over to HAVE_COPY_THREAD_TLS but not
      sparc32 which will be done in the next patch. Once Any architecture that
      supports HAVE_COPY_THREAD_TLS cannot call the do_fork() helper anymore.
      This is fine and intended since it should be removed in favor of the
      new, cleaner _do_fork() calling convention based on struct
      kernel_clone_args. In fact, most architectures have already switched.
      With this patch, sparc joins the other arches which can't use the
      fork(), vfork(), clone(), clone3() syscalls directly and who follow the
      new process creation calling convention that is based on struct
      kernel_clone_args which we introduced a while back. This means less
      custom assembly in the architectures entry path to set up the registers
      before calling into the process creation helper and it is easier to to
      support new features without having to adapt calling conventions. It
      also unifies all process creation paths between fork(), vfork(),
      clone(), and clone3(). (We can't fix the ABI nightmare that legacy
      clone() is but we can prevent stuff like this happening in the future.)
      
      Note that sparc can't easily call into the syscalls directly because of
      its return value conventions when a new process is created which
      needs to clobber the UREG_I1 register in copy_thread{_tls()} and it
      needs to restore it if process creation fails. That's not a big deal
      since the new process creation calling convention makes things simpler.
      
      This removes sparc_do_fork() and replaces it with 3 clean helpers,
      sparc_fork(), sparc_vfork(), and sparc_clone(). That means a little more
      C code until the next patch unifies sparc 32bit and sparc64. It has the
      advantage that we can remove quite a bit of assembler and it makes the
      whole syscall.S process creation bits easier to read.
      The follow-up patch will remove the custom sparc_do_fork() helper for
      32bi sparc and move sparc_fork(), sparc_vfork(), and sparc_clone() into
      a common process.c file. This allows us to remove quite a bit of
      custom assembly form 32bit sparc's entry.S file too and allows to remove
      even more code because now all helpers are shared between 32bit sparc
      and sparc64 instead of having to maintain two separate sparc_do_fork()
      implementations.
      
      For some more context, please see:
      commit 606e9ad2
      Merge: ac61145a 457677c7
      Author: Linus Torvalds <torvalds@linux-foundation.org>
      Date:   Sat Jan 11 15:33:48 2020 -0800
      
          Merge tag 'clone3-tls-v5.5-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux
      
          Pull thread fixes from Christian Brauner:
           "This contains a series of patches to fix CLONE_SETTLS when used with
            clone3().
      
            The clone3() syscall passes the tls argument through struct clone_args
            instead of a register. This means, all architectures that do not
            implement copy_thread_tls() but still support CLONE_SETTLS via
            copy_thread() expecting the tls to be located in a register argument
            based on clone() are currently unfortunately broken. Their tls value
            will be garbage.
      
            The patch series fixes this on all architectures that currently define
            __ARCH_WANT_SYS_CLONE3. It also adds a compile-time check to ensure
            that any architecture that enables clone3() in the future is forced to
            also implement copy_thread_tls().
      
            My ultimate goal is to get rid of the copy_thread()/copy_thread_tls()
            split and just have copy_thread_tls() at some point in the not too
            distant future (Maybe even renaming copy_thread_tls() back to simply
            copy_thread() once the old function is ripped from all arches). This
            is dependent now on all arches supporting clone3().
      
            While all relevant arches do that now there are still four missing:
            ia64, m68k, sh and sparc. They have the system call reserved, but not
            implemented. Once they all implement clone3() we can get rid of
            ARCH_WANT_SYS_CLONE3 and HAVE_COPY_THREAD_TLS.
      
      Note that in the meantime, m68k has already switched to the new calling
      convention.
      Signed-off-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
      Acked-by: default avatarDavid S. Miller <davem@davemloft.net>
      Cc: Arnd Bergmann <arnd@arndb.de>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Guo Ren <guoren@kernel.org>
      Cc: linux-csky@vger.kernel.org
      Cc: linux-kernel@vger.kernel.org
      Cc: sparclinux@vger.kernel.org
      See: d95b56c7 ("openrisc: Cleanup copy_thread_tls docs and comments")
      See: 0b9f386c ("csky: Implement copy_thread_tls")
      Link: https://lore.kernel.org/r/20200512171527.570109-2-christian.brauner@ubuntu.com
      dcad2a62
  3. 22 Jun, 2020 1 commit
    • Christian Brauner's avatar
      fork: fold legacy_clone_args_valid() into _do_fork() · 3af8588c
      Christian Brauner authored
      This separate helper only existed to guarantee the mutual exclusivity of
      CLONE_PIDFD and CLONE_PARENT_SETTID for legacy clone since CLONE_PIDFD
      abuses the parent_tid field to return the pidfd. But we can actually handle
      this uniformely thus removing the helper. For legacy clone we can detect
      that CLONE_PIDFD is specified in conjunction with CLONE_PARENT_SETTID
      because they will share the same memory which is invalid and for clone3()
      setting the separate pidfd and parent_tid fields to the same memory is
      bogus as well. So fold that helper directly into _do_fork() by detecting
      this case.
      
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Al Viro <viro@zeniv.linux.org.uk>
      Cc: Geert Uytterhoeven <geert@linux-m68k.org>
      Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>
      Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>
      Cc: linux-m68k@lists.linux-m68k.org
      Cc: x86@kernel.org
      Signed-off-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
      3af8588c
  4. 21 Jun, 2020 10 commits
    • Linus Torvalds's avatar
      Linux 5.8-rc2 · 48778464
      Linus Torvalds authored
      48778464
    • Linus Torvalds's avatar
      Merge tag 'selinux-pr-20200621' of git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux · 817d914d
      Linus Torvalds authored
      Pull SELinux fixes from Paul Moore:
       "Three small patches to fix problems in the SELinux code, all found via
        clang.
      
        Two patches fix potential double-free conditions and one fixes an
        undefined return value"
      
      * tag 'selinux-pr-20200621' of git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux:
        selinux: fix undefined return of cond_evaluate_expr
        selinux: fix a double free in cond_read_node()/cond_read_list()
        selinux: fix double free
      817d914d
    • Linus Torvalds's avatar
      Merge tag 'pinctrl-v5.8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl · 16f4aa9b
      Linus Torvalds authored
      Pull pin control fixes from Linus Walleij:
       "Some early fixes collected during the first week after the merge
        window, all pretty self-evident, with the details below. The revert is
        the crucial thing.
      
         - Fix a warning on the Qualcomm SPMI GPIO chip being instatiated
           twice without a unique irqchip struct
      
         - Use the noirq variants of the suspend and resume callbacks in the
           Tegra driver
      
         - Clean up the errorpath on the MCP23s08 driver
      
         - Revert the use of devm_of_iomap() in the Freescale driver as it was
           regressing the platform
      
         - Add some missing pins in the Qualcomm IPQ6018 driver
      
         - Fix a simple documentation bug in the pinctrl-single driver"
      
      * tag 'pinctrl-v5.8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl:
        pinctrl: single: fix function name in documentation
        pinctrl: qcom: ipq6018 Add missing pins in qpic pin group
        Revert "pinctrl: freescale: imx: Use 'devm_of_iomap()' to avoid a resource leak in case of error in 'imx_pinctrl_probe()'"
        pinctrl: mcp23s08: Split to three parts: fix ptr_ret.cocci warnings
        pinctrl: tegra: Use noirq suspend/resume callbacks
        pinctrl: qcom: spmi-gpio: fix warning about irq chip reusage
      16f4aa9b
    • Linus Torvalds's avatar
      Merge tag 'kbuild-fixes-v5.8' of... · be9160a9
      Linus Torvalds authored
      Merge tag 'kbuild-fixes-v5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
      
      Pull Kbuild fixes from Masahiro Yamada:
      
       - fix -gz=zlib compiler option test for CONFIG_DEBUG_INFO_COMPRESSED
      
       - improve cc-option in scripts/Kbuild.include to clean up temp files
      
       - improve cc-option in scripts/Kconfig.include for more reliable
         compile option test
      
       - do not copy modules.builtin by 'make install' because it would break
         existing systems
      
       - use 'userprogs' syntax for watch_queue sample
      
      * tag 'kbuild-fixes-v5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild:
        samples: watch_queue: build sample program for target architecture
        Revert "Makefile: install modules.builtin even if CONFIG_MODULES=n"
        scripts: Fix typo in headers_install.sh
        kconfig: unify cc-option and as-option
        kbuild: improve cc-option to clean up all temporary files
        Makefile: Improve compressed debug info support detection
      be9160a9
    • Linus Torvalds's avatar
      Merge tag 'powerpc-5.8-3' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux · 75613939
      Linus Torvalds authored
      Pull powerpc fixes from Michael Ellerman:
      
       - One fix for the interrupt rework we did last release which broke
         KVM-PR
      
       - Three commits fixing some fallout from the READ_ONCE() changes
         interacting badly with our 8xx 16K pages support, which uses a pte_t
         that is a structure of 4 actual PTEs
      
       - A cleanup of the 8xx pte_update() to use the newly added pmd_off()
      
       - A fix for a crash when handling an oops if CONFIG_DEBUG_VIRTUAL is
         enabled
      
       - A minor fix for the SPU syscall generation
      
      Thanks to Aneesh Kumar K.V, Christian Zigotzky, Christophe Leroy, Mike
      Rapoport, Nicholas Piggin.
      
      * tag 'powerpc-5.8-3' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux:
        powerpc/8xx: Provide ptep_get() with 16k pages
        mm: Allow arches to provide ptep_get()
        mm/gup: Use huge_ptep_get() in gup_hugepte()
        powerpc/syscalls: Use the number when building SPU syscall table
        powerpc/8xx: use pmd_off() to access a PMD entry in pte_update()
        powerpc/64s: Fix KVM interrupt using wrong save area
        powerpc: Fix kernel crash in show_instructions() w/DEBUG_VIRTUAL
      75613939
    • Linus Torvalds's avatar
      Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6 · 93bbca27
      Linus Torvalds authored
      Pull crypto fixes from Herbert Xu:
      
       - NULL dereference in octeontx
      
       - PM reference imbalance in ks-sa
      
       - deadlock in crypto manager
      
       - memory leak in drbg
      
       - missing socket limit check on receive SG list size in algif_skcipher
      
       - typos in caam
      
       - warnings in ccp and hisilicon
      
      * 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6:
        crypto: drbg - always try to free Jitter RNG instance
        crypto: marvell/octeontx - Fix a potential NULL dereference
        crypto: algboss - don't wait during notifier callback
        crypto: caam - fix typos
        crypto: ccp - Fix sparse warnings in sev-dev
        crypto: hisilicon - Cap block size at 2^31
        crypto: algif_skcipher - Cap recv SG list at ctx->used
        hwrng: ks-sa - Fix runtime PM imbalance on error
      93bbca27
    • Masahiro Yamada's avatar
      samples: watch_queue: build sample program for target architecture · 214377e9
      Masahiro Yamada authored
      This userspace program includes UAPI headers exported to usr/include/.
      'make headers' always works for the target architecture (i.e. the same
      architecture as the kernel), so the sample program should be built for
      the target as well. Kbuild now supports 'userprogs' for that.
      
      I also guarded the CONFIG option by 'depends on CC_CAN_LINK' because
      $(CC) may not provide libc.
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      214377e9
    • Masahiro Yamada's avatar
      Revert "Makefile: install modules.builtin even if CONFIG_MODULES=n" · 2c6d9636
      Masahiro Yamada authored
      This reverts commit e0b250b5,
      which broke build systems that need to install files to a certain
      path, but do not set INSTALL_MOD_PATH when invoking 'make install'.
      
        $ make INSTALL_PATH=/tmp/destdir install
        mkdir: cannot create directory ‘/lib/modules/5.8.0-rc1+/’: Permission denied
        Makefile:1342: recipe for target '_builtin_inst_' failed
        make: *** [_builtin_inst_] Error 1
      
      While modules.builtin is useful also for CONFIG_MODULES=n, this change
      in the behavior is quite unexpected. Maybe "make modules_install"
      can install modules.builtin irrespective of CONFIG_MODULES as Jonas
      originally suggested.
      
      Anyway, that commit should be reverted ASAP.
      Reported-by: default avatarDouglas Anderson <dianders@chromium.org>
      Reported-by: default avatarGuenter Roeck <linux@roeck-us.net>
      Cc: Jonas Karlman <jonas@kwiboo.se>
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
      Tested-by: default avatarGuenter Roeck <linux@roeck-us.net>
      2c6d9636
    • Linus Torvalds's avatar
      Merge tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi · 64677779
      Linus Torvalds authored
      Pull SCSI fixes from James Bottomley:
       "One minor fix and two patches reworking the ata dma drain for the
        !CONFIG_LIBATA case. The latter is a 5.7 regression fix"
      
      * tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi:
        scsi: Wire up ata_scsi_dma_need_drain for SAS HBA drivers
        scsi: libata: Provide an ata_scsi_dma_need_drain stub for !CONFIG_ATA
        scsi: ufs-bsg: Fix runtime PM imbalance on error
      64677779
    • Linus Torvalds's avatar
      Merge branch 'i2c/for-current' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux · a5c6a1f0
      Linus Torvalds authored
      Pull i2c fixes from Wolfram Sang:
      
       - a small collection of remaining API conversion patches (all acked)
         which allow to finally remove the deprecated API
      
       - some documentation fixes and a MAINTAINERS addition
      
      * 'i2c/for-current' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux:
        MAINTAINERS: Add robert and myself as qcom i2c cci maintainers
        i2c: smbus: Fix spelling mistake in the comments
        Documentation/i2c: SMBus start signal is S not A
        i2c: remove deprecated i2c_new_device API
        Documentation: media: convert to use i2c_new_client_device()
        video: backlight: tosa_lcd: convert to use i2c_new_client_device()
        x86/platform/intel-mid: convert to use i2c_new_client_device()
        drm: encoder_slave: use new I2C API
        drm: encoder_slave: fix refcouting error for modules
      a5c6a1f0
  5. 20 Jun, 2020 13 commits
    • Drew Fustini's avatar
      pinctrl: single: fix function name in documentation · 25fae752
      Drew Fustini authored
      Use the correct the function name in the documentation for
      "pcs_parse_one_pinctrl_entry()".
      
      "smux_parse_one_pinctrl_entry()" appears to be an artifact from the
      development of a prior patch series ("simple pinmux driver") which
      transformed into pinctrl-single.
      Signed-off-by: default avatarDrew Fustini <drew@beagleboard.org>
      Link: https://lore.kernel.org/r/20200612112758.GA3407886@x1Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      25fae752
    • Linus Torvalds's avatar
      Merge tag 'trace-v5.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace · 8b6ddd10
      Linus Torvalds authored
      Pull tracing fixes from Steven Rostedt:
      
       - Have recordmcount work with > 64K sections (to support LTO)
      
       - kprobe RCU fixes
      
       - Correct a kprobe critical section with missing mutex
      
       - Remove redundant arch_disarm_kprobe() call
      
       - Fix lockup when kretprobe triggers within kprobe_flush_task()
      
       - Fix memory leak in fetch_op_data operations
      
       - Fix sleep in atomic in ftrace trace array sample code
      
       - Free up memory on failure in sample trace array code
      
       - Fix incorrect reporting of function_graph fields in format file
      
       - Fix quote within quote parsing in bootconfig
      
       - Fix return value of bootconfig tool
      
       - Add testcases for bootconfig tool
      
       - Fix maybe uninitialized warning in ftrace pid file code
      
       - Remove unused variable in tracing_iter_reset()
      
       - Fix some typos
      
      * tag 'trace-v5.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace:
        ftrace: Fix maybe-uninitialized compiler warning
        tools/bootconfig: Add testcase for show-command and quotes test
        tools/bootconfig: Fix to return 0 if succeeded to show the bootconfig
        tools/bootconfig: Fix to use correct quotes for value
        proc/bootconfig: Fix to use correct quotes for value
        tracing: Remove unused event variable in tracing_iter_reset
        tracing/probe: Fix memleak in fetch_op_data operations
        trace: Fix typo in allocate_ftrace_ops()'s comment
        tracing: Make ftrace packed events have align of 1
        sample-trace-array: Remove trace_array 'sample-instance'
        sample-trace-array: Fix sleeping function called from invalid context
        kretprobe: Prevent triggering kretprobe from within kprobe_flush_task
        kprobes: Remove redundant arch_disarm_kprobe() call
        kprobes: Fix to protect kick_kprobe_optimizer() by kprobe_mutex
        kprobes: Use non RCU traversal APIs on kprobe_tables if possible
        kprobes: Suppress the suspicious RCU warning on kprobes
        recordmcount: support >64k sections
      8b6ddd10
    • Linus Torvalds's avatar
      Merge tag 'libnvdimm-for-5.8-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm · eede2b9b
      Linus Torvalds authored
      Pull libnvdimm updates from Dan Williams:
       "A feature (papr_scm health retrieval) and a fix (sysfs attribute
        visibility) for v5.8.
      
        Vaibhav explains in the merge commit below why missing v5.8 would be
        painful and I agreed to try a -rc2 pull because only cosmetics kept
        this out of -rc1 and his initial versions were posted in more than
        enough time for v5.8 consideration:
      
         'These patches are tied to specific features that were committed to
          customers in upcoming distros releases (RHEL and SLES) whose
          time-lines are tied to 5.8 kernel release.
      
          Being able to track the health of an nvdimm is critical for our
          customers that are running workloads leveraging papr-scm nvdimms.
          Missing the 5.8 kernel would mean missing the distro timelines and
          shifting forward the availability of this feature in distro kernels
          by at least 6 months'
      
        Summary:
      
         - Fix the visibility of the region 'align' attribute.
      
           The new unit tests for region alignment handling caught a corner
           case where the alignment cannot be specified if the region is
           converted from static to dynamic provisioning at runtime.
      
         - Add support for device health retrieval for the persistent memory
           supported by the papr_scm driver.
      
           This includes both the standard sysfs "health flags" that the nfit
           persistent memory driver publishes and a mechanism for the ndctl
           tool to retrieve a health-command payload"
      
      * tag 'libnvdimm-for-5.8-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm:
        nvdimm/region: always show the 'align' attribute
        powerpc/papr_scm: Implement support for PAPR_PDSM_HEALTH
        ndctl/papr_scm,uapi: Add support for PAPR nvdimm specific methods
        powerpc/papr_scm: Improve error logging and handling papr_scm_ndctl()
        powerpc/papr_scm: Fetch nvdimm health information from PHYP
        seq_buf: Export seq_buf_printf
        powerpc: Document details on H_SCM_HEALTH hcall
      eede2b9b
    • Sivaprakash Murugesan's avatar
      pinctrl: qcom: ipq6018 Add missing pins in qpic pin group · 7f5f4de8
      Sivaprakash Murugesan authored
      The patch adds missing qpic data pins to qpic pingroup. These pins are
      necessary for the qpic nand to work.
      
      Fixes: ef1ea54e ("pinctrl: qcom: Add ipq6018 pinctrl driver")
      Signed-off-by: default avatarSivaprakash Murugesan <sivaprak@codeaurora.org>
      Link: https://lore.kernel.org/r/1592541089-17700-1-git-send-email-sivaprak@codeaurora.orgSigned-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      7f5f4de8
    • Haibo Chen's avatar
      Revert "pinctrl: freescale: imx: Use 'devm_of_iomap()' to avoid a resource... · 13f2d25b
      Haibo Chen authored
      Revert "pinctrl: freescale: imx: Use 'devm_of_iomap()' to avoid a resource leak in case of error in 'imx_pinctrl_probe()'"
      
      This reverts commit ba403242.
      
      After commit 26d8cde5 ("pinctrl: freescale: imx: add shared
      input select reg support"). i.MX7D has two iomux controllers
      iomuxc and iomuxc-lpsr which share select_input register for
      daisy chain settings.
      If use 'devm_of_iomap()', when probe the iomuxc-lpsr, will call
      devm_request_mem_region() for the region <0x30330000-0x3033ffff>
      for the first time. Then, next time when probe the iomuxc, API
      devm_platform_ioremap_resource() will also use the API
      devm_request_mem_region() for the share region <0x30330000-0x3033ffff>
      again, then cause issue, log like below:
      
      [    0.179561] imx7d-pinctrl 302c0000.iomuxc-lpsr: initialized IMX pinctrl driver
      [    0.191742] imx7d-pinctrl 30330000.pinctrl: can't request region for resource [mem 0x30330000-0x3033ffff]
      [    0.191842] imx7d-pinctrl: probe of 30330000.pinctrl failed with error -16
      
      Fixes: ba403242 ("pinctrl: freescale: imx: Use 'devm_of_iomap()' to avoid a resource leak in case of error in 'imx_pinctrl_probe()'")
      Signed-off-by: default avatarHaibo Chen <haibo.chen@nxp.com>
      Reviewed-by: default avatarDong Aisheng <aisheng.dong@nxp.com>
      Link: https://lore.kernel.org/r/1591673223-1680-1-git-send-email-haibo.chen@nxp.comSigned-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      13f2d25b
    • Linus Torvalds's avatar
      Merge tag 's390-5.8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux · 1566feea
      Linus Torvalds authored
      Pull s390 fixes from Vasily Gorbik:
      
       - a few ptrace fixes mostly for strace and seccomp_bpf kernel tests
         findings
      
       - cleanup unused pm callbacks in virtio ccw
      
       - replace kmalloc + memset with kzalloc in crypto
      
       - use $(LD) for vDSO linkage to make clang happy
      
       - fix vDSO clock_getres() to preserve the same behaviour as
         posix_get_hrtimer_res()
      
       - fix workqueue cpumask warning when NUMA=n and nr_node_ids=2
      
       - reduce SLSB writes during input processing, improve warnings and
         cleanup qdio_data usage in qdio
      
       - a few fixes to use scnprintf() instead of snprintf()
      
      * tag 's390-5.8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux:
        s390: fix syscall_get_error for compat processes
        s390/qdio: warn about unexpected SLSB states
        s390/qdio: clean up usage of qdio_data
        s390/numa: let NODES_SHIFT depend on NEED_MULTIPLE_NODES
        s390/vdso: fix vDSO clock_getres()
        s390/vdso: Use $(LD) instead of $(CC) to link vDSO
        s390/protvirt: use scnprintf() instead of snprintf()
        s390: use scnprintf() in sys_##_prefix##_##_name##_show
        s390/crypto: use scnprintf() instead of snprintf()
        s390/zcrypt: use kzalloc
        s390/virtio: remove unused pm callbacks
        s390/qdio: reduce SLSB writes during Input Queue processing
        selftests/seccomp: s390 shares the syscall and return value register
        s390/ptrace: fix setting syscall number
        s390/ptrace: pass invalid syscall numbers to tracing
        s390/ptrace: return -ENOSYS when invalid syscall is supplied
        s390/seccomp: pass syscall arguments via seccomp_data
        s390/qdio: fine-tune SLSB update
      1566feea
    • Linus Torvalds's avatar
      Merge tag 'riscv-for-linus-5.8-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux · 7fdfbe08
      Linus Torvalds authored
      Pull RISC-V fixes from Palmer Dabbelt:
      
       - a workaround for a compiler surprise related to the "r" inline
         assembly that allows LLVM to boot.
      
       - a fix to avoid WX-only mappings, which the ISA does not allow. While
         this probably manifests in many ways, the bug was found in stress-ng.
      
       - a missing lock in set_direct_map_*(), which due to a recent lockdep
         change started asserting.
      
      * tag 'riscv-for-linus-5.8-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux:
        RISC-V: Acquire mmap lock before invoking walk_page_range
        RISC-V: Don't allow write+exec only page mapping request in mmap
        riscv/atomic: Fix sign extension for RV64I
      7fdfbe08
    • Linus Torvalds's avatar
      Merge tag 'linux-kselftest-5.8-rc2' of... · 27c27605
      Linus Torvalds authored
      Merge tag 'linux-kselftest-5.8-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest
      
      Pull kselftest cleanups from Shuah Khan:
      
       - ftrace "requires:" list for simplifying and unifying requirement
         checks for each test case, adding "requires:" line instead of
         checking required ftrace interfaces in each test case.
      
       - a minor spelling correction patch
      
      * tag 'linux-kselftest-5.8-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest:
        selftests/ftrace: Support ":README" suffix for requires
        selftests/ftrace: Support ":tracer" suffix for requires
        selftests/ftrace: Convert check_filter_file() with requires list
        selftests/ftrace: Convert required interface checks into requires list
        selftests/ftrace: Add "requires:" list support
        selftests/ftrace: Return unsupported for the unconfigured features
        selftests/ftrace: Allow ":" in description
        tools: testing: ftrace: trigger: fix spelling mistake
      27c27605
    • David Howells's avatar
      afs: Fix hang on rmmod due to outstanding timer · 5481fc6e
      David Howells authored
      The fileserver probe timer, net->fs_probe_timer, isn't cancelled when
      the kafs module is being removed and so the count it holds on
      net->servers_outstanding doesn't get dropped..
      
      This causes rmmod to wait forever.  The hung process shows a stack like:
      
      	afs_purge_servers+0x1b5/0x23c [kafs]
      	afs_net_exit+0x44/0x6e [kafs]
      	ops_exit_list+0x72/0x93
      	unregister_pernet_operations+0x14c/0x1ba
      	unregister_pernet_subsys+0x1d/0x2a
      	afs_exit+0x29/0x6f [kafs]
      	__do_sys_delete_module.isra.0+0x1a2/0x24b
      	do_syscall_64+0x51/0x95
      	entry_SYSCALL_64_after_hwframe+0x44/0xa9
      
      Fix this by:
      
       (1) Attempting to cancel the probe timer and, if successful, drop the
           count that the timer was holding.
      
       (2) Make the timer function just drop the count and not schedule the
           prober if the afs portion of net namespace is being destroyed.
      
      Also, whilst we're at it, make the following changes:
      
       (3) Initialise net->servers_outstanding to 1 and decrement it before
           waiting on it so that it doesn't generate wake up events by being
           decremented to 0 until we're cleaning up.
      
       (4) Switch the atomic_dec() on ->servers_outstanding for ->fs_timer in
           afs_purge_servers() to use the helper function for that.
      
      Fixes: f6cbb368 ("afs: Actively poll fileservers to maintain NAT or firewall openings")
      Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      5481fc6e
    • David Howells's avatar
      afs: Fix afs_do_lookup() to call correct fetch-status op variant · f8ea5c7b
      David Howells authored
      Fix afs_do_lookup()'s fallback case for when FS.InlineBulkStatus isn't
      supported by the server.
      
      In the fallback, it calls FS.FetchStatus for the specific vnode it's
      meant to be looking up.  Commit b6489a49 broke this by renaming one
      of the two identically-named afs_fetch_status_operation descriptors to
      something else so that one of them could be made non-static.  The site
      that used the renamed one, however, wasn't renamed and didn't produce
      any warning because the other was declared in a header.
      
      Fix this by making afs_do_lookup() use the renamed variant.
      
      Note that there are two variants of the success method because one is
      called from ->lookup() where we may or may not have an inode, but can't
      call iget until after we've talked to the server - whereas the other is
      called from within iget where we have an inode, but it may or may not be
      initialised.
      
      The latter variant expects there to be an inode, but because it's being
      called from there former case, there might not be - resulting in an oops
      like the following:
      
        BUG: kernel NULL pointer dereference, address: 00000000000000b0
        ...
        RIP: 0010:afs_fetch_status_success+0x27/0x7e
        ...
        Call Trace:
          afs_wait_for_operation+0xda/0x234
          afs_do_lookup+0x2fe/0x3c1
          afs_lookup+0x3c5/0x4bd
          __lookup_slow+0xcd/0x10f
          walk_component+0xa2/0x10c
          path_lookupat.isra.0+0x80/0x110
          filename_lookup+0x81/0x104
          vfs_statx+0x76/0x109
          __do_sys_newlstat+0x39/0x6b
          do_syscall_64+0x4c/0x78
          entry_SYSCALL_64_after_hwframe+0x44/0xa9
      
      Fixes: b6489a49 ("afs: Fix silly rename")
      Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      f8ea5c7b
    • Christophe Leroy's avatar
      powerpc/8xx: Provide ptep_get() with 16k pages · c0e1c8c2
      Christophe Leroy authored
      READ_ONCE() now enforces atomic read, which leads to:
      
        CC      mm/gup.o
      In file included from ./include/linux/kernel.h:11:0,
                       from mm/gup.c:2:
      In function 'gup_hugepte.constprop',
          inlined from 'gup_huge_pd.isra.79' at mm/gup.c:2465:8:
      ./include/linux/compiler.h:392:38: error: call to '__compiletime_assert_222' declared with attribute error: Unsupported access size for {READ,WRITE}_ONCE().
        _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
                                            ^
      ./include/linux/compiler.h:373:4: note: in definition of macro '__compiletime_assert'
          prefix ## suffix();    \
          ^
      ./include/linux/compiler.h:392:2: note: in expansion of macro '_compiletime_assert'
        _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
        ^
      ./include/linux/compiler.h:405:2: note: in expansion of macro 'compiletime_assert'
        compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
        ^
      ./include/linux/compiler.h:291:2: note: in expansion of macro 'compiletime_assert_rwonce_type'
        compiletime_assert_rwonce_type(x);    \
        ^
      mm/gup.c:2428:8: note: in expansion of macro 'READ_ONCE'
        pte = READ_ONCE(*ptep);
              ^
      In function 'gup_get_pte',
          inlined from 'gup_pte_range' at mm/gup.c:2228:9,
          inlined from 'gup_pmd_range' at mm/gup.c:2613:15,
          inlined from 'gup_pud_range' at mm/gup.c:2641:15,
          inlined from 'gup_p4d_range' at mm/gup.c:2666:15,
          inlined from 'gup_pgd_range' at mm/gup.c:2694:15,
          inlined from 'internal_get_user_pages_fast' at mm/gup.c:2795:3:
      ./include/linux/compiler.h:392:38: error: call to '__compiletime_assert_219' declared with attribute error: Unsupported access size for {READ,WRITE}_ONCE().
        _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
                                            ^
      ./include/linux/compiler.h:373:4: note: in definition of macro '__compiletime_assert'
          prefix ## suffix();    \
          ^
      ./include/linux/compiler.h:392:2: note: in expansion of macro '_compiletime_assert'
        _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
        ^
      ./include/linux/compiler.h:405:2: note: in expansion of macro 'compiletime_assert'
        compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
        ^
      ./include/linux/compiler.h:291:2: note: in expansion of macro 'compiletime_assert_rwonce_type'
        compiletime_assert_rwonce_type(x);    \
        ^
      mm/gup.c:2199:9: note: in expansion of macro 'READ_ONCE'
        return READ_ONCE(*ptep);
               ^
      make[2]: *** [mm/gup.o] Error 1
      
      Define ptep_get() on 8xx when using 16k pages.
      
      Fixes: 9e343b46 ("READ_ONCE: Enforce atomicity for {READ,WRITE}_ONCE() memory accesses")
      Signed-off-by: default avatarChristophe Leroy <christophe.leroy@csgroup.eu>
      Acked-by: default avatarWill Deacon <will@kernel.org>
      Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
      Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
      Link: https://lore.kernel.org/r/341688399c1b102756046d19ea6ce39db1ae4742.1592225558.git.christophe.leroy@csgroup.eu
      c0e1c8c2
    • Christophe Leroy's avatar
      mm: Allow arches to provide ptep_get() · 481e980a
      Christophe Leroy authored
      Since commit 9e343b46 ("READ_ONCE: Enforce atomicity for
      {READ,WRITE}_ONCE() memory accesses") it is not possible anymore to
      use READ_ONCE() to access complex page table entries like the one
      defined for powerpc 8xx with 16k size pages.
      
      Define a ptep_get() helper that architectures can override instead
      of performing a READ_ONCE() on the page table entry pointer.
      
      Fixes: 9e343b46 ("READ_ONCE: Enforce atomicity for {READ,WRITE}_ONCE() memory accesses")
      Signed-off-by: default avatarChristophe Leroy <christophe.leroy@csgroup.eu>
      Acked-by: default avatarWill Deacon <will@kernel.org>
      Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
      Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
      Link: https://lore.kernel.org/r/087fa12b6e920e32315136b998aa834f99242695.1592225558.git.christophe.leroy@csgroup.eu
      481e980a
    • Christophe Leroy's avatar
      mm/gup: Use huge_ptep_get() in gup_hugepte() · 55ca2263
      Christophe Leroy authored
      gup_hugepte() reads hugepage table entries, it can't read
      them directly, huge_ptep_get() must be used.
      
      Fixes: 9e343b46 ("READ_ONCE: Enforce atomicity for {READ,WRITE}_ONCE() memory accesses")
      Signed-off-by: default avatarChristophe Leroy <christophe.leroy@csgroup.eu>
      Acked-by: default avatarWill Deacon <will@kernel.org>
      Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
      Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
      Link: https://lore.kernel.org/r/ffc3714334c3bfaca6f13788ad039e8759ae413f.1592225558.git.christophe.leroy@csgroup.eu
      55ca2263
  6. 19 Jun, 2020 1 commit
    • Dan Williams's avatar
      Merge branch 'for-5.8/papr_scm' into libnvdimm-for-next · 9df24eae
      Dan Williams authored
      Include the papr_scm health retrieval feature for v5.8-rc2. The
      functionality was initially posted well in advance of the merge window,
      but review comments and a late build-bot warning kept them out of the
      v5.8-rc1 libnvdimm pull request.
      
      Vaibhav notes:
      These patches are tied to specific features that were committed to
      customers in upcoming distros releases (RHEL and SLES) whose time-lines
      are tied to 5.8 kernel release.
      
      Being able to track the health of an nvdimm is critical for our
      customers that are running workloads leveraging papr-scm nvdimms.
      Missing the 5.8 kernel would mean missing the distro timelines and
      shifting forward the availability of this feature in distro kernels by
      at least 6 months.
      9df24eae