1. 29 Mar, 2021 2 commits
  2. 25 Mar, 2021 17 commits
  3. 24 Mar, 2021 14 commits
  4. 23 Mar, 2021 2 commits
  5. 22 Mar, 2021 4 commits
  6. 19 Mar, 2021 1 commit
    • Mark Brown's avatar
      Merge series "ASoC: tidyup error message timing" from Kuninori Morimoto... · 3722e4ec
      Mark Brown authored
      Merge series "ASoC: tidyup error message timing" from Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>:
      
      Hi Mark
      
      Indicating error message when failed case is very useful for debuging.
      In many case, it uses below style.
      
      	int function(...)
      	{
      		...
      		return ret;
      	}
      
      	int caller(...)
      	{
      		...
      		ret = function(...);
      		if (ret < 0)
      			dev_err(...)
      		...
      	}
      
      This is not so bad, but in this style *each caller* needs to indicate
      duplicate same error message, and some caller is forgetting to do it.
      And caller can't indicate detail function() error information.
      
      I know many people have many opinion, but if function() indicates error
      message, we can get same and detail information without forgot, and it is better.
      This patch-set tidyup to do it.
      
      	int function(...)
      	{
      		...
      		if (ret < 0)
      			dev_err(...)
      
      		return ret;
      	}
      
      	int caller(...)
      	{
      		...
      		ret = function(...);
      		...
      	}
      
      Kuninori Morimoto (14):
        ASoC: soc-pcm: indicate error message at soc_pcm_open()
        ASoC: soc-pcm: indicate error message at soc_pcm_hw_params()
        ASoC: soc-pcm: indicate error message at soc_pcm_prepare()
        ASoC: soc-pcm: indicate error message at dpcm_path_get()
        ASoC: soc-pcm: indicate error message at dpcm_be_dai_trigger()
        ASoC: soc-pcm: indicate error message at dpcm_apply_symmetry()
        ASoC: soc-pcm: indicate error message at dpcm_run_update_startup/shutdown()
        ASoC: soc-pcm: indicate error message at dpcm_fe/be_dai_startup()
        ASoC: soc-pcm: indicate error message at dpcm_fe/be_dai_hw_params()
        ASoC: soc-pcm: indicate error message at dpcm_fe/be_dai_prepare()
        ASoC: soc-pcm: don't indicate error message for soc_pcm_hw_free()
        ASoC: soc-pcm: don't indicate error message for dpcm_be_dai_hw_free()
        ASoC: don't indicate error message for snd_soc_[pcm_]dai_xxx()
        ASoC: don't indicate error message for snd_soc_[pcm_]component_xxx()
      
       include/sound/soc-dpcm.h |   2 +-
       sound/soc/soc-compress.c |   9 +-
       sound/soc/soc-core.c     |  22 +----
       sound/soc/soc-dapm.c     |  24 ++---
       sound/soc/soc-pcm.c      | 197 +++++++++++++++++++--------------------
       5 files changed, 108 insertions(+), 146 deletions(-)
      
      --
      2.25.1
      3722e4ec