1. 06 Jul, 2020 13 commits
    • Lee Jones's avatar
      mfd: db8500-prcmu: Add description for 'reset_reason' in kerneldoc · 3ecbcd20
      Lee Jones authored
      Each function parameter should be documented in kerneldoc format.
      
      Squashes the following W=1 warnings:
      
       drivers/mfd/db8500-prcmu.c:2281: warning: Function parameter or member 'reset_code' not described in 'db8500_prcmu_system_reset'
       drivers/mfd/db8500-prcmu.c:3012: warning: Function parameter or member 'pdev' not described in 'db8500_prcmu_probe'
      
      Cc: Linus Walleij <linus.walleij@linaro.org>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      3ecbcd20
    • Lee Jones's avatar
      mfd: mfd-core: Complete kerneldoc header for devm_mfd_add_devices() · 5a0ffef8
      Lee Jones authored
      Each function parameter should be documented in kerneldoc format.
      
      Squashes the following W=1 warnings:
      
       drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'dev' not described in 'devm_mfd_add_devices'
       drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'id' not described in 'devm_mfd_add_devices'
       drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'cells' not described in 'devm_mfd_add_devices'
       drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'n_devs' not described in 'devm_mfd_add_devices'
       drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'mem_base' not described in 'devm_mfd_add_devices'
       drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'irq_base' not described in 'devm_mfd_add_devices'
       drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'domain' not described in 'devm_mfd_add_devices'
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      5a0ffef8
    • Lee Jones's avatar
      mfd: wm8350-core: Supply description wm8350_reg_{un}lock args · afb718a8
      Lee Jones authored
      Kerneldoc syntax is used, but not complete.  Descriptions required.
      
      Prevents warnings like:
      
       drivers/mfd/wm8350-core.c:136: warning: Function parameter or member 'wm8350' not described in 'wm8350_reg_lock'
       drivers/mfd/wm8350-core.c:165: warning: Function parameter or member 'wm8350' not described in 'wm8350_reg_unlock'
      
      Cc: patches@opensource.cirrus.com
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      afb718a8
    • Lee Jones's avatar
      mfd: wm831x-core: Supply description wm831x_reg_{un}lock args · 38ea9f47
      Lee Jones authored
      Kerneldoc syntax is used, but not complete.  Descriptions required.
      
      Prevents warnings like:
      
       drivers/mfd/wm831x-core.c:119: warning: Function parameter or member 'wm831x' not described in 'wm831x_reg_lock'
       drivers/mfd/wm831x-core.c:145: warning: Function parameter or member 'wm831x' not described in 'wm831x_reg_unlock'
      
      Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
      Cc: patches@opensource.cirrus.com
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Acked-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      38ea9f47
    • Lee Jones's avatar
      mfd: wm8400-core: Supply description for wm8400_reset_codec_reg_cache's arg · f139ef70
      Lee Jones authored
      Kerneldoc syntax is used, but not complete.  Descriptions required.
      
      Prevents warnings like:
      
       drivers/mfd/wm8400-core.c:113: warning: Function parameter or member 'wm8400' not described in 'wm8400_reset_codec_reg_cache'
      
      Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
      Cc: patches@opensource.cirrus.com
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Acked-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      f139ef70
    • Lee Jones's avatar
      mfd: tc3589x: Remove invalid use of kerneldoc syntax · 0dfae4a3
      Lee Jones authored
      Kerneldoc is for documenting function arguments and return values.
      
      Prevents warnings like:
      
       drivers/mfd/tc3589x.c:32: warning: Enum value 'TC3589X_TC35890' not described in enum 'tc3589x_version'
       drivers/mfd/tc3589x.c:32: warning: Enum value 'TC3589X_TC35892' not described in enum 'tc3589x_version'
       drivers/mfd/tc3589x.c:32: warning: Enum value 'TC3589X_TC35893' not described in enum 'tc3589x_version'
       drivers/mfd/tc3589x.c:32: warning: Enum value 'TC3589X_TC35894' not described in enum 'tc3589x_version'
       drivers/mfd/tc3589x.c:32: warning: Enum value 'TC3589X_TC35895' not described in enum 'tc3589x_version'
       drivers/mfd/tc3589x.c:32: warning: Enum value 'TC3589X_TC35896' not described in enum 'tc3589x_version'
       drivers/mfd/tc3589x.c:32: warning: Enum value 'TC3589X_UNKNOWN' not described in enum 'tc3589x_version'
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      0dfae4a3
    • Lee Jones's avatar
      mfd: ab8500-debugfs: Fix incompatible types in comparison expression issue · ddb6b26c
      Lee Jones authored
      Smatch reports:
      
       drivers/mfd/ab8500-debugfs.c:1804:20: error: incompatible types in comparison expression (different type sizes):
       drivers/mfd/ab8500-debugfs.c:1804:20:    unsigned int *
       drivers/mfd/ab8500-debugfs.c:1804:20:    unsigned long *
      
      This is due to mixed types being compared in a min() comparison.  Fix
      this by treating values as signed and casting them to the same type
      as the receiving variable.
      
      Cc: Linus Walleij <linus.walleij@linaro.org>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      ddb6b26c
    • Lee Jones's avatar
      mfd: ab3100-core: Fix incompatible types in comparison expression warning · 54daa5d4
      Lee Jones authored
      Smatch reports:
      
       drivers/mfd/ab3100-core.c:501:20: error: incompatible types in comparison expression (different type sizes):
       drivers/mfd/ab3100-core.c:501:20:    unsigned int *
       drivers/mfd/ab3100-core.c:501:20:    unsigned long *
       drivers/mfd/ab8500-debugfs.c:1804:20: error: incompatible types in comparison expression (different type sizes):
       drivers/mfd/ab8500-debugfs.c:1804:20:    unsigned int *
       drivers/mfd/ab8500-debugfs.c:1804:20:    unsigned long *
      
      Since the second min() argument can be less than 0 a signed
      variable is required for assignment.  However, the non-sized
      type size_t is passed in from the userspace handlers.  In order
      to firstly compare, then assign the smallest value, we firstly
      need to cast them both to the same as the receiving size_t typed
      variable.
      
      Cc: Linus Walleij <linus.walleij@linaro.org>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      54daa5d4
    • Lee Jones's avatar
      mfd: sprd-sc27xx-spi: Fix symbol 'sprd_pmic_detect_charger_type' was not declared warning · 3d4a8757
      Lee Jones authored
      Sparse reports:
      
       drivers/mfd/sprd-sc27xx-spi.c:59:23: warning: symbol 'sprd_pmic_detect_charger_type' was not declared. Should it be static?
      
      ... due to a missing header file.
      
      Cc: Orson Zhai <orsonzhai@gmail.com>
      Cc: Chunyan Zhang <zhang.lyra@gmail.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Reviewed-by: default avatarBaolin Wang <baolin.wang7@gmail.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      3d4a8757
    • Lee Jones's avatar
      mfd: altera-sysmgr: Fix physical address storing hacks · d9ca7801
      Lee Jones authored
      Sparse reports:
      
       drivers/mfd/altera-sysmgr.c:150:30: warning: incorrect type in assignment (different address spaces)
       drivers/mfd/altera-sysmgr.c:150:30:    expected unsigned int [usertype] *base
       drivers/mfd/altera-sysmgr.c:150:30:    got void [noderef] <asn:2> *
       drivers/mfd/altera-sysmgr.c:156:26: warning: incorrect type in argument 3 (different address spaces)
       drivers/mfd/altera-sysmgr.c:156:26:    expected void [noderef] <asn:2> *regs
       drivers/mfd/altera-sysmgr.c:156:26:    got unsigned int [usertype] *base
      
      It appears as though the driver data property 'resource_size_t *base'
      was being used to store 2 different types of addresses (physical and
      IO-mapped) under a single declared type.
      
      Fortunately, no value is recalled from the driver data entry, so it
      can be easily omitted.  Instead we can use the value obtained directly
      from the platform resource to pass through  Regmap into the call-backs
      to be used for the SMCC call and use a local dedicated __iomem
      variable for IO-remapping.
      
      Cc: Thor Thayer <thor.thayer@linux.intel.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      d9ca7801
    • Lee Jones's avatar
      mfd: tps6586x: Fix cast to restricted __le32 warning · c504a248
      Lee Jones authored
      Silences Sparse warning(s):
      
       drivers/mfd/tps6586x.c:323:16: warning: cast to restricted __le32
       drivers/mfd/tps6586x.c:323:16: warning: cast to restricted __le32
       drivers/mfd/tps6586x.c:323:16: warning: cast to restricted __le32
       drivers/mfd/tps6586x.c:323:16: warning: cast to restricted __le32
       drivers/mfd/tps6586x.c:323:16: warning: cast to restricted __le32
       drivers/mfd/tps6586x.c:323:16: warning: cast to restricted __le32
      
      Cc: Mike Rapoport <mike@compulab.co.il>
      Cc: Eric Miao <eric.miao@marvell.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      c504a248
    • Lee Jones's avatar
      mfd: twl4030-irq: Fix cast to restricted __le32 warning · b174015b
      Lee Jones authored
      Silences Sparse warning(s):
      
       drivers/mfd/twl4030-irq.c:573:40: warning: cast to restricted __le32
       drivers/mfd/twl4030-irq.c:573:40: warning: cast to restricted __le32
       drivers/mfd/twl4030-irq.c:573:40: warning: cast to restricted __le32
       drivers/mfd/twl4030-irq.c:573:40: warning: cast to restricted __le32
       drivers/mfd/twl4030-irq.c:573:40: warning: cast to restricted __le32
       drivers/mfd/twl4030-irq.c:573:40: warning: cast to restricted __le32
      
      Cc: Tony Lindgren <tony@atomide.com>
      Cc: Kai Svahn <kai.svahn@nokia.com>
      Cc: Syed Khasim <x0khasim@ti.com>
      Cc: linux-omap@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      b174015b
    • Lee Jones's avatar
      mfd: twl4030-irq: Fix incorrect type in assignment warning · 6fef0d4e
      Lee Jones authored
      Silences Sparse warning:
      
       drivers/mfd/twl4030-irq.c:485:26: warning: incorrect type in assignment (different base types)
       drivers/mfd/twl4030-irq.c:485:26:    expected unsigned int [usertype] word
       drivers/mfd/twl4030-irq.c:485:26:    got restricted __le32 [usertype]
      
      Cc: Tony Lindgren <tony@atomide.com>
      Cc: Kai Svahn <kai.svahn@nokia.com>
      Cc: Syed Khasim <x0khasim@ti.com>
      Cc: linux-omap@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      6fef0d4e
  2. 01 Jul, 2020 1 commit
    • Johan Hovold's avatar
      mfd: lm3533: Expand control-bank accessors · 4d3ec936
      Johan Hovold authored
      Expand the control-bank accessors that were implemented using macros.
      This allows the definitions of these exported functions to be found more
      easily and specifically avoids a W=1 compiler warning due to the
      redundant brightness sanity check:
      
      drivers/mfd/lm3533-ctrlbank.c: In function 'lm3533_ctrlbank_set_brightness':
      drivers/mfd/lm3533-ctrlbank.c:98:10: warning: comparison is always false due to limited range of data type [-Wtype-limits]
         98 |  if (val > LM3533_##_NAME##_MAX)     \
            |          ^
      drivers/mfd/lm3533-ctrlbank.c:125:1: note: in expansion of macro 'lm3533_ctrlbank_set'
        125 | lm3533_ctrlbank_set(brightness, BRIGHTNESS);
            | ^~~~~~~~~~~~~~~~~~~
      Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      4d3ec936
  3. 30 Jun, 2020 3 commits
  4. 25 Jun, 2020 4 commits
  5. 18 Jun, 2020 12 commits
  6. 14 Jun, 2020 4 commits
    • Linus Torvalds's avatar
      Linux 5.8-rc1 · b3a9e3b9
      Linus Torvalds authored
      b3a9e3b9
    • Linus Torvalds's avatar
      Merge tag 'LSM-add-setgid-hook-5.8-author-fix' of git://github.com/micah-morton/linux · 4a87b197
      Linus Torvalds authored
      Pull SafeSetID update from Micah Morton:
       "Add additional LSM hooks for SafeSetID
      
        SafeSetID is capable of making allow/deny decisions for set*uid calls
        on a system, and we want to add similar functionality for set*gid
        calls.
      
        The work to do that is not yet complete, so probably won't make it in
        for v5.8, but we are looking to get this simple patch in for v5.8
        since we have it ready.
      
        We are planning on the rest of the work for extending the SafeSetID
        LSM being merged during the v5.9 merge window"
      
      * tag 'LSM-add-setgid-hook-5.8-author-fix' of git://github.com/micah-morton/linux:
        security: Add LSM hooks to set*gid syscalls
      4a87b197
    • Thomas Cedeno's avatar
      security: Add LSM hooks to set*gid syscalls · 39030e13
      Thomas Cedeno authored
      The SafeSetID LSM uses the security_task_fix_setuid hook to filter
      set*uid() syscalls according to its configured security policy. In
      preparation for adding analagous support in the LSM for set*gid()
      syscalls, we add the requisite hook here. Tested by putting print
      statements in the security_task_fix_setgid hook and seeing them get hit
      during kernel boot.
      Signed-off-by: default avatarThomas Cedeno <thomascedeno@google.com>
      Signed-off-by: default avatarMicah Morton <mortonm@chromium.org>
      39030e13
    • Linus Torvalds's avatar
      Merge tag 'for-5.8-part2-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux · 9d645db8
      Linus Torvalds authored
      Pull btrfs updates from David Sterba:
       "This reverts the direct io port to iomap infrastructure of btrfs
        merged in the first pull request. We found problems in invalidate page
        that don't seem to be fixable as regressions or without changing iomap
        code that would not affect other filesystems.
      
        There are four reverts in total, but three of them are followup
        cleanups needed to revert a43a67a2 cleanly. The result is the
        buffer head based implementation of direct io.
      
        Reverts are not great, but under current circumstances I don't see
        better options"
      
      * tag 'for-5.8-part2-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux:
        Revert "btrfs: switch to iomap_dio_rw() for dio"
        Revert "fs: remove dio_end_io()"
        Revert "btrfs: remove BTRFS_INODE_READDIO_NEED_LOCK"
        Revert "btrfs: split btrfs_direct_IO to read and write part"
      9d645db8
  7. 13 Jun, 2020 3 commits
    • Linus Torvalds's avatar
      Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net · 96144c58
      Linus Torvalds authored
      Pull networking fixes from David Miller:
      
       1) Fix cfg80211 deadlock, from Johannes Berg.
      
       2) RXRPC fails to send norigications, from David Howells.
      
       3) MPTCP RM_ADDR parsing has an off by one pointer error, fix from
          Geliang Tang.
      
       4) Fix crash when using MSG_PEEK with sockmap, from Anny Hu.
      
       5) The ucc_geth driver needs __netdev_watchdog_up exported, from
          Valentin Longchamp.
      
       6) Fix hashtable memory leak in dccp, from Wang Hai.
      
       7) Fix how nexthops are marked as FDB nexthops, from David Ahern.
      
       8) Fix mptcp races between shutdown and recvmsg, from Paolo Abeni.
      
       9) Fix crashes in tipc_disc_rcv(), from Tuong Lien.
      
      10) Fix link speed reporting in iavf driver, from Brett Creeley.
      
      11) When a channel is used for XSK and then reused again later for XSK,
          we forget to clear out the relevant data structures in mlx5 which
          causes all kinds of problems. Fix from Maxim Mikityanskiy.
      
      12) Fix memory leak in genetlink, from Cong Wang.
      
      13) Disallow sockmap attachments to UDP sockets, it simply won't work.
          From Lorenz Bauer.
      
      * git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net: (83 commits)
        net: ethernet: ti: ale: fix allmulti for nu type ale
        net: ethernet: ti: am65-cpsw-nuss: fix ale parameters init
        net: atm: Remove the error message according to the atomic context
        bpf: Undo internal BPF_PROBE_MEM in BPF insns dump
        libbpf: Support pre-initializing .bss global variables
        tools/bpftool: Fix skeleton codegen
        bpf: Fix memlock accounting for sock_hash
        bpf: sockmap: Don't attach programs to UDP sockets
        bpf: tcp: Recv() should return 0 when the peer socket is closed
        ibmvnic: Flush existing work items before device removal
        genetlink: clean up family attributes allocations
        net: ipa: header pad field only valid for AP->modem endpoint
        net: ipa: program upper nibbles of sequencer type
        net: ipa: fix modem LAN RX endpoint id
        net: ipa: program metadata mask differently
        ionic: add pcie_print_link_status
        rxrpc: Fix race between incoming ACK parser and retransmitter
        net/mlx5: E-Switch, Fix some error pointer dereferences
        net/mlx5: Don't fail driver on failure to create debugfs
        net/mlx5e: CT: Fix ipv6 nat header rewrite actions
        ...
      96144c58
    • David Sterba's avatar
      Revert "btrfs: switch to iomap_dio_rw() for dio" · 55e20bd1
      David Sterba authored
      This reverts commit a43a67a2.
      
      This patch reverts the main part of switching direct io implementation
      to iomap infrastructure. There's a problem in invalidate page that
      couldn't be solved as regression in this development cycle.
      
      The problem occurs when buffered and direct io are mixed, and the ranges
      overlap. Although this is not recommended, filesystems implement
      measures or fallbacks to make it somehow work. In this case, fallback to
      buffered IO would be an option for btrfs (this already happens when
      direct io is done on compressed data), but the change would be needed in
      the iomap code, bringing new semantics to other filesystems.
      
      Another problem arises when again the buffered and direct ios are mixed,
      invalidation fails, then -EIO is set on the mapping and fsync will fail,
      though there's no real error.
      
      There have been discussions how to fix that, but revert seems to be the
      least intrusive option.
      
      Link: https://lore.kernel.org/linux-btrfs/20200528192103.xm45qoxqmkw7i5yl@fiona/Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
      55e20bd1
    • Grygorii Strashko's avatar
      net: ethernet: ti: ale: fix allmulti for nu type ale · bc139119
      Grygorii Strashko authored
      On AM65xx MCU CPSW2G NUSS and 66AK2E/L NUSS allmulti setting does not allow
      unregistered mcast packets to pass.
      
      This happens, because ALE VLAN entries on these SoCs do not contain port
      masks for reg/unreg mcast packets, but instead store indexes of
      ALE_VLAN_MASK_MUXx_REG registers which intended for store port masks for
      reg/unreg mcast packets.
      This path was missed by commit 9d1f6447 ("net: ethernet: ti: ale: fix
      seeing unreg mcast packets with promisc and allmulti disabled").
      
      Hence, fix it by taking into account ALE type in cpsw_ale_set_allmulti().
      
      Fixes: 9d1f6447 ("net: ethernet: ti: ale: fix seeing unreg mcast packets with promisc and allmulti disabled")
      Signed-off-by: default avatarGrygorii Strashko <grygorii.strashko@ti.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      bc139119