- 17 May, 2022 10 commits
-
-
Thomas Zimmermann authored
Split up the connector's mode_valid helper into a simple-pipe and a mode-config helper. The simple-pipe helper tests for display-size limits while the mode-config helper tests for memory-bandwidth limits. Also add the mgag200_ prefix to mga_vga_calculate_mode_bandwidth() and comment on the function's purpose. The memory-bandwidth tests assume that the display uses 4 bytes per pixel. The first models of G200SE-A only had 1.75 MiB of VRAM, which limits these devices to 640x480-32. v2: * note the memory constraints on early G200SE-A Signed-off-by:
Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by:
Jocelyn Falempe <jfalempe@redhat.com> Tested-by:
-
Thomas Zimmermann authored
Test for a mode's memory requirements in the device-wide mode_valid helper. For simplicify, always assume a 32-bit color format. While some rejected modes would work with less colors, implementing this is probably not worth the effort. Also remove the memory-related test from the connector's mode_valid helper. The test uses the bpp value that users can specify on the kernel's command line. This value is unrelated and the test would belong into atomic_check. Signed-off-by:
-
Thomas Zimmermann authored
struct mga_connector has outlived its purpose. Inline the rsp init helper into the mode-config code and remove the data structure. No functional changes. Signed-off-by:
-
Thomas Zimmermann authored
Store the I2C state within struct mga_device and switch I2C to managed release. Simplifies the related code and lets us remove mga_connector_destroy(). Signed-off-by:
-
Thomas Zimmermann authored
Provide drm_connector_helper_get_modes_from_ddc() to implement the connector's get_modes callback. The new helper updates the connector from DDC-provided EDID data. v2: * clear property if EDID is NULL in helper Signed-off-by:
-
Thomas Zimmermann authored
Initialization of the I2C adapter was allowed to fail. The mgag200 driver would have continued without DDC support. Had this happened in practice, it would have led to segmentation faults in the connector code. Resolve this problem by failing driver initialization on I2C- related errors. v2: * initialize 'ret' before drm_err() (kernel test robot) Signed-off-by:
-
Thomas Zimmermann authored
DDC operation conflicts with concurrent mode setting. Acquire the driver's I/O lock in get_modes to prevent this. This change should have been part of commit 931e3f3a ("drm/mgag200: Protect concurrent access to I/O registers with lock"), but apparently got lost somewhere. v3: * fix commit message to say 'drm/mgag200' (Jocelyn) Signed-off-by:
-
Xin Ji authored
As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it. Fixes: fd0310b6 ("drm/bridge: anx7625: add MIPI DPI input feature") Signed-off-by:
Xin Ji <xji@analogixsemi.com> Tested-by:
Chen-Yu Tsai <wenst@chromium.org> Acked-by:
Robert Foss <robert.foss@linaro.org> Reviewed-by:
-
Xin Ji authored
Add 'bus-type' and 'data-lanes' define, bus-type 7 for MIPI DPI input, others for DSI input. Signed-off-by:
Rob Herring <robh@kernel.org> Reviewed-by:
-
Dmitry Osipenko authored
Interrupt context can't sleep. Drivers like Panfrost and MSM are taking mutex when job is released, and thus, that code can sleep. This results into "BUG: scheduling while atomic" if locks are contented while job is freed. There is no good reason for releasing scheduler's jobs in IRQ context, hence use normal context to fix the trouble. Cc: stable@vger.kernel.org Fixes: 542cff78 ("drm/sched: Avoid lockdep spalt on killing a processes") Signed-off-by:
Dmitry Osipenko <dmitry.osipenko@collabora.com> Signed-off-by:
Andrey Grodzovsky <andrey.grodzovsky@amd.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220411221536.283312-1-dmitry.osipenko@collabora.com
-
- 16 May, 2022 6 commits
-
-
Geert Uytterhoeven authored
The Freescale i.MX8MP LDB bridge is only present on Freescale i.MX8MP SoCs. Hence add a dependency on ARCH_MXC, to prevent asking the user about this driver when configuring a kernel without i.MX SoC support. Fixes: 463db5c2 ("drm: bridge: ldb: Implement simple Freescale i.MX8MP LDB bridge") Signed-off-by:
Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by:
Marek Vasut <marex@denx.de> Signed-off-by:
-
Marek Vasut authored
Drop two unused register macros, ICN6211_MAX_REGISTER and MIPI_ATE_STATUS_1, neither of which is used and where the later should be specified using macro MIPI_ATE_STATUS(1) instead. Drop the _(n) underscore and keep only the (n) part of register macros. No functional change. Signed-off-by:
-
Jocelyn Falempe authored
Add support for atomic update of gamma lut. With this patch the "Night light" feature of gnome3 is working properly on mgag200. v2: - Add a default linear gamma function - renamed functions with mgag200 prefix - use format's 4cc code instead of bit depth - use better interpolation for 16bits gamma - remove legacy function mga_crtc_load_lut() - can't remove the call to drm_mode_crtc_set_gamma_size() because it doesn't work with userspace. - other small refactors v3: - change mgag200_crtc_set_gamma*() argument to struct drm_format_info *format - fix printk format to %p4cc for 4cc and %zu for size_t - rebased to drm-misc-next. Signed-off-by: -
Thomas Zimmermann authored
Don't add a mode for the kernel's command-line parameters from within the DRM client code. Doing so can result in an unusable display. If there's no compatible command-line mode, the client will use one of the connector's preferred modes. All mode creation and validation has to be performed by the connector. When clients run, the connector's fill_modes callback has already processed the kernel parameters and validated each mode before adding it. The connector's mode list does not contain invalid modes. v2: * grammar in commit message (Javier) Signed-off-by:
Javier Martinez Canillas <javierm@redhat.com> Reviewed-by:
Maxime Ripard <maxime@cerno.tech> Link: https://patchwork.freedesktop.org/patch/msgid/20220511183125.14294-4-tzimmermann@suse.de
-
Thomas Zimmermann authored
When picking a mode, first look for modes that have been specified by the user on the kernel's command line. Only if that fails, use the existing heuristic of picking a nearby mode from it's various parameters. Signed-off-by:
-
Thomas Zimmermann authored
Print a warning if a user-specifed display mode is not supported by the display pipeline. Users specified the display mode on the kernel command line with the use of the video= parameter. Setting an unsupported mode will leave the console blank, so we should at least let the user know why. Signed-off-by:
-
- 15 May, 2022 3 commits
-
-
Dan Carpenter authored
This error path needs an unlock before returning. Fixes: 604be855 ("drm/rockchip: Add VOP2 driver") Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Acked-by:
Sascha Hauer <s.hauer@pengutronix.de> Signed-off-by:
Heiko Stuebner <heiko@sntech.de> Link: https://patchwork.freedesktop.org/patch/msgid/YnjZQRV9lpub2ET8@kili
-
Peter Geis authored
Some implementations do not use the reset signal, instead tying it to dvdd. Make the reset gpio optional to permit this. Signed-off-by:
Peter Geis <pgwipeout@gmail.com> Signed-off-by:
-
Peter Geis authored
Some implementations do not use the reset signal, instead tying it to dvdd. Make the reset gpio optional to permit this. Signed-off-by:
-
- 13 May, 2022 21 commits
-
-
Jani Nikula authored
We'll need to propagate drm_edid everywhere. Also make version_greater() a function for type safety. Signed-off-by:
Jani Nikula <jani.nikula@intel.com> Reviewed-by:
Ankit Nautiyal <ankit.k.nautiyal@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/f1835a86294b392d075570001ed9009a48352670.1652097712.git.jani.nikula@intel.com
-
Jani Nikula authored
We'll need to propagate drm_edid everywhere. v2: Rebase Signed-off-by:
-
Jani Nikula authored
We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by:
-
Jani Nikula authored
We'll need to propagate drm_edid everywhere. v2: Rebase Signed-off-by:
-
Jani Nikula authored
We'll need to propagate drm_edid everywhere. v2: Handle NULL drm_edid Signed-off-by:
-
Jani Nikula authored
We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by:
-
Jani Nikula authored
We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by:
-
Jani Nikula authored
We'll need to propagate drm_edid everywhere.' v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by:
-
Jani Nikula authored
We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by:
-
Jani Nikula authored
We'll need to propagate drm_edid everywhere. v2: Fix checkpatch warning on superfluous parens Signed-off-by:
-
Jani Nikula authored
We'll need to propagate drm_edid everywhere. v2: Drop incorrect NULL name check (Dan Carpenter) Signed-off-by:
-
Jani Nikula authored
We'll need to propagate drm_edid everywhere. Signed-off-by:
-
Jani Nikula authored
We'll need to propagate drm_edid everywhere. Signed-off-by:
-
Jani Nikula authored
We'll need to propagate drm_edid everywhere. Signed-off-by:
-
Jani Nikula authored
We'll need to propagate drm_edid everywhere. Signed-off-by:
-
Jani Nikula authored
We'll need to propagate drm_edid everywhere. Signed-off-by:
-
Jani Nikula authored
We'll need to propagate drm_edid everywhere. Signed-off-by:
-
Jani Nikula authored
We'll need to propagate drm_edid everywhere. Signed-off-by:
-
Jani Nikula authored
We'll need to propagate drm_edid everywhere. v3: s/edid/drm_edid/ in comment too (Ankit) Signed-off-by:
-
Jani Nikula authored
We'll need to propagate drm_edid everywhere. v3: Rebase Signed-off-by:
-
Jani Nikula authored
We'll need to propagate drm_edid everywhere. v3: Update comment to refer to update_display_info() (Ankit) v2: Use drm_edid_legacy_init() Signed-off-by:
-
