- 21 Aug, 2016 40 commits
-
-
Luis de Bethencourt authored
The value assigned to ret will be overwritten before it could be read in a future iteration of the loop. Removing the unnecessary assignment. Signed-off-by:
Luis de Bethencourt <luisbg@osg.samsung.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Philippe Reynes authored
There are two generics functions phy_ethtool_{get|set}_link_ksettings, so we can use them instead of defining the same code in the driver. There was a check on CAP_NET_ADMIN in cvm_oct_set_settings, but this check is already done in dev_ethtool, so no need to repeat it before calling the generic function. Signed-off-by:Philippe Reynes <tremyfr@gmail.com> Signed-off-by:
-
Philippe Reynes authored
The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phydev in the private structure, and update the driver to use the one contained in struct net_device. Signed-off-by:
-
Aaro Koskinen authored
There will be a separate banner message after pow0 is set up (or an error message if it failed). Signed-off-by:
Aaro Koskinen <aaro.koskinen@nokia.com> Signed-off-by:
-
Aaro Koskinen authored
Check for pow0 port first before calling the interface helper. This avoids the following error log when setting up pow0 interface: cvmx_helper_get_interface_num: Illegal IPD port number Signed-off-by:
-
Aaro Koskinen authored
Some helper functions call INDEX before checking if the interface is valid. Since pow0 is not a real interface, we get the following errors: cvmx_helper_get_interface_index_num: Illegal IPD port number Fix by using INDEX only when needed with real interfaces. Signed-off-by:
-
Lino Sanfilippo authored
Merge several structures for statistics to one structure and remove unnecessary union nesting. Signed-off-by:
Lino Sanfilippo <LinoSanfilippo@gmx.de> Signed-off-by:
-
Lino Sanfilippo authored
Remove the volatile specifiers of struct slic_shmem. Furthermore store the bus addresses for the isr pointer, link status and statistics separately and access the upper and lower word of these addresses by means of [lower|upper]_32_bits(). By doing this take the endianness into account. Signed-off-by:
-
Lino Sanfilippo authored
Use the new register accessors that use offsets instead of the slic_regs structure to read/write registers. Since not longer needed remove the structure completley. Signed-off-by:
-
Lino Sanfilippo authored
Introduce the function slic_flush_write() which reads from the HOSTID register and can be used to avoid PCI write posting. Use the function at several critical places in the code. Signed-off-by:
-
Lino Sanfilippo authored
Introduce accessor functions that read and write registers by using a register offset. This is in preparation to replace the register addressing by means of the slic_regs struct with an addressing by means of offsets. Signed-off-by:
-
Lino Sanfilippo authored
There is no reason to delay tx queue activation until a link is detected. So start the queue when the interface is brought up and stop it when the interface is brought down. Signed-off-by:
-
Lino Sanfilippo authored
Writes to registers should be done uncached for various reasons. Ensure this by replacing ioremap() with ioremap_nocache(). Signed-off-by:
-
Lino Sanfilippo authored
Notify the network stack about link states via netif_carrier_[off|on](). Also set the link state off initially and when the interface is brought down. Signed-off-by:
-
Lino Sanfilippo authored
The memory allocation in slic_init_adapter() can fail. Return an error in this case and unwind properly. Also make sure that the allocated memory is properly freed in case of an error in the calling probe() function. By doing this also replace the alloc() followed by memset to zero the memory with a zalloc() version. Signed-off-by:
-
Anson Jacob authored
fix checkpatch.pl warning about 'line over 80 characters'. Signed-off-by:
Anson Jacob <ansonjacob.aj@gmail.com> Signed-off-by:
-
Prit Raj authored
WARNING: Statements should start on a tabstop Signed-off-by:
Prit Raj <prit.adra@gmail.com> Signed-off-by:
-
Ming Yang authored
Replace unsigned by unsigned int in fbtft driver. Issue found by checkpatch. Signed-off-by:
Ming Yang <minos.future@gmail.com> Signed-off-by:
-
Michal Suchanek authored
txbuflen can be set to arbitrary value by user and it is also set automagically to the maximum transfer size of the SPI master controller. Do not allocate the buffer when larger than vmem. When my SPI master controller reports maximum transfer size 16M the probe of fbtft fails. Signed-off-by:
Michal Suchanek <hramrach@gmail.com> Acked-by:
Noralf Trønnes <noralf@tronnes.org> Signed-off-by:
-
Chen Feng authored
It's useful to show the current memory in detail when alloc failed. And, there may be a lot of high order alloc failed, just show memory when an order 0 alloc failed. Signed-off-by:
Chen Feng <puck.chen@hisilicon.com> Acked-by:
Laura Abbott <labbott@redhat.com> Signed-off-by:
-
Chen Feng authored
Add ion cached pool in system heap. This patch add a cached pool in system heap. It has a great improvement of alloc for cached buffer. With memory pressue alloc test 800MB in userspace used iontest. The result avg is 577ms. Without patch it's avg is about 883ms. v1: Makes the cached buffer zeroed before going to pool v2: Add cached param in pool to distinguish wheather need to flush cache at a fresh alloc. Rework the shrink function. Signed-off-by:Xia Qing <saberlily.xia@hisilicon.com> Reviewed-by:
Fu Jun <oliver.fu@hisilicon.com> Acked-by:
-
Kevin McKinney authored
This patch fixes comparison to NULL could be written "wlandev" found by checkpatch.pl tool. Signed-off-by:
Kevin McKinney <klmckinney1@gmail.com> Signed-off-by:
-
Kevin McKinney authored
This patch fixes Unnecessary parentheses around interface->dev found by checkpatch.pl tool. Signed-off-by:
-
Kevin McKinney authored
This patch fixes alignment should match open parenthesis found by checkpatch.pl tool in prism2usb.c. Signed-off-by:
-
YU Bo authored
Fix checkpatch.pl warning: WARNING: Block comments use a trailing */ on a separate line. Signed-off-by:
Bo Yu <tsu.yubo@gmail.com> Signed-off-by:
-
Luis de Bethencourt authored
We can just ignore the return value from debugfs_create_dir() and debugfs_create_file(). The second one already interanlly checks the dentry created by the first before creating the file. debugfs was written so it would be easy to use, no need for error checking. Signed-off-by:
-
Joshua Houghton authored
* Update the comments that refer to semaphores * Remove redundant includes to semphore.h Signed-off-by:
Joshua Houghton <josh@awful.name> Signed-off-by:
-
Anthony Sheldon authored
As suggested by Documentation/CodingStyle move braces onto same line as else. Signed-off-by:
Anthony Sheldon <sheldon.anthony.sheldon@gmail.com> Signed-off-by:
-
Sudip Mukherjee authored
Braces are not required in a single statement block. Signed-off-by:
Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> Signed-off-by:
-
Sudip Mukherjee authored
It is not the kernel coding style to make assignments in the if statement and checkpatch was warning us about it. Signed-off-by:
-
Sudip Mukherjee authored
return is not a function so no need to use the parenthesis. Signed-off-by:
-
Muhammad Falak R Wani authored
Use setup_timer() instead of init_timer(), being the preferred/standard way to set a timer up. Also, quoting the mod_timer() function comment: -> mod_timer() is a more efficient way to update the expire field of an active timer (if the timer is inactive it will be activated). Use setup_timer and mod_timer to setup and arm a timer, to make the code cleaner and easier to read. Signed-off-by:
Muhammad Falak R Wani <falakreyaz@gmail.com> Signed-off-by:
-
Muhammad Falak R Wani authored
Use setup_timer() instead of init_timer(), being the preferred/standard way to set a timer up. Also, quoting the mod_timer() function comment: -> mod_timer() is a more efficient way to update the expire field of an active timer (if the timer is inactive it will be activated). Use setup_timer and mod_timer to setup and arm a timer, to make the code cleaner and easier to read. Signed-off-by:
-
Muhammad Falak R Wani authored
Use setup_timer() instead of init_timer(), being the preferred/standard way to set a timer up. Also, quoting the mod_timer() function comment: -> mod_timer() is a more efficient way to update the expire field of an active timer (if the timer is inactive it will be activated). Use setup_timer and mod_timer to setup and arm a timer, to make the code cleaner and easier to read. Signed-off-by:
-
Muhammad Falak R Wani authored
Use setup_timer() instead of init_timer(), being the preferred/standard way to set a timer up. Also, quoting the mod_timer() function comment: -> mod_timer() is a more efficient way to update the expire field of an active timer (if the timer is inactive it will be activated). Use setup_timer and mod_timer to setup and arm a timer, to make the code cleaner and easier to read. Signed-off-by:
-
Ravishankar Karkala Mallikarjunayya authored
This fixes up a line over 80 characters issues found by the checkpatch.pl tool. Signed-off-by:
Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Cheah Kok Cheong authored
Use macro introduced in commit 939f325f ("usb: add usb_endpoint_maxp() macro") Signed-off-by:
Cheah Kok Cheong <thrust73@gmail.com> Reviewed-by:
-
Nayeemahmed Badebade authored
Fixed below sparse warnings in dt2811.c warning: symbol 'dt2811_clk_dividers' was not declared. Should it be static? warning: symbol 'dt2811_clk_multipliers' was not declared. Should it be static? Signed-off-by:
Nayeemahmed Badebade <itachi.opsrc@gmail.com> Reviewed-by:
-
H Hartley Sweeten authored
Fix the checkpatch.pl issues: WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on a separate line Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by:
-
H Hartley Sweeten authored
Fix the checkpatch.pl issues: WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on a separate line Signed-off-by:
-
