- 18 Feb, 2008 40 commits
-
-
Tobias Lorenz authored
This patch combines all the finished discussions and its resulting patches from the mailing list. The version 1.0.6 is mainly influenced by Oliver Neukum. He found a lot of small issues, that are fixed with this patch now. For me the most interesting thing is, that it's now safer to use it on other architectures. The history for version 1.0.6 is: - fixed coverity checker warnings in *_usb_driver_disconnect - probe()/open() race by correct ordering in probe() - DMA coherency rules by separate allocation of all buffers - use of endianness macros - abuse of spinlock, replaced by mutex - racy handling of timer in disconnect, replaced by delayed_work - racy interruptible_sleep_on(), replaced with wait_event_interruptible() - handle signals in read() The driver is tested with all Debian/testing radio programs and rdsd. The patch is tested against checkpatch.pl v1.12. Signed-off-by:
Tobias Lorenz <tobias.lorenz@gmx.net> Signed-off-by:
Mauro Carvalho Chehab <mchehab@infradead.org>
-
Hartmut Hackmann authored
Some cards need the diseqc signal modulated, while some just need the envelope to control the LNB supply. This fixes Bug 9887 Signed-off-by:
Hartmut Hackmann <hartmut.hackmann@t-online.de> Acked-by:
Oliver Endriss <o.endriss@gmx.de> Signed-off-by:
-
Michael Krufky authored
fix the following build warning: radio-si470x.c: In function 'si470x_get_rds_registers': radio-si470x.c:562: warning: format '%ld' expects type 'long int', but argument 3 has type 'unsigned int' Signed-off-by:
Michael Krufky <mkrufky@linuxtv.org> Signed-off-by:
-
Mauro Carvalho Chehab authored
Thanks to Alan Stern <stern@rowland.harvard.edu> for pointing this issue. Signed-off-by: -
Mauro Carvalho Chehab authored
em28xx driver is capable of handling more than one usb device. However, isoc transfers require a large amount of data to be transfered. Before this patch, just one em28xx board were enough to allocate more than 50% URBs: T: Bus=02 Lev=00 Prnt=00 Port=00 Cnt=00 Dev#= 1 Spd=480 MxCh= 8 B: Alloc=480/800 us (60%), #Int= 0, #Iso= 2 D: Ver= 2.00 Cls=09(hub ) Sub=00 Prot=01 MxPS=64 #Cfgs= 1 So, only one board could use an USB host at the same time. After the patch, it is possible to use more than one em28xx at the same time, on the same usb host, if the image size is slower or equal to 345600, since those images will require about 30% of the URBs: T: Bus=02 Lev=00 Prnt=00 Port=00 Cnt=00 Dev#= 1 Spd=480 MxCh= 8 B: Alloc=232/800 us (29%), #Int= 0, #Iso= 2 D: Ver= 2.00 Cls=09(hub ) Sub=00 Prot=01 MxPS=64 #Cfgs= 1 So, in thesis, after the patch, it would be possible to use up to 3 boards by each usb host, if the devices are generating small images. Signed-off-by: -
Mauro Carvalho Chehab authored
Signed-off-by: -
Mauro Carvalho Chehab authored
Improves audio configurations on em28xx: - mutes audio before changing amux; - adds a delay after setting audio src; - waits up to 50ms for ac97 busy. Signed-off-by: -
Mauro Carvalho Chehab authored
Signed-off-by: -
Mauro Carvalho Chehab authored
Signed-off-by: -
Mauro Carvalho Chehab authored
Adds vidioc_[g|s]_register handlers. This allows getting/setting register from em28xx. Signed-off-by: -
Mauro Carvalho Chehab authored
AC97 register initialization seem to always be needed. This patch fixes audio for Prolink/Pixelview USB2 board. Signed-off-by: -
Andrew Morton authored
drivers/media/video/em28xx/em28xx-core.c: In function 'em28xx_set_audio_source': drivers/media/video/em28xx/em28xx-core.c:276: warning: 'no_ac97' may be used uninitialized in this function This looks like a genuine bug to me. Signed-off-by:
Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
-
Brandon Philips authored
Signed-off-by:
Brandon Philips <bphilips@suse.de> Signed-off-by:
-
Roel Kluin authored
'!' has a higher priority than '&': bitanding has no effect. Signed-off-by:
Roel Kluin <12o3l@tiscali.nl> Signed-off-by:
-
Luc Saillard authored
Device description: WinTV-HVR-900 M/R: 65018/B3C0 ##4207 Signed-off-by:
Luc Saillard <luc@saillard.org> Signed-off-by:
-
Mauro Carvalho Chehab authored
videobuf functions at close() method already locks videobuf. It makes no sense to keep the locking at empress close() method. There is also a lock at open() method. I'm not sure if it is safe to remove the locking there. Signed-off-by: -
Mauro Carvalho Chehab authored
This helps to identify where vb_lock is being used, and find missusages of the locks. Signed-off-by: -
Mauro Carvalho Chehab authored
Removes the duplicated mutex_init code. Signed-off-by: -
Oliver Endriss authored
Improved display of still pictures (VIDEO_STILLPICTURE ioctl). Ensure that both fields are displayed for progressive frames. Thanks to Reinhard Nissl and Klaus Schmidinger for finding out that the FREEZE command does this. Thanks-to: Reinhard Nissl <rnissl@gmx.de> Thanks-to: Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de> Signed-off-by:
-
Kim Sandberg authored
Add support for Satelco EasyWatch PCI DVB-T, sub-id 0x1894:0x003a. Signed-off-by:
Kim Sandberg <ksan@saunalahti.fi> Signed-off-by:
-
Oliver Endriss authored
Add support for KNC TV Station Plus X4, sub-system id 0x1894:0x0015. Based on a patch submitted by Johannes Deisenhofer. Thanks-to: Johannes Deisenhofer <jo.deisenhofer@googlemail.com> Signed-off-by:
-
Tobias Lorenz authored
Thanks to Darren Salt <linux@youmustbejoking.demon.co.uk> for pointing this issue. Signed-off-by:
-
Tobias Lorenz authored
Adrian used the coverity checker against radio-si470x and found this: > The Coverity checker spotted the following check-after-use in > drivers/media/radio/radio-si470x.c: > > <-- snip --> > static void si470x_usb_driver_disconnect(struct usb_interface *intf) > { > struct si470x_device *radio = usb_get_intfdata(intf); > > del_timer_sync(&radio->timer); <------------------ > flush_scheduled_work(); > > usb_set_intfdata(intf, NULL); > if (radio) { <------------------ > video_unregister_device(radio->videodev); > kfree(radio->buffer); > kfree(radio); > } > } > <-- snip --> > > Either "radio" can be NULL and this case has to be properly handled or > the NULL check is not required. These two lines should indeed better be inside the if statement. Signed-off-by: -
Adrian Bunk authored
This patch makes the following needlessly global functions static: - em28xx-core.c:em28xx_write_reg_bits() - em28xx-video.c:em28xx_vdev_init() Signed-off-by:
Adrian Bunk <bunk@kernel.org> Signed-off-by:
-
Adrian Bunk authored
This patch makes the following needlessly global functions static: - stk_sensor_outb() - stk_sensor_inb() Signed-off-by:
Jaime Velasco Juan <jsagarribay@gmail.com> Signed-off-by:
-
Adrian Bunk authored
stk_camera_cleanup() can become static. Signed-off-by:
-
Adrian Bunk authored
tuner_list can become static - and it's anyway a way too generic name for a global variable - see commit b00ef4b8 for a completely different global variable of the same name I just made static... Signed-off-by:
-
Adrian Bunk authored
This patch fixes an off-by-one error spotted by the Coverity checker. Signed-off-by:
-
Matthias Schwarzott authored
saa7134-dvb: add missing dvb_attach around tda10046_attach This patch adds a possibly missing dvb_attach for tda10046_attach. This removes the hard dependency of saa7134-dvb on tda1004x module. Signed-off-by:
Matthias Schwarzott <zzam@gentoo.org> Signed-off-by:
-
Mauro Carvalho Chehab authored
isapnp_fmi_probe attaches device. However, if request_region() fails, the device isn't disattached. Reviewed-by:
Douglas Schilling Landgraf <dougsland@gmail.com> Signed-off-by:
-
Douglas Schilling Landgraf authored
This patch changed the request_region() validation to avoid invalid return. Thanks to Roland Kletzing <devzero@web.de> for bug report and data collection. Signed-off-by:
-
Tobias Lorenz authored
I updated the radio-si470x driver another time. Here are the commented history entries: - number of seek_retries changed to tune_timeout The last versions checked for the end of frequency tuning by polling a si470x register. Therefore polling depended on the usb utilization. This was changed to have a constant timeout now. - fixed problem with incomplete tune operations by own buffers The last version used a shared buffer to assembly the USB HID reports. It sometimes happened, that multiple functions were modifing this buffer simultanuously. When sending such reports, the hardware returned USB stalls (-EPIPE). Now buffers of the correct size (smaller than before) are allocated as local variables. - optimization of variables The size of some variables has been reduced to allow the compiler to generate more optimized code. - improved error logging At some important location, error checking was improved. Especially the usb transfers to access si470x registers and the tuning functions were modified. Signed-off-by:
-
Jaime Velasco Juan authored
Signed-off-by:
-
Jaime Velasco Juan authored
Signed-off-by:
-
Jaime Velasco Juan authored
Signed-off-by:
-
Cyrill Gorcunov authored
This patch does fix potential NULL pointer dereference due to logical typo error. The issue is pointed out by Guennadi Liakhovetski <g.liakhovetski@pengutronix.de> Signed-off-by:
Cyrill Gorcunov <gorcunov@gmail.com> CC: Sakari Ailus <sakari.ailus@nokia.com> Signed-off-by:
-
Hermann Pitton authored
Thanks to Angelo Lisco for his initial patch we missed and to Ahmet Dogan Ugurel confirming such a device functional. Signed-off-by:
Hermann Pitton <hermann-pitton@arcor.de> Signed-off-by:
-
Hermann Pitton authored
This adds support for analog inputs and DVB-T. Good sensitivity for DVB-T currently needs to use analog TV first. DVB-S support is not yet completed, but is on the way. Signed-off-by:
-
Hermann Pitton authored
It also enumerates now the separate composite input at first and adds mute ability to radio and external audio-in. Many thanks to Daftcho Tabakov for reporting the flaws and testing. Signed-off-by:
-
Hermann Pitton authored
S-Video is unconfirmed, but likely correct. The remote is not yet investigated. Thanks go to Sioux for providing code and asking to fix the auto detection. Signed-off-by:
sioux <sioux_it@libero.it> Signed-off-by:
-
