- 25 Jan, 2015 40 commits
-
-
Heba Aamer authored
This patch fixes the following checkpatch.pl error: fix space prohibited before that ',' Signed-off-by:
Heba Aamer <heba93aamer@gmail.com> Reviewed-by:
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Dan Carpenter authored
There are two functions call reset() so the allyesconfig breaks. Let's make this one static. Reported-by:
Jim Davis <jim.epost@gmail.com> Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Tested-by:
-
Jon Bernard authored
This patch fixes the following sparse warnings: drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c:51:3:warning: symbol 'll_rpc_opcode_table' was not declared. Should it be static? drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c:142:3: warning: symbol 'll_eopcode_table' was not declared. Should it be static? drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c:178:12: warning: symbol 'll_eopcode2str' was not declared. Should it be static? drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c:731:1: warning: symbol 'ptlrpc_lprocfs_svc_req_history_seek' was not declared. Should it be static? Signed-off-by:
Jon Bernard <jbernard@tuxion.com> Signed-off-by:
-
Dan Carpenter authored
CFS_HOP() is a terrible macro. It chops the struct member name in half so that it's not possible to use tools like grep or to search for how a function pointer is used. I removed a couple calls to: LASSERT(CFS_HOP(hs, put_locked) != NULL); because they isn't a need for them. Anyway dereferencing a NULL pointer generates a pretty good stack trace already without adding extra debug code. Signed-off-by:
-
Loic Pefferkorn authored
Applies against next-20150120. Add __acquires() and __releases() function annotations, to fix sparse warnings related to lock context imbalance. This patch fixes the following warnings: drivers/staging/lustre//lustre/libcfs/linux/linux-tracefile.c:153:5: warning: context imbalance in 'cfs_trace_lock_tcd' - wrong count at exit drivers/staging/lustre//lustre/libcfs/linux/linux-tracefile.c:171:39: warning: context imbalance in 'cfs_trace_unlock_tcd' - unexpected unlock drivers/staging/lustre//lustre/libcfs/hash.c:128:1: warning: context imbalance in 'cfs_hash_spin_lock' - wrong count at exit drivers/staging/lustre//lustre/libcfs/hash.c:134:1: warning: context imbalance in 'cfs_hash_spin_unlock' - unexpected unlock drivers/staging/lustre//lustre/libcfs/hash.c:142:9: warning: context imbalance in 'cfs_hash_rw_lock' - wrong count at exit include/linux/rwlock_api_smp.h:219:9: warning: context imbalance in 'cfs_hash_rw_unlock' - unexpected unlock drivers/staging/lustre//lustre/obdclass/cl_object.c:195:6: warning: context imbalance in 'cl_object_attr_lock' - wrong count at exit drivers/staging/lustre//lustre/obdclass/cl_object.c:204:6: warning: context imbalance in 'cl_object_attr_unlock' - unexpected unlock Signed-off-by:
Loic Pefferkorn <loic@loicp.eu> Signed-off-by:
-
Luca Ceresoli authored
Fixes sparse warnings like: warning: symbol '...' was not declared. Should it be static? Signed-off-by:
Luca Ceresoli <luca@lucaceresoli.net> Cc: Peng Tao <bergwolf@gmail.com> Cc: Jinshan Xiong <jinshan.xiong@intel.com> Cc: Srikrishan Malik <srikrishanmalik@gmail.com> Cc: HPDD-discuss@lists.01.org Cc: devel@driverdev.osuosl.org Cc: linux-kernel@vger.kernel.org Signed-off-by:
-
Luca Ceresoli authored
Fixes sparse warnings like: warning: symbol '...' was not declared. Should it be static? Signed-off-by:
-
Luca Ceresoli authored
Fixes sparse warnings like: warning: symbol '...' was not declared. Should it be static? Signed-off-by:
-
Luca Ceresoli authored
Fixes sparse warnings like: warning: symbol '...' was not declared. Should it be static? Signed-off-by:
-
Luca Ceresoli authored
Fixes sparse warnings like: warning: symbol '...' was not declared. Should it be static? Signed-off-by:
-
Luca Ceresoli authored
Fixes sparse warnings like: warning: symbol '...' was not declared. Should it be static? Signed-off-by:
-
Jeremiah Mahler authored
Recent changes to use the builtin min functions [1] introduced type checking which wasn't present before. This resulted in "comparision of distinct pointer types lacks a cast" build warnings on non X86 architectures [2,3]. [1]: https://lkml.org/lkml/2014/12/25/145 [2]: https://lists.01.org/pipermail/kbuild-all/2015-January/008588.html [3]: https://lists.01.org/pipermail/kbuild-all/2015-January/008589.html The call to min() which resulted in this warning took the result of kiblnd_rd_frag_size(), which returned a __u32, and the variable 'resid', which is an int. 'resid' is inside a while loop which is only entered if it is positive. Casting it as a __u32 can be perormed without a loss of data or change in functionality. Fix the warning by casting 'resid' as a __u32. Reported-by:
kbuild test robot <fengguang.wu@intel.com> Signed-off-by:
Jeremiah Mahler <jmmahler@gmail.com> Signed-off-by:
-
Tristan Lelong authored
This patch simplifies the fld_proc_hash_seq_write function by removing the dynamic memory allocation. The longest fh_name used so far in lustre is 4 characters. We use a 8 bytes variable to be on the safe side. Signed-off-by:
Tristan Lelong <tristan@lelong.xyz> Signed-off-by:
-
jitendra kumar khasdev authored
This is patch to file jr3_pci.h that fix up warning line over 80 character which is found by checkpatch tool. Signed-off-by:
Jitendra Kumar Khasdev <jkhasdev@gmail.com> Signed-off-by:
-
H Hartley Sweeten authored
Tidy up this (*insn_config) function to follow the normal format in comedi drivers. INSN_CONFIG_RESET instructions do not have any extra parameters (insn->n is always 1) so the for loop used to write the packet doesn't make any sense. Remove it and just write the single packet. Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
H Hartley Sweeten authored
The data[0] parameter to (*insn_config) functions is the "configuration instruction" that should be handled. These are defined by the enum configuration_ids in comedi.h. This driver is currently checking the data[0] value to be INSN_CONFIG_RESET or GPCT_RESET in order to reset a counter channel. GPCT_RESET is defined as 0x0001 which would match the configuration instruction INSN_CONFIG_DIO_OUTPUT. That doesn't make any sense for a counter. Remove GPCT_RESET from the insn_cmd test. Signed-off-by:
-
H Hartley Sweeten authored
For aesthetics, use the helper functions to check the min/max divisor values. Remove the const int local variables and open code the values. Signed-off-by:
-
H Hartley Sweeten authored
Use the DIV_ROUND_CLOSEST macro to clarify the (((x) + ((divisor) / 2)) / (divisor)) calculations. Signed-off-by:
-
H Hartley Sweeten authored
Use the DIV_ROUND_UP macro to clarify the (((n) + (d) - 1) / (d)) calculations. Signed-off-by:
-
H Hartley Sweeten authored
The labpc_free_dma_chan() function validates the private data. Remove the unnecessary validation in labpc_datach(). Signed-off-by:
-
H Hartley Sweeten authored
This driver includes a number of unnecessary headers. Remove them. Signed-off-by:
-
H Hartley Sweeten authored
The ni_labpc_common module is used by the ni_labpc, ni_labpc_pci, and ni_labpc_cs drivers to provide the common code support. Those drivers currently all call comedi_alloc_devpriv() to allocate the private data before calling the common attach function. For aesthetics, move the private data allocation into the common code. Signed-off-by:
-
H Hartley Sweeten authored
This function is only called by pci1710_handle_fifo(). Absorb it and clean up pci1710_handle_fifo(). Signed-off-by:
-
H Hartley Sweeten authored
The two step process to transfer the ai samples in pci1710_handle_fifo() doesn't make any sense. If the async buffer does not have enough room for the samples the core will set the async event COMEDI_CB_OVERFLOW which will cause the async command to cancel. Splitting the transfer doesn't add any value. Transfer all the samples in one step to simplify the code. Signed-off-by:
-
H Hartley Sweeten authored
This parameter is not used in the function. It was only used in some debug messages that were previously removed. Remove the parameter. Signed-off-by:
-
H Hartley Sweeten authored
The pci1710_handle_every_sample() and pci1710_handle_fifo() helpers, called by the interrupt handler, both have multiple comedi_handle_events() calls. Remove these and just do a single comedi_handle_events() at the end of the interrupt handler. Signed-off-by:
-
H Hartley Sweeten authored
Introduce a helper function to read an analog input sample, check for channel dropout, and mask the sample to the maxdata of the subdevice. Signed-off-by:
-
H Hartley Sweeten authored
Rename this function so it has namespace associated with the driver. Tidy up the code to clarify the function. Remove the unnecessary static const array muxonechan[]. Signed-off-by:
-
H Hartley Sweeten authored
This driver saves the channel list of a scan in the private data and uses that list to check analog input samples for data dropout. Currently the channel numbers are shifted 12 bits so that they match the channel number in the samples that are read from the board. All of the shifts make the driver a bit harder to follow. Store the channel numbers directly to the 'act_chanlist' and shift the sample value instead when checking for the dropout. Add a comment for clarity. Signed-off-by:
-
H Hartley Sweeten authored
The 'cardtype' in the boardinfo is only used to: 1) determine if the board is a pci1720 during the attach of the driver and when reseting the board 2) determine is the board is not a pci1713 when checking for analog input data dropout There is also an unnecessary use of the 'cardtype' when canceling an analog input async command. Remove the 'cardtype' member and add two bit-field flags, 'is_pci1713' and 'is_pci1720'. Refactor the driver to use the new flags. Remove the unnecessary cardtype handling in pci171x_ai_cancel(). Signed-off-by: -
H Hartley Sweeten authored
This boardinfo is not necessary. All the boards with analog outputs have the same range options except for the pci1720 board. That board type is already handled specially during the driver attach. Remove the boardinfo and add the subdevice range_table initialization in the cardtype switch. Rename the range tables to clarify that they are "analog output" ranges. Signed-off-by:
-
H Hartley Sweeten authored
Change the MODULE_DESCRIPTION to something more useful than the generic "Comedi low-level driver". Signed-off-by:
-
H Hartley Sweeten authored
Remove the remaining, unnecessary, function separation comments. Signed-off-by:
-
H Hartley Sweeten authored
For aesthetics, rename all the 'this_board' local variables to simply 'board'. That's more common in comed drivers. Signed-off-by:
-
H Hartley Sweeten authored
For aesthetics, add some whitespace to the analog input subdevice init and rename the (*insn_read) support function. Also remove the unnecessary comments. Signed-off-by:
-
H Hartley Sweeten authored
For aesthetics, add some whitespace to the analog output subdevice init. Signed-off-by:
-
H Hartley Sweeten authored
For aesthetics, add some whitespace to the digital input and output subdevice init and rename the support functions. Also remove the unnecessary comment. Signed-off-by:
-
H Hartley Sweeten authored
For aesthetics, add some whitespace to the counter subdevice init and rename the support functions. Also remove the unnecessary comments. Signed-off-by:
-
H Hartley Sweeten authored
For aesthetics, rename this function and tidy it up. Signed-off-by:
-
H Hartley Sweeten authored
For aesthetics, rename this function and tidy it up. Signed-off-by:
-
