- 01 May, 2019 8 commits
-
-
Vatsala Narang authored
Return value directly without saving it in a variable and remove that variable. Issue suggested by Coccinelle. Signed-off-by:
Vatsala Narang <vatsalanarang@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Vatsala Narang authored
Avoid NULL comparison, compare using boolean operator. Issue found using coccinelle. Signed-off-by:
-
Vatsala Narang authored
Replace bit shifting on 1 with the BIT(x) macro. Issue found using coccinelle. Signed-off-by:
-
Nicholas Mc Guire authored
wait_for_completion_timeout() returns unsigned long (0 on timeout or remaining jiffies) not int. Assigning this return value to int may theoretically overflow (though not in this case where TIMEOUT is only HZ*2). Fix this inconsistency by wrapping the wait_for_completion_timeout into the if(). Signed-off-by:
Nicholas Mc Guire <hofrat@osadl.org> Reviewed-by:
Sven Van Asbroeck <TheSven73@gmail.com> Signed-off-by:
-
Greg Kroah-Hartman authored
The 0-day system found a bunch of warnings for when readq() is not defined on the platform, so fix this by including the linux/io-64-nonatomic-lo-hi.h file which will fix up these issues. Reported-by:
kbuild test robot <lkp@intel.com> Signed-off-by:
-
Greg Kroah-Hartman authored
The rtl8188eu driver uses the phydm .h files from the rtlwifi driver, but now that the rtlwifi driver is gone, it's silly to have a whole directory for just 2 .h files. So move these files into the rtl8188eu driver's directory so that it can be self-contained. Signed-off-by: -
Greg Kroah-Hartman authored
The phydm .h files are used by another driver, but not all of the defines are used, so strip them down to their basic necessities before we move them out of this directory. Signed-off-by: -
Greg Kroah-Hartman authored
A "real" driver for this hardware is now in the wireless-drivers-next tree, to be merged in the next major kernel release, so this staging driver can now be deleted as it is not needed anymore. Note, 2 .h files remain for this driver, as they are referenced in a separate staging driver. That mess will be cleaned up in a follow-on patch. Cc: Ping-Ke Shih <pkshih@realtek.com> Cc: Tzu-En Huang <tehuang@realtek.com> Cc: Yan-Hsuan Chuang <yhchuang@realtek.com> Cc: Stanislaw Gruszka <sgruszka@redhat.com> Cc: Brian Norris <briannorris@chromium.org> Cc: Kalle Valo <kvalo@codeaurora.org> Signed-off-by:
-
- 30 Apr, 2019 17 commits
-
-
Sven Van Asbroeck authored
Rename the anybus-s bus id from fieldbus_type to anybus_id, to avoid confusion with an identically named variable in the fieldbus_dev framework. Although this value is called fieldbus_type in the anybus-s docs, it acts like a bus id, so the name change is appropriate. Signed-off-by:
-
Sven Van Asbroeck authored
"Normal" bus structures such as USB or PCI keep device bus ids in bus endinanness, and driver bus ids in host endianness. Endianness conversion happens each time bus_match() is called. Modify anybus-s to conform to this pattern. As a pleasant side- effect, sparse warnings will now disappear. This was suggested by Al Viro. Link: https://lkml.org/lkml/2019/4/30/834Signed-off-by:
-
Kelsey Skunberg authored
Resolve checkpatch warning for static const char * array by using const pointers. Checkpatch Warning in sm750.c: static const char * array should probably be static const char * const Signed-off-by:
Kelsey Skunberg <skunberg.kelsey@gmail.com> Signed-off-by:
-
Vatsala Narang authored
Replace explicitely with explicitly to get rid of checkpatch warning. Signed-off-by:
Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by:
-
Vatsala Narang authored
Change suggested by coccinelle. Replace bit shifting on 1 with the BIT(x) macro. Coccinelle script: @@ expression c; @@ -(1 << c) +BIT(c) Signed-off-by:
-
Vatsala Narang authored
Modify return statement and remove the respective assignment. Issue found by Coccinelle. Signed-off-by:
Stefan Wahren <stefan.wahren@i2se.com> Signed-off-by:
-
Vandana BN authored
This patch resolves coding style brace warning and constant on right warning. WARNING: Comparisons should place the constant on the right side of the test WARNING: braces {} are not necessary for single statement blocks CHECK: Comparison to NULL could be written "!pbuf" Signed-off-by:Vandana BN <bnvandana@gmail.com> ------ v2- Edited commit message and subject v3- Edited commit message v4- changed NULL check to use !pbuf ------ Signed-off-by:
-
Vatsala Narang authored
To avoid style issues, remove multiple blank lines. Signed-off-by:
-
Vatsala Narang authored
Remove else after return statement as it is not useful. Issue found using checkpatch. Signed-off-by:
-
Vatsala Narang authored
Remove return in void function to get rid of checkpatch warning. Signed-off-by:
Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
Aaro Koskinen authored
Add missing TODO to describe the plan to get this driver out of staging. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
-
Aaro Koskinen authored
Refer to TODO file instead of driver_name.README that does not seem to be used. Signed-off-by:
-
Christian Gromm authored
This patch fixes the usage of the wrong struct device when calling function snd_card_new. Reported-by:
Eugeniu Rosca <erosca@de.adit-jv.com> Signed-off-by:
Christian Gromm <christian.gromm@microchip.com> Fixes: 69c90cf1 ("staging: most: sound: call snd_card_new with struct device") Cc: stable <stable@vger.kernel.org> Signed-off-by:
-
Dan Carpenter authored
The code is calculating the resource size wrong because it should be inclusive of the "res->end" address. In other words, "end - start + 1". We can just use the resource_size() function to do it correctly. Fixes: 7dc7967f ("staging: kpc2000: add initial set of Daktronics drivers") Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Dan Carpenter authored
The kp2000_regs struct has a 4 byte hole between ->hw_rev and ->ssid so this could leak stack information to the user. This patch just memsets the whole struct to zero. Fixes: 7dc7967f ("staging: kpc2000: add initial set of Daktronics drivers") Signed-off-by:
-
Jeremy Sowden authored
master was being initialized to a particular value and then having the same value assigned to it immediately afterwards. Removed the initializer. Since the value assigned to master was dynamically allocated, this fixes a memory-leak. Signed-off-by:
Jeremy Sowden <jeremy@azazel.net> Signed-off-by:
-
Jeremy Sowden authored
drvdata was being initialized to a particular value and then having the same value assigned to it immediately afterwards. Removed the initializer. Since the value assigned, pldev->dev.platform_data, is a pointer-to- void, removed superfluous cast. Signed-off-by:
-
- 27 Apr, 2019 1 commit
-
-
Ian Abbott authored
The "comedi_isadma" module calls `dma_alloc_coherent()` and `dma_free_coherent()` with a NULL device pointer which is no longer allowed. If the `hw_dev` member of the `struct comedi_device` has been set to a valid device, that can be used instead. Unfortunately, all the current users of the "comedi_isadma" module leave the `hw_dev` member set to NULL. In that case, fall back to using the comedi "class" device pointed to by the `class_dev` member if that is non-NULL. In that case, make it "DMA-capable" with a coherent DMA mask set to the ISA bus limit of 16MB (24 bits). Signed-off-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
- 25 Apr, 2019 14 commits
-
-
Patrick Havelange authored
Add the 4 Quadrature counters for this board. Reviewed-by:
Esben Haabendal <esben@haabendal.dk> Signed-off-by:
Patrick Havelange <patrick.havelange@essensium.com> Signed-off-by:
William Breathitt Gray <vilhelm.gray@gmail.com> Signed-off-by:
-
Patrick Havelange authored
This adds documentation for the specific prescaler entry. Signed-off-by:
-
Patrick Havelange authored
This driver exposes the counter for the quadrature decoder of the FlexTimer Module, present in the LS1021A soc. Signed-off-by:
-
Patrick Havelange authored
FlexTimer quadrature decoder driver. Reviewed-by:
-
Patrick Havelange authored
Common #defines have been moved to "linux/fsl/ftm.h". Thus making use of this file. Also FTM_SC_CLK_SHIFT has been renamed to FTM_SC_CLK_MASK_SHIFT. Reviewed-by:
-
Patrick Havelange authored
This also fixes the wrong value for the previously defined FTM_MODE_INIT macro (it was not used). Reviewed-by:
-
Patrick Havelange authored
Several files are/will be using the same #defines to use the Flextimer module. Regroup them in a common file. Reviewed-by:
-
William Breathitt Gray authored
The IIO counter subdirectory is now superceded by the Counter subsystem. This patch adds deprecation warnings to the documentation of the relevant IIO Counter sysfs attributes. Acked-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com> Signed-off-by:
-
Fabrice Gasnier authored
The STM32 LP Timer counter driver now resides under the Counter subsystem. This patch adjusts dt-bindings to account for the STM32 lptimer driver move. Cc: Mark Rutland <mark.rutland@arm.com> Signed-off-by:
Fabrice Gasnier <fabrice.gasnier@st.com> Acked-by:
Rob Herring <robh@kernel.org> Signed-off-by:
-
Fabrice Gasnier authored
Add support for new counter device to stm32-lptimer. Signed-off-by:
-
Benjamin Gaignard authored
Add bindings for STM32 Timer quadrature encoder. It is a sub-node of STM32 Timer which implement the quadratic encoder part of the hardware. Cc: Mark Rutland <mark.rutland@arm.com> Signed-off-by:
Benjamin Gaignard <benjamin.gaignard@st.com> Acked-by:
-
Benjamin Gaignard authored
Implement counter part of the STM32 timer hardware block by using counter API. Hardware only supports X2 and X4 quadrature modes. A ceiling value can be set to define the maximum value reachable by the counter. Signed-off-by:
-
William Breathitt Gray authored
This patch adds standard documentation for the Generic Counter interface userspace sysfs attributes of the 104-QUAD-8 driver. Acked-by:
-
William Breathitt Gray authored
This patch adds support for the Generic Counter interface to the 104-QUAD-8 driver. The existing 104-QUAD-8 device interface should not be affected by this patch; all changes are intended as supplemental additions as perceived by the user. Generic Counter Counts are created for the eight quadrature channel counts, as well as their respective quadrature A and B Signals (which are associated via respective Synapse structures) and respective index Signals. The new Generic Counter interface sysfs attributes are intended to expose the same functionality and data available via the existing 104-QUAD-8 IIO device interface; the Generic Counter interface serves to provide the respective functionality and data in a standard way expected of counter devices. Reviewed-by:
-
