Skip to content

L
linux
Switch branch/tag
  1. 14 Jun, 2024 2 commits
  3. 13 Jun, 2024 2 commits
  5. 12 Jun, 2024 5 commits
  7. 11 Jun, 2024 4 commits
    • Guenter Roeck's avatar
      hwmon: (pmbus/lm25066) Let enum chips start with index 0 · cbbb76e4
      Guenter Roeck authored 
      Commit ac0c26ba ("hwmon: (lm25066) Use i2c_get_match_data()") changed
enum chips to start with 1 instead of 0, under the assumption that
the data pointer in of_device_id must not start with 0 (NULL) if
i2c_get_match_data() is used. However, that is perfectly fine as long as
there is also an i2c_device_id array with the same data which is used
as fallback in that case.

Let enum chips start with 0 to avoid confusion against other drivers
where the enum starts with 0 and i2c_get_match_data() is used as well.

Cc: Rob Herring <robh@kernel.org>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
      cbbb76e4
    • Guenter Roeck's avatar
      hwmon: (nct6775) Let enum kinds start with index 0 · 22558934
      Guenter Roeck authored 
      Commit 10a0575e ("hwmon: (nct6775-i2c) Use i2c_get_match_data()")
introduced calling i2c_get_match_data() to the nct6775 driver. As part
of that commit, enum kinds was changed to start with 1, based on

    Adjust the 'kinds' enum to not use 0, so that no match data can be
    distinguished from a valid enum value.

The patch had to be fixed later with commit 2792fc8f ("hwmon:
(nct6775-core) Explicitly initialize nct6775_device_names indexes") and
commit efe86092 ("hwmon: (nct6775-platform) Explicitly initialize
nct6775_sio_names indexes").

Various patches submitted later show that the change from 0 to 1 is
not really necessary. As it turns out, it is perfectly fine as long as
there is an i2c_device_id array with the same data as in the of_device_id
array. This data is used as fallback if the data pointer in struct
of_device_id is NULL (0).

Let enum chips start with 0 to avoid confusion against other drivers
where the enum starts with 0 and i2c_get_match_data() is used as well.
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
      22558934
    • Guenter Roeck's avatar
      hwmon: (pmbus/mp2856) Let enum chips start with index 0 · e229c6e8
      Guenter Roeck authored 
      Earlier it was assumed that the data pointer in of_device_id must not start
with 0 (NULL) if i2c_get_match_data() is used. However, it turns out that
this is perfectly fine as long as there is also an i2c_device_id array with
the same data, which is used as fallback in that case.

Let enum chips start with 0 to avoid confusion against other drivers
where the enum starts with 0 and i2c_get_match_data() is used as well.

While doing that, remove chip_id from struct mp2856_data since it is only
used in the probe function, and typecast the result of i2c_get_match_data()
to kernel_ulong_t to avoid the double typecast.

Cc: Peter Yin <peteryin.openbmc@gmail.com>
Cc: Potin Lai <potin.lai.pt@gmail.com>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
      e229c6e8
    • Guenter Roeck's avatar
      hwmon: (pmbus/max31827) Explain why enum chips must not start with 0 · 138d45d9
      Guenter Roeck authored 
      If a driver calls device_get_match_data(), the .data pointer in its id
data structures must not be NULL/0 because device_get_match_data()
returns NULL if an entry is not found. Explain that in a comment to avoid
confusion why this is required in this driver but not in other drivers.

Cc: Daniel Matyas <daniel.matyas@analog.com>
Acked-by: default avatarNuno Sa <nuno.sa@analog.com>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
      138d45d9
  9. 10 Jun, 2024 7 commits
  11. 08 Jun, 2024 20 commits
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7