Skip to content

L
linux
Switch branch/tag
  1. 28 Sep, 2004 2 commits
  3. 27 Sep, 2004 3 commits
  5. 26 Sep, 2004 1 commit
  7. 25 Sep, 2004 1 commit
  9. 24 Sep, 2004 1 commit
  11. 23 Sep, 2004 4 commits
  13. 21 Sep, 2004 1 commit
  15. 20 Sep, 2004 3 commits
  17. 19 Sep, 2004 1 commit
    • James Bottomley's avatar
      scsi: Add reset ioctl capability to ULDs · 0ed32242
      James Bottomley authored 
      Currently, the only way to issue a SCSI reset of any
type is to use the sg device.  By adding extra ioctls
to scsi_ioctl.c we enable this for all ULDs.

The slight complication is that scsi_ioctl() is usually
only called when the device has been checked not to be
undergoing eh recovery.  Resets may be issued in
this scenario if the user opens the device O_NONBLOCK.
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      0ed32242
  19. 17 Sep, 2004 5 commits
    • James Bottomley's avatar
      some ncr53c8xx decrufting · 89f88233
      James Bottomley authored 
      From: Christoph Hellwig <hch@lst.de>

kills lots of BSD glue and procfs mess

Acked by: Matthew Wilcox <willy@debian.org>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      89f88233
    • Andrew Vasquez's avatar
      [PATCH] SCSI QLA not working on latest *-mm SN2 (qla_dbg fixes) · 9a65eb07
      Andrew Vasquez authored 
      On Thu, 2004-09-16 at 14:09, Jesse Barnes wrote:
> On Thursday, September 16, 2004 1:56 pm, Andrew Vasquez wrote:
> > On Thu, 2004-09-16 at 13:05, Jesse Barnes wrote:
> > > On Thursday, September 16, 2004 12:56 pm, Paul Jackson wrote:
> > > > Andrew Vasquez has been looking at this, via private email with just
> > > > me (no progress yet).  Figured I update the larger list with this much
> > > > ...
> > >
> > > It seems to be failing on one of the accesses to PCI_COMMAND in config
> > > space in qla2x00_reset_chip().  I'm checking now to see if we're
> > > accessing the card right after a reset but before the card has finished.
> > > That would cause a master abort, the symptom I'm seeing at least.
> >
> > Interesting, the only changes in reset_chip() are for PCI posting
> > issues.  Relevant diff attached.
>
> Yeah, I think one of these is the culprit.  Before I got your message, I fixed
> some of them in my tree already (see attached) and things seem to work.
>

Hmm, seems we were a bit too over-aggressive in placement of the
readw()s :(

>         WRT_REG_WORD(&reg->hccr, HCCR_CLR_RISC_INT);
> +       RD_REG_WORD(&reg->hccr);                        /* PCI Posting. */
>         WRT_REG_WORD(&reg->hccr, HCCR_CLR_HOST_INT);
> +       RD_REG_WORD(&reg->hccr);                        /* PCI Posting. */
>
>         /* Reset ISP chip. */
>         WRT_REG_WORD(&reg->ctrl_status, CSR_ISP_SOFT_RESET);
> +       RD_REG_WORD(&reg->ctrl_status);                 /* PCI Posting. */
>
> In particular, are the above ok?  If the chip is resetting, won't doing a read
> cause a machine check (or at the very least, a device select timeout, which
> will return all ones on friendlier platforms).
>

There are several more which deltas in qla_dbg.c which are suspect
also.

>         WRT_REG_WORD(&reg->ctrl_status, CSR_ISP_SOFT_RESET);
> +       RD_REG_WORD(&reg->ctrl_status);                 /* PCI Posting. */
>
> Same here?
>

Andrew, please add Jesse's patch along with the patch I'm attaching to
your tree.  I'll be sure to add the ia64 machine back into our test
ring.
Signed-off-by: default avatarAndrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      9a65eb07
    • Jesse Barnes's avatar
      [PATCH] SCSI QLA not working on latest *-mm SN2 · a861b62e
      Jesse Barnes authored 
      On Thursday, September 16, 2004 1:56 pm, Andrew Vasquez wrote:
> On Thu, 2004-09-16 at 13:05, Jesse Barnes wrote:
> > On Thursday, September 16, 2004 12:56 pm, Paul Jackson wrote:
> > > Andrew Vasquez has been looking at this, via private email with just
> > > me (no progress yet).  Figured I update the larger list with this much
> > > ...
> >
> > It seems to be failing on one of the accesses to PCI_COMMAND in config
> > space in qla2x00_reset_chip().  I'm checking now to see if we're
> > accessing the card right after a reset but before the card has finished.
> > That would cause a master abort, the symptom I'm seeing at least.
>
> Interesting, the only changes in reset_chip() are for PCI posting
> issues.  Relevant diff attached.

Yeah, I think one of these is the culprit.  Before I got your message, I fixed
some of them in my tree already (see attached) and things seem to work.

        WRT_REG_WORD(&reg->hccr, HCCR_CLR_RISC_INT);
+       RD_REG_WORD(&reg->hccr);                        /* PCI Posting. */
        WRT_REG_WORD(&reg->hccr, HCCR_CLR_HOST_INT);
+       RD_REG_WORD(&reg->hccr);                        /* PCI Posting. */

        /* Reset ISP chip. */
        WRT_REG_WORD(&reg->ctrl_status, CSR_ISP_SOFT_RESET);
+       RD_REG_WORD(&reg->ctrl_status);                 /* PCI Posting. */

In particular, are the above ok?  If the chip is resetting, won't doing a read
cause a machine check (or at the very least, a device select timeout, which
will return all ones on friendlier platforms).

        WRT_REG_WORD(&reg->ctrl_status, CSR_ISP_SOFT_RESET);
+       RD_REG_WORD(&reg->ctrl_status);                 /* PCI Posting. */

Same here?
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      a861b62e
    • Mark Haverkamp's avatar
      [PATCH] 2.6.9 aacraid: aac_count fix · 66a3e831
      Mark Haverkamp authored 
      Changed the managing of aac device structures to a linked list so that
there is no limit to how many adapters can be configured.  Also, put the
call to scsi_add_host earlier in the probe function, before devices are
accessed.
Signed-off-by: default avatarMark Haverkamp <markh@osdl.org>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      66a3e831
    • James Bottomley's avatar
      scsi: add proper pci id table to aic7xxx · 864b4eac
      James Bottomley authored 
      From: Andi Kleen <ak@suse.de>

Patch updated by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      864b4eac
  21. 16 Sep, 2004 6 commits
  23. 13 Sep, 2004 4 commits
  25. 12 Sep, 2004 2 commits
  27. 11 Sep, 2004 1 commit
  29. 10 Sep, 2004 5 commits
    • James Bottomley's avatar
      ServeRAID driver ( ips ) Version 7.10.18 · 3da73622
      James Bottomley authored 
      From: Hammer, Jack <Jack_Hammer@adaptec.com>

- Fix path/name for scsi_hosts.h include for 2.6 kernels
- Fix sort order of 7k
- Remove 3 unused "inline" functions
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      3da73622
    • James Bottomley's avatar
      fix printk warning in sg.c · 6baf14e7
      James Bottomley authored 
      sizeof() != int
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      6baf14e7
    • James Bottomley's avatar
      fix undefined function msleep warning in osst · 27d5c1ee
      James Bottomley authored 
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      27d5c1ee
    • James Bottomley's avatar
      scsi: normalize fixed and descriptor sense data · 3123e8db
      James Bottomley authored 
      From: Douglas Gilbert <dougg@torque.net>

The patch only touches two files: scsi.h and scsi_lib.c
It adds the proposed facility and then uses it in scsi_lib
in roughly 4 locations. IMO there were 3 sense processing errors:
   - block SG_IO did not get passed back deferred errors
     [SG_IO is a __pass-through__ interface!!]
   - MEDIUM_ERRORs _do_ get processed for deferred sense errors
     in scsi_io_completion() which seems unintended
     [I did not fix this one.]
   - invalid command operation code handling in
     __scsi_mode_sense() was just wrong

If people think this is a reasonable approach, then the rest of
the scsi mid-level and upper level driver could be converted.
As Kai pointed we may need some general routines to pick up the
sense data "extras".

The benefit of doing this conversion is that it may well
highlight a lot more sense data processing errors (if the
above is any guide).

Changes:
    - add structure to receive normalized sense data from either
      fixed or descriptor format sense data
    - add scsi_normalize_sense() function to populate that structure
    - add scsi_sense_is_deferred() function so deferred errors can
      be ignored in many contexts
    - apply new mechanism to sense data processing within the
      scsi_lib.c file

Patch reformatted by: Christoph Hellwig <hch@lst.de>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      3123e8db
    • Douglas Gilbert's avatar
      [PATCH] sg jiffy library calls [was: sg kill local jiffies · a4d56cc4
      Douglas Gilbert authored 
      Douglas Gilbert wrote:
> It has been reported that the change to sg.c in lk 2.6.9-rc1-bk5
> to use library jiffy functions breaks sg (albeit under vmware).
> Evidentally sg devices are no longer recognised after that change.
> 
> Reverting that changeset removes the problem. Strange, it is not
> obvious why.
> 
> At some stage I must have detected negative time spans (yeh yeh it
> never happens) and my versions returned 0 in this case; otherwise
> the implementations look very similar.

The following patch fixes the problem. It is
against lk 2.6.9-rc1-bk7 (i.e. after "standard"
jiffy_to_millisecs macros replaced sg versions).

Change:
    - make sure a (large) user supplied timeout value does
      not result in a negative timeout passed to the midlevel
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      a4d56cc4
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7