1. 11 Mar, 2011 5 commits
  2. 09 Mar, 2011 3 commits
  3. 07 Mar, 2011 7 commits
    • Lars-Peter Clausen's avatar
      ARM: s3c24xx: Switch to common GPIO controlled UDC pullup implementation · e27c3c5c
      Lars-Peter Clausen authored
      Currently all boards using the s3c2410_udc driver use a GPIO to control the
      state of the pullup, as a result the same code is reimplemented in each board
      This patch changes these boards to use the common implementation for GPIO
      controlled pullup in the UDC driver.
      Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
      Acked-by: default avatarVasily Khoruzhick <anarsoul@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      e27c3c5c
    • Lars-Peter Clausen's avatar
      USB: s3c2410_udc: Add common implementation for GPIO controlled pullups · a74022a5
      Lars-Peter Clausen authored
      Currently all boards using the s3c2410_udc driver use a GPIO to control the
      state of the pullup, as a result the same code is reimplemented in each board
      file.
      This patch adds support for using a GPIO to control the pullup state to the udc
      driver, so the boards can use a common implementation.
      Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      a74022a5
    • Anand Gadiyar's avatar
      arm: omap4: 4430sdp: drop ehci support · 09173b58
      Anand Gadiyar authored
      Most revisions of the OMAP4 Blaze/SDP platform do not have
      the EHCI signals routed by default. The pads are routed
      for the alternate HSI functionality instead, and explicit
      board modifications are needed to route the signals to
      the USB PHY on the board.
      
      Also, turning on the PHY connected to the EHCI port causes
      a board reboot during bootup due to an unintended short
      on the rails - this affects many initial revisions of the
      board, and needs a minor board mod to fix (or as a
      workaround, one should not attempt to power on the
      USB PHY).
      
      Given that these boards need explicit board mods to even
      get EHCI working (separate from the accidental short above),
      we should not attempt to enable EHCI by default.
      
      So drop the EHCI support from the board files for the
      Blaze/SDP platforms.
      Signed-off-by: default avatarAnand Gadiyar <gadiyar@ti.com>
      Cc: Keshava Munegowda <keshava_mgowda@ti.com>
      Cc: Tony Lindgren <tony@atomide.com>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      09173b58
    • Sergei Shtylyov's avatar
      USB: OHCI: use pci_dev->revision · fa417c36
      Sergei Shtylyov authored
      Commit ab1666c1 (USB: quirk PLL power down mode)
      added code that reads the revision ID from the PCI configuration register while
      it's stored by PCI subsystem in the 'revision' field of 'struct pci_dev'...
      Signed-off-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      fa417c36
    • Pavankumar Kondeti's avatar
      USB: Rename "msm72k_otg.c" to "msm_otg.c" · dfb2130c
      Pavankumar Kondeti authored
      This driver is used across all MSM SoCs.  Hence give a generic name.
      All Functions and strutures are also using "msm_otg" as prefix.
      Signed-off-by: default avatarPavankumar Kondeti <pkondeti@codeaurora.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      dfb2130c
    • Arvid Brodin's avatar
      usb/isp1760: Fix crash when unplugging bug · d3cf2a8d
      Arvid Brodin authored
      This fixes a problem with my previous patch series where there's a great
      risk that the kernel will crash when unplugging interrupt devices from
      the USB port. These lines must have got missing when I rebased the
      patches from the older kernel I was working with to 2.6.37 and 2.6-next:
      
      This fixes a bug where the kernel may crash if you unplug a USB device
      that has active interrupt transfers.
      Signed-off-by: default avatarArvid Brodin <arvid.brodin@enea.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      d3cf2a8d
    • Alan Stern's avatar
      USB: move usbcore away from hcd->state · 9b37596a
      Alan Stern authored
      The hcd->state variable is a disaster.  It's not clearly owned by
      either usbcore or the host controller drivers, and they both change it
      from time to time, potentially stepping on each other's toes.  It's
      not protected by any locks.  And there's no mechanism to prevent it
      from going through an invalid transition.
      
      This patch (as1451) takes a first step toward fixing these problems.
      As it turns out, usbcore uses hcd->state for essentially only two
      things: checking whether the controller's root hub is running and
      checking whether the controller has died.  Therefore the patch adds
      two new atomic bitflags to the hcd structure, to store these pieces of
      information.  The new flags are used only by usbcore, and a private
      spinlock prevents invalid combinations (a dead controller's root hub
      cannot be running).
      
      The patch does not change the places where usbcore sets hcd->state,
      since HCDs may depend on them.  Furthermore, there is one place in
      usb_hcd_irq() where usbcore still must use hcd->state: An HCD's
      interrupt handler can implicitly indicate that the controller died by
      setting hcd->state to HC_STATE_HALT.  Nevertheless, the new code is a
      big improvement over the current code.
      
      The patch makes one other change.  The hcd_bus_suspend() and
      hcd_bus_resume() routines now check first whether the host controller
      has died; if it has then they return immediately without calling the
      HCD's bus_suspend or bus_resume methods.
      
      This fixes the major problem reported in Bugzilla #29902: The system
      fails to suspend after a host controller dies during system resume.
      Signed-off-by: default avatarAlan Stern <stern@rowland.harvard.edu>
      Tested-by: default avatarAlex Terekhov <a.terekhov@gmail.com>
      CC: <stable@kernel.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      9b37596a
  4. 03 Mar, 2011 5 commits
  5. 01 Mar, 2011 20 commits
    • Yoshihiro Shimoda's avatar
      usb: EHCI, OHCI: Add configuration for the SH USB controller · 60b0bf0f
      Yoshihiro Shimoda authored
      The SH EHCI/OHCI driver hardcoded the CPU type in {ehci,ohci}-hcd.c.
      So if we will add the new CPU, we had to add to the hcd driver each time.
      The patch adds the CONFIG_USB_{EHCI,OHCI}_SH configuration. So if we
      want to use the SH EHCI/OHCI, we only enable the configuration.
      Signed-off-by: default avatarYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      60b0bf0f
    • Andiry Xu's avatar
      USB host: Move AMD PLL quirk to pci-quirks.c · ad93562b
      Andiry Xu authored
      This patch moves the AMD PLL quirk code in OHCI/EHCI driver to pci-quirks.c,
      and exports the functions to be used by xHCI driver later.
      
      AMD PLL quirk disable the optional PM feature inside specific
      SB700/SB800/Hudson-2/3 platforms under the following conditions:
      
      1. If an isochronous device is connected to OHCI/EHCI/xHCI port and is active;
      2. Optional PM feature that powers down the internal Bus PLL when the link is
         in low power state is enabled.
      
      Without AMD PLL quirk, USB isochronous stream may stutter or have breaks
      occasionally, which greatly impair the performance of audio/video streams.
      
      Currently AMD PLL quirk is implemented in OHCI and EHCI driver, and will be
      added to xHCI driver too. They are doing similar things actually, so move
      the quirk code to pci-quirks.c, which has several advantages:
      
      1. Remove duplicate defines and functions in OHCI/EHCI (and xHCI) driver and
         make them cleaner;
      2. AMD chipset information will be probed only once and then stored.
         Currently they're probed during every OHCI/EHCI initialization, move
         the detect code to pci-quirks.c saves the repeat detect cost;
      3. Build up synchronization among OHCI/EHCI/xHCI driver. In current
         code, every host controller enable/disable PLL only according to
         its own status, and may enable PLL while there is still isoc transfer on
         other HCs. Move the quirk to pci-quirks.c prevents this issue.
      Signed-off-by: default avatarAndiry Xu <andiry.xu@amd.com>
      Cc: David Brownell <dbrownell@users.sourceforge.net>
      Cc: Alex He <alex.he@amd.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      ad93562b
    • Keshava Munegowda's avatar
      arm: omap: usb: clock entries for omap3 and omap4 · 53689ac1
      Keshava Munegowda authored
      The devices of clocks are set to usbhs, so that
      only usbhs common driver can invoke these clocks.
      The dummy per port clocks are added to omap3
      clock data base. This helps to invoke common
      clock get APIs for omap3 and omap4.
      Signed-off-by: default avatarKeshava Munegowda <keshava_mgowda@ti.com>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      53689ac1
    • Keshava Munegowda's avatar
      usb: host: omap: ehci and ohci simplification · 19403165
      Keshava Munegowda authored
      The ehci and ohci drivers are simplified; Since
      UHH and TLL initialization, clock handling are
      done by common usbhs core driver, these functionalities
      are removed from ehci and ohci drivers.
      Signed-off-by: default avatarKeshava Munegowda <keshava_mgowda@ti.com>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      19403165
    • Keshava Munegowda's avatar
      arm: omap: usb: cleanup ehci and ohci resources and devices · 3b68ae73
      Keshava Munegowda authored
      The prototype and defination of functions usb_ehci_init and
      usb_ohci_init are removed. The ehci and ohci devices are
      removed since usbhs device contains both ehci and ohci details.
      Signed-off-by: default avatarKeshava Munegowda <keshava_mgowda@ti.com>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      3b68ae73
    • Keshava Munegowda's avatar
      arm: omap: usb: Invoke usbhs core device initialization · 9e64bb1e
      Keshava Munegowda authored
      The usbhs intialization is invoked by all omap3 and omap4
      variant board files.
      Signed-off-by: default avatarKeshava Munegowda <keshava_mgowda@ti.com>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      9e64bb1e
    • Keshava Munegowda's avatar
      arm: omap: usb: usbhs core device initialization · 2236396d
      Keshava Munegowda authored
      A new usbhs platform device is defined;
      this device will be the parent device of ehci and
      ohci platform devices. the usbhs_init function
      is defined which does the usbhs device initialization
      and I/O mux of ehci and ohci.
      Signed-off-by: default avatarKeshava Munegowda <keshava_mgowda@ti.com>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      2236396d
    • Keshava Munegowda's avatar
      usb: host: omap: common usb host core driver · 17cdd29d
      Keshava Munegowda authored
      enabling and disabling the common clocks for ehci
      and ohci is implemented. usbhs is a common parent
      platform driver for EHCI and OHCI driver. This driver
      receives the clock enable and disable requests
      from ehci and ohci drivers.The UHH and TLL
      initialization is also performed.
      Signed-off-by: default avatarKeshava Munegowda <keshava_mgowda@ti.com>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      17cdd29d
    • Keshava Munegowda's avatar
      arm: omap: usb: create common enums and structures for ehci and ohci · 181b250c
      Keshava Munegowda authored
      Create the ehci and ohci specific platform data structures.
      The port enum values are made common for both ehci and ohci.
      Signed-off-by: default avatarKeshava Munegowda <keshava_mgowda@ti.com>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      181b250c
    • Felipe Balbi's avatar
      arm: omap2: usb: rename usb-ehci.c to usb-host.c · a8480ea0
      Felipe Balbi authored
      We already have both EHCI and OHCI there, so let's
      rename to be sure everybody will understand the entire
      USB HOST functionality is setup on this file.
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      a8480ea0
    • Felipe Balbi's avatar
      usb: host: omap: switch to platform_get_resource_byname · 09f0607d
      Felipe Balbi authored
      now that we have names on all memory bases, we can
      switch to use platform_get_resource_byname() which
      will make it simpler when we move to a setup where
      OHCI and EHCI on OMAP play well together.
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      09f0607d
    • Felipe Balbi's avatar
      arm: omap: usb: host: add names to resources · a9031e5f
      Felipe Balbi authored
      add names to EHCI and OHCI resources. That will help us
      identify the resource correctly when moving to a setup
      where OHCI and EHCI play well together.
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      a9031e5f
    • Anand Gadiyar's avatar
      usb: ehci: omap: add support for TLL mode on OMAP4 · 87ecc73b
      Anand Gadiyar authored
      The EHCI controller in OMAP4 supports a transceiver-less link
      mode (TLL mode), similar to the one in OMAP3. On the OMAP4
      however, there are an additional set of clocks that need
      to be turned on to get this working.
      
      Request and configure these for each port if that port
      is connected in TLL mode.
      Signed-off-by: default avatarAnand Gadiyar <gadiyar@ti.com>
      Cc: Greg Kroah-Hartman <gregkh@suse.de>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      87ecc73b
    • Huzaifa Sidhpurwala's avatar
      usb: musb: tusb: Fix possible null pointer dereference in tusb6010_omap.c · c88ba39c
      Huzaifa Sidhpurwala authored
      tusb_dma was being dereferenced when it was nul
      Signed-off-by: default avatarHuzaifa Sidhpurwala <huzaifas@redhat.com>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      c88ba39c
    • Hema HK's avatar
      usb: musb: OMAP3xxx: Fix device detection in otg & host mode · 70045c57
      Hema HK authored
      In OMAP3xxx with OTG mode or host only mode, When the device
      is inserted after the gadget driver loading the enumeration was not
      through. This is because the mentor controller will start sensing the
      ID PIN only after setting the session bit.
      So after ID-GND, need to set the session bit for mentor to get it
      configured as A device.
      
      This is a fix to set the session bit again in ID_GND notification handler.
      Tested with OMAP3630Zoom3 platform.
      Signed-off-by: default avatarHema HK <hemahk@ti.com>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      70045c57
    • Hema HK's avatar
      usb: musb: OMAP4430: Power down the PHY during board init · fb91cde4
      Hema HK authored
      Powerdown the internal PHY during board init for OMAP44xx.
      So that when musb is disabled core transition to retention/off
      is not blocked.
      Signed-off-by: default avatarHema HK <hemahk@ti.com>
      Cc: Tony Lindgren <tony@atomide.com>
      Cc: Paul Walmsley <paul@pwsan.com>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      fb91cde4
    • Hema HK's avatar
      usb: otg: OMAP4430: Save/restore the context · 8c59ef38
      Hema HK authored
      Add the context save/restore for the control module register
      used for OMAP4430 musb with UTMI embedded PHY interface.
      Signed-off-by: default avatarHema HK <hemahk@ti.com>
      Cc: Tony Lindgren <tony@atomide.com>
      Cc: Paul Walmsley <paul@pwsan.com>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      8c59ef38
    • Hema HK's avatar
      usb: otg: TWL4030: Update the last_event variable. · 37db3af1
      Hema HK authored
      Update the last_event variable of otg_transceiver. This will be used in
      the musb platform glue driver for runtime idling the device.
      Signed-off-by: default avatarHema HK <hemahk@ti.com>
      Cc: Felipe Balbi <balbi@ti.com>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      37db3af1
    • Hema HK's avatar
      usb: musb: Idle path retention and offmode support for OMAP3 · 7acc6197
      Hema HK authored
      This patch supports the retention and offmode support in the idle path for
      musb driver using runtime pm APIs.
      
      This is restricted to support offmode and retention only when device not
      connected.When device/cable connected with gadget driver loaded,configured
      to no idle/standby which will not allow the core transition to retention
      or off.
      
      There is no context save/restore done by hardware for musb in OMAP3
      and OMAP4,driver has to take care of saving and restoring the context
      during offmode.
      
      Musb has a requirement of configuring sysconfig register to force
      idle/standby mode and set the ENFORCE bit in module STANDBY register
      for retention and offmode support.
      
      Runtime pm and hwmod frameworks will take care of configuring to force
      idle/standby when pm_runtime_put_sync is called and back to no
      idle/standby when pm_runeime_get_sync is called.
      
      Compile, boot tested and also tested the retention in the idle path on
      OMAP3630Zoom3. And tested the global suspend/resume with offmode enabled.
      Usb basic functionality tested on OMAP4430SDP.
      
      There is some problem with idle path offmode in mainline, I could not test
      with offmode. But I have tested this patch with resetting the controller
      in the idle path when wakeup from retention just to make sure that the
      context is lost, and restore path is working fine.
      
      Removed .suspend/.resume fnction pointers and functions because there
      is no need of having these functions as all required work is done
      at runtime in the driver.
      
      There is no need to call the runtime pm api with glue driver device
      as glue layer device is the parent of musb core device, when runtime apis
      are called for the child, parent device runtime functionality
      will be invoked.
      
      Design overview:
      
      pm_runtime_get_sync: When called with musb core device takes care of
      enabling the clock, calling runtime callback function of omap2430 glue
      layer, runtime call back of musb driver and configure the musb sysconfig
      to no idle/standby
      
      pm_runtime_put: Takes care of calling runtime callback function of omap2430
      glue layer, runtime call back of musb driver, Configure the musb sysconfig
      to force idle/standby and disable the clock.
      
      During musb driver load: Call pm_runtime_get_sync.
      
      End of musb driver load: Call pm_runtime_put
      
      During gadget driver load: Call pm_runtime_get_sync,
      End of gadget driver load: Call pm_runtime_put if there is no device
      or cable is connected.
      
      During unload of the gadget driver:Call pm_runtime_get_sync if cable/device
      is not connected.
      End of the gadget driver unload : pm_runtime_put
      
      During unload of musb driver : Call pm_runtime_get_sync
      End of unload: Call pm_runtime_put
      
      On connect of usb cable/device -> transceiver notification(VBUS and ID-GND):
      pm_runtime_get_sync only if the gadget driver loaded.
      
      On disconnect of the cable/device -> Disconnect Notification:
      pm_runtime_put if the gadget driver is loaded.
      Signed-off-by: default avatarHema HK <hemahk@ti.com>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      7acc6197
    • Hema HK's avatar
      usb: musb: Remove platform context save/restore API · da68ccec
      Hema HK authored
      For OMAP3 and OMAP4 for offmode and retention support, musb
      sysconfig is configured to force idle and standby with ENABLE_FORCE bit
      of OTG_FORCESTNDBY set.
      And on wakeup configure to no ilde/standby with resetting the ENABLE_FORCE
      bit. There is not need to save and restore of this register anymore
      so removed omap2430_save_context/omap2430_restore_context functions.
      and also removed otg_forcestandby member of musb_context_registers
      structure
      Signed-off-by: default avatarHema HK <hemahk@ti.com>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      da68ccec