- 23 Sep, 2015 32 commits
-
-
Michael Grzeschik authored
This patch moves the module_init and module_exit patches to the end of the file. It also replaces the printk with pr_info. Signed-off-by:Michael Grzeschik <m.grzeschik@pengutronix.de>
-
Michael Grzeschik authored
This patch replaces all magic numbers in the driver with proper named macros. For the case of XTOcfg and STARTIOcmd it introduces the new macros. Signed-off-by: -
Michael Grzeschik authored
This patch changes the macro definitions to match the C99 formating. This improves the readability. Signed-off-by: -
Joe Perches authored
The word length macros are unused. Remove them. Signed-off-by:
Joe Perches <joe@perches.com> Signed-off-by:
-
Joe Perches authored
Deduplicate the COM9026 registers. Signed-off-by:
-
Joe Perches authored
It's clearer to use function pointer calls directly instead of the macro indirections of ARCRESET, ACOMMAND, ASTATUS, and AINTMASK. Remove the now unused macros too. Signed-off-by:
-
Joe Perches authored
Simplify and make consistent the current uses of readb/writeb by using the newly introduced arcnet_<I/O> equivalents. Signed-off-by:
-
Joe Perches authored
Simplify and make consistent the current uses of readb/writeb by using the newly introduced arcnet_<I/O> equivalents. o Add new #defines for register offsets o Remove old #defines that included the ioaddr o Remove obfuscating macros by expanding them in-place where appropriate Signed-off-by:
-
Joe Perches authored
Use the same indirection as the other arcnet_<I/O> macros. Neither of these new macros add the BUS_ALIGN use for 8 bit devices on 16 bit busses. Signed-off-by:
-
Joe Perches authored
Simplify and make consistent the current uses of inb/outb by using the newly introduced arcnet_<I/O> equivalents. o Add new #defines for register offsets o Remove old #defines that included the ioaddr o Remove obfuscating macros by expanding them in-place where appropriate Signed-off-by:
-
Joe Perches authored
Simplify and make consistent the current uses of inb/outb by using the newly introduced arcnet_<I/O> equivalents. o Add new #defines for register offsets o Remove old #defines that included the ioaddr o Remove obfuscating macros by expanding them in-place where appropriate Signed-off-by:
-
Joe Perches authored
Simplify and make consistent the current uses of inb/outb by using the newly introduced arcnet_<I/O> equivalents. o Add new #defines for register offsets There is an register offset, 8, that is unnamed and used as-is. o Remove old #defines that included the ioaddr o Remove obfuscating macros by expanding them in-place where appropriate o Create static inline com20020_set_subaddress for the SET_SUBADR macro There is an unused arcnet config entry CONFIGSA100_CT6001 which added a special #define BUS_ALIGN which was introduced but never used in fullhist git tree commit 22cfce4b82b0 ("[ARCNET]: Fixes.") in Nov 2004 for Linux v2.6.10. This BUS_ALIGN #define tries to allow 8 bit devices to work on a 16 bit bus by aligning addresses to 16 bit boundaries. Move this currently unused CONFIG_SA1100_CT6001 BUS_ALIGN macro from com20020.h to arcdevice.h. Signed-off-by: -
Joe Perches authored
arcnet uses an I/O scheme which can align I/O addresses to word boundaries on different architectures. Add arcnet specific macros which can hide this alignment calculation. Signed-off-by:
-
Joe Perches authored
Might as well be specific about the use of this array. Add a commment questioning the indexing too. Signed-off-by:
-
Joe Perches authored
These #include files don't need to be in the include/linux directory as they can be local to drivers/net/arcnet/ Move them and update the #include statements. Update the MAINTAINERS file pattern by deleting arcdevice from the NETWORKING block as arcnet is currently unmaintained. Signed-off-by:
-
Joe Perches authored
Just neatening. Signed-off-by:
-
Joe Perches authored
Make sure the arguments are tested appropriately when not using this function. Signed-off-by:
-
Joe Perches authored
Use direct tests of pointer instead. Signed-off-by:
-
Joe Perches authored
Move the assignment above the if like general kernel style. Signed-off-by:
-
Joe Perches authored
Alloc failures have generic stack dumps so these are redundant. Signed-off-by:
-
Joe Perches authored
Use the normal kernel style for EXPORT_SYMBOL. Signed-off-by:
-
Joe Perches authored
Use the more current logging style. Remove #define VERSION, use pr_info normally. Add pr_fmt with "arcnet:" prefixes and KBUILD_MODNAME. Signed-off-by:
-
Joe Perches authored
These macros don't actually represent BUG uses but are more commonly used as logging macros, so use a more kernel style macro. Convert the BUGMSG from a netdev_ like use to actually use netdev_<level>. Signed-off-by:
-
Joe Perches authored
Don't hide what should be obvious. Make the macro a simple test instead of using if and test. Signed-off-by:
-
Joe Perches authored
These macros are actually printk and pr_cont uses with a flag. Add a new BUGLVL_TEST macro which is just the "should use" test and not an odd "if (<foo>)" macro to simplify uses in a new patch. Signed-off-by:
-
Joe Perches authored
Conformity can be useful. Signed-off-by:
-
Joe Perches authored
Use the preferred kernel include path for asm paths. Signed-off-by:
-
Joe Perches authored
Using coalesced strings helps grep for specific messages. Signed-off-by:
-
Joe Perches authored
Move braces normal kernel locations. Add missing braces. Signed-off-by:
-
Joe Perches authored
Use a more current kernel line style. Signed-off-by:
-
Joe Perches authored
Standardized spacing is easier to read. git diff -w shows no differences. objdiff shows no differences. Signed-off-by:
-
Joe Perches authored
Standardized spacing is easier to read. Signed-off-by:
-
- 22 Sep, 2015 8 commits
-
-
Andrzej Hajda authored
skb->len is always non-negative. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576Signed-off-by:
Andrzej Hajda <a.hajda@samsung.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Andrzej Hajda authored
Thresholds uses -1 to indicate that default value should be used. Since thresholds are unsigned sign checking makes no sense. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576Signed-off-by:
-
Andrzej Hajda authored
Thresholds uses -1 to indicate that default value should be used. Since thresholds are unsigned sign checking makes no sense. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576Signed-off-by:
-
Andrzej Hajda authored
To avoid underflows signed variables should be used in expression. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576Signed-off-by:
Amitkumar Karwar <akarwar@marvell.com> Signed-off-by:
-
Andrzej Hajda authored
Unsigned minus constant is still unsigned so checking its sign makes no sense. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576Signed-off-by:
-
Andrzej Hajda authored
Variable can store negative values. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576Signed-off-by:
-
Andrzej Hajda authored
phy_mode can be negative. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576Signed-off-by:
-
Andrzej Hajda authored
Difference of unsigned values is also unsigned so it does not make sense to check its sign. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576Signed-off-by:
-
