1. 12 May, 2011 1 commit
  2. 11 May, 2011 4 commits
    • Sarah Sharp's avatar
      xhci: Fix bug in control transfer cancellation. · 3abeca99
      Sarah Sharp authored
      When the xHCI driver attempts to cancel a transfer, it issues a Stop
      Endpoint command and waits for the host controller to indicate which TRB
      it was in the middle of processing.  The host will put an event TRB with
      completion code COMP_STOP on the event ring if it stops on a control
      transfer TRB (or other types of transfer TRBs).  The ring handling code
      is supposed to set ep->stopped_trb to the TRB that the host stopped on
      when this happens.
      
      Unfortunately, there is a long-standing bug in the control transfer
      completion code.  It doesn't actually check to see if COMP_STOP is set
      before attempting to process the transfer based on which part of the
      control TD completed.  So when we get an event on the data phase of the
      control TRB with COMP_STOP set, it thinks it's a normal completion of
      the transfer and doesn't set ep->stopped_td or ep->stopped_trb.
      
      When the ring handling code goes on to process the completion of the Stop
      Endpoint command, it sees that ep->stopped_trb is not a part of the TD
      it's trying to cancel.  It thinks the hardware has its enqueue pointer
      somewhere further up in the ring, and thinks it's safe to turn the control
      TRBs into no-op TRBs.  Since the hardware was in the middle of the control
      TRBs to be cancelled, the proper software behavior is to issue a Set TR
      dequeue pointer command.
      
      It turns out that the NEC host controllers can handle active TRBs being
      set to no-op TRBs after a stop endpoint command, but other host
      controllers have issues with this out-of-spec software behavior.  Fix this
      behavior.
      
      This patch should be backported to kernels as far back as 2.6.31, but it
      may be a bit challenging, since process_ctrl_td() was introduced in some
      refactoring done in 2.6.36, and some endian-safe patches added in 2.6.40
      that touch the same lines.
      Signed-off-by: default avatarSarah Sharp <sarah.a.sharp@linux.intel.com>
      Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
      Cc: stable@kernel.org
      3abeca99
    • Kuninori Morimoto's avatar
      usb: renesas_usbhs: fixup error processing on probe/remove · 97f93227
      Kuninori Morimoto authored
      The error processing order was wrong.
      This patch modify it.
      Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      97f93227
    • Kuninori Morimoto's avatar
      usb: renesas_usbhs: fixup fifo disable · c786e09c
      Kuninori Morimoto authored
      It was necessary to check pipe condition after disable fifo.
      Current driver checked it in a wrong place.
      Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      c786e09c
    • Erik Slagter's avatar
      USB: cdc_acm: Fix oops when Droids MuIn LCD is connected · fd5054c1
      Erik Slagter authored
      The Droids MuIn LCD operates like a serial remote terminal.
      Data received are displayed directly on the LCD. This patch
      fixes the kernel null pointer oops when it is plugged in.
      
      Add NO_DATA_INTERFACE quirk to tell the driver that "control"
      and "data" interfaces are not separated for this device, which
      prevents dereferencing a null pointer in the device probe code.
      Signed-off-by: default avatarErik Slagter <erik@slagter.name>
      Signed-off-by: default avatarMaxin B. John <maxin.john@gmail.com>
      Tested-by: default avatarErik Slagter <erik@slagter.name>
      Cc: stable <stable@kernel.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      fd5054c1
  3. 10 May, 2011 14 commits
  4. 09 May, 2011 21 commits