1. 18 Mar, 2022 3 commits
  2. 17 Mar, 2022 5 commits
  3. 15 Mar, 2022 2 commits
  4. 14 Mar, 2022 3 commits
    • Jorge Lopez's avatar
      platform/x86: hp-wmi: Fix 0x05 error code reported by several WMI calls · be9d73e6
      Jorge Lopez authored
      Several WMI queries leverage hp_wmi_read_int function to read their
      data. hp_wmi_read_int function was corrected in a previous patch.
      Now, this function invokes hp_wmi_perform_query with input parameter
      of size zero and the output buffer of size 4.
      
      WMI commands calling hp_wmi_perform_query with input buffer size value
      of zero are listed below.
      
      HPWMI_DISPLAY_QUERY
      HPWMI_HDDTEMP_QUERY
      HPWMI_ALS_QUERY
      HPWMI_HARDWARE_QUERY
      HPWMI_WIRELESS_QUERY
      HPWMI_BIOS_QUERY
      HPWMI_FEATURE_QUERY
      HPWMI_HOTKEY_QUERY
      HPWMI_FEATURE2_QUERY
      HPWMI_WIRELESS2_QUERY
      HPWMI_POSTCODEERROR_QUERY
      HPWMI_THERMAL_PROFILE_QUERY
      HPWMI_FAN_SPEED_MAX_GET_QUERY
      
      Invoking those WMI commands with an input buffer size greater
      than zero will cause error 0x05 to be returned.
      
      All WMI commands executed by the driver were reviewed and changes
      were made to ensure the expected input and output buffer size match
      the WMI specification.
      
      Changes were validated on a HP ZBook Workstation notebook,
      HP EliteBook x360, and HP EliteBook 850 G8.  Additional
      validation was included in the test process to ensure no other
      commands were incorrectly handled.
      Signed-off-by: default avatarJorge Lopez <jorge.lopez2@hp.com>
      Link: https://lore.kernel.org/r/20220310210853.28367-4-jorge.lopez2@hp.comReviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
      Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
      be9d73e6
    • Jorge Lopez's avatar
      platform/x86: hp-wmi: Fix SW_TABLET_MODE detection method · 520ee4ea
      Jorge Lopez authored
      The purpose of this patch is to introduce a fix and removal of the
      current hack when determining tablet mode status.
      
      Determining the tablet mode status requires reading Byte 0 bit 2 as
      reported by HPWMI_HARDWARE_QUERY.  The investigation identified the
      failure was rooted in two areas: HPWMI_HARDWARE_QUERY failure (0x05)
      and reading Byte 0, bit 2 only to determine the table mode status.
      HPWMI_HARDWARE_QUERY WMI failure also rendered the dock state value
      invalid.
      
      The latest changes use SMBIOS Type 3 (chassis type) and WMI Command
      0x40 (device_mode_status) information to determine if the device is
      in tablet mode or not.
      
      hp_wmi_hw_state function was split into two functions;
      hp_wmi_get_dock_state and hp_wmi_get_tablet_mode.  The new functions
      separate how dock_state and tablet_mode is handled in a cleaner
      manner.
      
      All changes were validated on a HP ZBook Workstation notebook,
      HP EliteBook x360, and HP EliteBook 850 G8.
      Signed-off-by: default avatarJorge Lopez <jorge.lopez2@hp.com>
      Link: https://lore.kernel.org/r/20220310210853.28367-3-jorge.lopez2@hp.comReviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
      Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
      520ee4ea
    • Jorge Lopez's avatar
      platform/x86: hp-wmi: Fix hp_wmi_read_int() reporting error (0x05) · 12b19f14
      Jorge Lopez authored
      The purpose of this patch is to introduce a fix to hp_wmi_read_int()
      and eliminate failure error (0x05). Several WMI queries leverage
      hp_wmi_read_int() to read their data and were failing with error 0x05.
      
      HPWMI_DISPLAY_QUERY
      HPWMI_HDDTEMP_QUERY
      HPWMI_ALS_QUERY
      HPWMI_HARDWARE_QUERY
      HPWMI_WIRELESS_QUERY
      HPWMI_POSTCODEERROR_QUERY
      
      The failure occurs because hp_wmi_read_int() calls
      hp_wmi_perform_query() with input parameter of size greater than zero.
      Invoking those WMI commands with an input buffer size greater than
      zero causes the command to be rejected and error 0x05 be returned.
      
      All changes were validated on a HP ZBook Workstation notebook,
      HP EliteBook x360, and HP EliteBook 850 G8.
      Signed-off-by: default avatarJorge Lopez <jorge.lopez2@hp.com>
      Link: https://lore.kernel.org/r/20220310210853.28367-2-jorge.lopez2@hp.comReviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
      Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
      12b19f14
  5. 10 Mar, 2022 1 commit
  6. 09 Mar, 2022 4 commits
  7. 08 Mar, 2022 3 commits
  8. 02 Mar, 2022 15 commits
  9. 24 Feb, 2022 1 commit
  10. 23 Feb, 2022 1 commit
  11. 21 Feb, 2022 1 commit
  12. 17 Feb, 2022 1 commit