- 01 Aug, 2017 15 commits
-
-
David S. Miller authored
Julia Lawall says: ==================== Revert "ipv6: constify inet6_protocol structures" inet6_add_protocol and inet6_del_protocol include casts that remove the effect of the const annotation on their parameter, leading to possible runtime crashes. ==================== Signed-off-by:David S. Miller <davem@davemloft.net>
-
Julia Lawall authored
This reverts commit d04916a4. inet6_add_protocol and inet6_del_protocol include casts that remove the effect of the const annotation on their parameter, leading to possible runtime crashes. Reported-by:
Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by:
Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by:
-
Julia Lawall authored
This reverts commit 3a3a4e30. inet6_add_protocol and inet6_del_protocol include casts that remove the effect of the const annotation on their parameter, leading to possible runtime crashes. Reported-by:
-
Jakub Sitnicki authored
There is no need to go through sk->sk_net to access the net namespace and its sysctl variables because we allocate the sock and initialize sk_net just a few lines earlier in the same routine. Signed-off-by:
Jakub Sitnicki <jkbs@redhat.com> Signed-off-by:
-
David S. Miller authored
Andrew Lunn says: ==================== More Marvell PHY refactoring and cleanup Consolidate more duplicated code into helpers, make use of core helpers, move code into a helper for later adding functionality to add marvell PHYs, etc. ==================== Signed-off-by: -
Andrew Lunn authored
The 1116r has code to set downshift. Refactor this into a helper, so in future other marvell PHYs can use it. Signed-off-by:
Andrew Lunn <andrew@lunn.ch> Signed-off-by:
-
Andrew Lunn authored
Some of the init functions unilaterally enable set auto cross over without using the helper. Make use of the helper, and respect the phydev MDI configuration. Clean up the #define used while setting polarity, and the other functions of the bits in the register. Signed-off-by:
-
Andrew Lunn authored
Turns out that MII_M1116R_CONTROL_REG_MAC is the same as MII_88E1121_PHY_MSCR_REG. Refactor the code to set the RGMII delays into a shared helper. Signed-off-by:
-
Andrew Lunn authored
The same code is repeated a few times. Refactor into a helped. Signed-off-by:
-
Andrew Lunn authored
The same code is repeated for different PHY versions. Put it into a help and call when needed. Signed-off-by:
-
Andrew Lunn authored
Rather than using an open coded equivalent, use the core genphy_soft_reset() function. Signed-off-by:
-
Andrew Lunn authored
Convert spaces to tabs where appropriate, and fix up some otherwise odd indentation. Signed-off-by:
-
Florian Fainelli authored
The driver needs CONFIG_HAS_IOMEM and OF to be functional, but we still let it build with COMPILE_TEST. This fixes the unmet dependency after selecting MDIO_BCM_UNIMAC in commit mentioned below: warning: (NET_DSA_BCM_SF2 && BCMGENET) selects MDIO_BCM_UNIMAC which has unmet direct dependencies (NETDEVICES && MDIO_DEVICE && HAS_IOMEM && OF_MDIO) Fixes: 9a4e7969 ("net: bcmgenet: utilize generic Broadcom UniMAC MDIO controller driver") Signed-off-by:
Florian Fainelli <f.fainelli@gmail.com> Signed-off-by:
-
Wei Wang authored
Add the following stats into SCM_TIMESTAMPING_OPT_STATS control msg: TCP_NLA_PACING_RATE TCP_NLA_DELIVERY_RATE TCP_NLA_SND_CWND TCP_NLA_REORDERING TCP_NLA_MIN_RTT TCP_NLA_RECUR_RETRANS TCP_NLA_DELIVERY_RATE_APP_LMT Signed-off-by:Wei Wang <weiwan@google.com> Acked-by:
Yuchung Cheng <ycheng@google.com> Acked-by:
Soheil Hassas Yeganeh <soheil@google.com> Signed-off-by:
-
Wei Wang authored
Refactor the code to extract the function to compute delivery rate. This function will be used in later commit. Signed-off-by:
-
- 31 Jul, 2017 25 commits
-
-
Marc Gonzalez authored
In the current code, old and new PHY states are always logged. >From now on, log only PHY state transitions. Signed-off-by:
Marc Gonzalez <marc_gonzalez@sigmadesigns.com> Signed-off-by:
-
David S. Miller authored
Jiri Pirko says: ==================== mlxsw: Various small fixes This patch series is to contribute several fixes for nits that I noticed while working on mlxsw. The changes range from typo fixes to local improvements of the code and have little in common besides being small in scope. ==================== Signed-off-by: -
Petr Machata authored
Express the same logic more succinctly. Signed-off-by:
Petr Machata <petrm@mellanox.com> Reviewed-by:
Ido Schimmel <idosch@mellanox.com> Signed-off-by:
Jiri Pirko <jiri@mellanox.com> Signed-off-by:
-
Petr Machata authored
Prefer logical operator that expresses the intent to bitwise one that happens to give the same result. Signed-off-by:
-
Petr Machata authored
Signed-off-by:
-
Petr Machata authored
This renames IP2ME-specific registers reg_ralue_v and reg_ralue_tunnel_ptr to reg_ralue_ip2me_*. Signed-off-by:
-
Petr Machata authored
The comments really belong to the individual enumerators. The comment at the register should instead reference the enum. Signed-off-by:
-
Petr Machata authored
Signed-off-by:
-
Petr Machata authored
Signed-off-by:
-
Petr Machata authored
Signed-off-by:
-
David S. Miller authored
Florian Fainelli says: ==================== net: bcmgenet: utilize MDIO unimac driver This patch series migrates the Broadcom GENET driver to use the mdio-bcm-unimac driver. This MDIO HW is the same as the one GENET internally embedds, yet for historical reasons the two drivers lived their own lives. Because of the GENET interrupt situation, we let it specify how it wants to signal MDIO operations completion using its driver-private waitqueue. The diffstat is not super impressive, but it's still negative! This would make it easier in the future to absorb possible workarounds/bugs/features within the same location. This was tested on BCM7260 (GENETv5, single instance), BCM7439 (GENETv4, triple instance) and BCM7445 (bcm_sf2 + mdio-bcm-unimac). We also now have a nice /proc/iomem output: f0b00000-f0b0fc4b : /rdb/ethernet@f0b00000 f0b00e14-f0b00e1c : unimac-mdio.0 f0b20000-f0b2fc4b : /rdb/ethernet@f0b20000 f0b20e14-f0b20e1c : unimac-mdio.1 f0b40000-f0b4fc4b : /rdb/ethernet@f0b40000 f0b40e14-f0b40e1c : unimac-mdio.2 ==================== Signed-off-by: -
Florian Fainelli authored
bcmgenet_mii_init() has an error path which is strictly identical to the unwinding that bcmgenet_mii_exit() does, so have bcmgenet_mii_init() utilize bcmgenet_mii_exit() for that. Signed-off-by:
-
Florian Fainelli authored
Now that we have fully migrated to the mdio-bcm-unimac driver, drop the legacy MDIO bus code which did duplicate a fair amount of code. Signed-off-by:
-
Florian Fainelli authored
Update the GENET driver to register an UniMAC MDIO bus controller for the GENET internal MDIO bus, update the platform data code to attach the PHY to the correct MDIO bus controller. The Device Tree portion of the code is mostly left unmodified since the lookup/binding is done via phandles and Device Tree nodes which are much more flexible in locating and binding PHYs to their respective MDIO bus controllers. Signed-off-by:
-
Florian Fainelli authored
In preparation for having the bcmgenet driver migrate over the mdio-bcm-unimac driver, add a platform data structure which allows passing integrating specific details like bus name, wait function to complete MDIO operations and PHY mask. We also define what the platform device name contract is by defining UNIMAC_MDIO_DRV_NAME and moving it to the platform_data header. Signed-off-by:
-
Florian Fainelli authored
In order to be stricly identical to what bcmgenet does, add a debug print when a PHY workaround during bus->reset() is executed. Preliminary change to moving bcmgenet towards mdio-bcm-unimac. Signed-off-by:
-
Florian Fainelli authored
In preparation for having multiple GENET instances in a system (up to 3), make sure that we do include the bus instance number in the name of the MDIO bus such that we change it from "unimac-mdio" to "unimac-mdio-0" for instance. So far, the only user of this driver is using Device Tree, which uses a lookup/parenting based technique to map PHY devices to their respective MDIO bus controllers, hence causing no additional changes. Signed-off-by:
-
Florian Fainelli authored
Factor the code that does the busy polling on the MDIO_BUSY bit since we will have different code-paths for for completion depending on whether we are using interrupts or polling. Signed-off-by:
-
David S. Miller authored
Florian Westphal says: ==================== tcp: remove prequeue and header prediction During a hallway discussion with Eric Dumazet at Netdev 1.2 in Tokyo some maybe-not-so-useful-anymore TCP stack features came up, among these header prediction and prequeueing. In brief, TCP prequeue assumes a single-process-blocking-read design, which is not that common anymore. The most frequently used high-performance networking program that is an excellent fit for these features is netperf. The idea behind prequeueing is to move part of tcp processing, including retransmit queue cleaning, to process context. With (e)poll designs, prequeue is always skipped, so for such programs this is dead-code removal. Header prediction is also less useful nowadays. For packet trains, GRO will do packet aggregation so we do not get the per-packet benefit that this had before GRO anymore. Because of SACK, header prediction also will be ineffective once a connection suffers even light packet losses. code removal aside, after this change processing always occurs in BH context, this allows to experiment e.g. with doing bulk freeing of skb heads when incoming ACKs clean packets from the retransmit queue. There are no changes since the RFC, except in last patch (i missed another no-longer-used mib counter). I also edited a few commit messages. ==================== Signed-off-by: -
Florian Westphal authored
was used by tcp prequeue and header prediction. TCPFORWARDRETRANS use was removed in january. Signed-off-by:
Florian Westphal <fw@strlen.de> Signed-off-by:
-
Florian Westphal authored
re-indent tcp_ack, and remove CA_ACK_SLOWPATH; it is always set now. Signed-off-by:
-
Florian Westphal authored
Like prequeue, I am not sure this is overly useful nowadays. If we receive a train of packets, GRO will aggregate them if the headers are the same (HP predates GRO by several years) so we don't get a per-packet benefit, only a per-aggregated-packet one. Signed-off-by:
-
Florian Westphal authored
Was only checked by the removed prequeue code. Signed-off-by:
-
Florian Westphal authored
These two branches are now always true, remove the conditional. objdiff shows no changes. Signed-off-by:
-
Florian Westphal authored
prequeue is a tcp receive optimization that moves part of rx processing from bh to process context. This only works if the socket being processed belongs to a process that is blocked in recv on that socket. In practice, this doesn't happen anymore that often because nowadays servers tend to use an event driven (epoll) model. Even normal client applications (web browsers) commonly use many tcp connections in parallel. This has measureable impact only in netperf (which uses plain recv and thus allows prequeue use) from host to locally running vm (~4%), however, there were no changes when using netperf between two physical hosts with ixgbe interfaces. Signed-off-by:
-
