1. 28 Jan, 2019 8 commits
    • Linus Walleij's avatar
      Merge tag 'sh-pfc-for-v5.1-tag1' of... · c6868f7c
      Linus Walleij authored
      Merge tag 'sh-pfc-for-v5.1-tag1' of git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers into devel
      
      pinctrl: sh-pfc: Updates for v5.1
      
        - Add TMU pin groups on R-Car E3,
        - Miscellaneous fixes and cleanups.
      c6868f7c
    • YueHaibing's avatar
      pinctrl: sirf: drop pointless static qualifier in sirfsoc_gpio_probe · 4f41e66c
      YueHaibing authored
      There is no need to have the 'sgpio' variable static since new
      value always be assigned before use it.
      Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
      Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      4f41e66c
    • YueHaibing's avatar
      pinctrl: ti-iodelay: Fix platform_no_drv_owner.cocci warnings · ff54d82b
      YueHaibing authored
      Remove .owner field if calls are used which set it automatically
      Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
      Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
      Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      ff54d82b
    • Vladimir Zapolskiy's avatar
      pinctrl: remove unused 'pinconf-config' debugfs interface · e7333903
      Vladimir Zapolskiy authored
      The main goal of the change is to remove .pin_config_dbg_parse_modify
      callback before a driver with its support appears. So far the in-kernel
      interface did not attract any users since its introduction 5 years ago.
      
      Originally .pin_config_dbg_parse_modify callback and the associated
      'pinconf-config' debugfs file were introduced in commit f07512e6
      ("pinctrl/pinconfig: add debug interface"), a short description of
      'pinconf-config' usage for debugging can be expressed this way:
      
      Write to 'pinconf-config' (see pinconf_dbg_config_write() function):
      
      % echo -n modify $map_type $device_name $state_name $pin_name $config > \
      	/sys/kernel/debug/pinctrl/$pinctrl/pinconf-config
      
      It supposes to update a global (therefore single!) 'pinconf_dbg_conf'
      variable with an alternative setting, the arguments should match
      an existing pinconf device and some registered pinctrl mapping 'map':
      
      * $map_type is either 'config_pin' or 'config_group', it should match
        'map->type' value of PIN_MAP_TYPE_CONFIGS_PIN or
         PIN_MAP_TYPE_CONFIGS_GROUP accordingly,
      * $device_name should match 'map->dev_name' string value,
      * $state_name should match 'map->name' string value,
      * $pin_name should match 'map->data.configs.group_or_pin' string value,
      
      If all above has matched, then $config is a new value to be set by calling
      pinconfops->pin_config_dbg_parse_modify(pctldev, config, matched_config).
      
      After a successful write into 'pinconf-config' a user can read the file
      to get information about that single modified pin configuration.
      
      The fact is .pin_config_dbg_parse_modify callback has never been defined
      in 'struct pinconf_ops' of any pinconf driver, thus an actual modification
      of a pin or group state on any present pinconf controller does not happen,
      and it declares that all related code is no more than dead code.
      
      I discovered the issue while attempting to add .pin_config_dbg_parse_modify
      support in some drivers and found that too short 'MAX_NAME_LEN' set by
      
        drivers/pinctrl/pinconf.c:372:#define MAX_NAME_LEN 15
      
      is practically insufficient to store a regular pinctrl device name,
      which are like 'e6060000.pin-controller-sh-pfc' or pin names like
      'MX6QDL_PAD_ENET_REF_CLK', thus it is another indicator that the code
      is barely usable, insufficiently tested and unprepossessing.
      
      Of course it might be possible to increase MAX_NAME_LEN, and then add
      .pin_config_dbg_parse_modify callbacks to the drivers, but the whole
      idea of such a limited debug option looks inviable. A more flexible
      way to functionally substitute the original approach is to implicitly
      or explicitly use pinctrl_select_state() function whenever needed.
      Signed-off-by: default avatarVladimir Zapolskiy <vz@mleia.com>
      Cc: Laurent Meunier <laurent.meunier@st.com>
      Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
      Cc: Russell King <linux@arm.linux.org.uk>
      Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      e7333903
    • Vladimir Zapolskiy's avatar
      pinctrl: remove pinctrl/machine.h inclusion from pinctrl/pinconf.h · 87eff9af
      Vladimir Zapolskiy authored
      The change adds explicit inclusion of linux/pinctrl/machine.h header
      to the only needed pinctrl-madera-core.c file, and therefore inclusion
      of pinctrl/machine.h header from pinctrl/pinconf.h can be removed.
      
      The change is preparatory to a follow-up reversal of commit f07512e6
      ("pinctrl/pinconfig: add debug interface").
      Signed-off-by: default avatarVladimir Zapolskiy <vz@mleia.com>
      Cc: Charles Keepax <ckeepax@opensource.cirrus.com>
      Reviewed-by Richard Fitzgerald <rf@opensource.cirrus.com>
      Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      87eff9af
    • Linus Walleij's avatar
    • Bai Ping's avatar
      dt-bindings: imx: Add pinctrl binding doc for imx8mm · c1c9d413
      Bai Ping authored
      Add binding doc imx8mm pinctrl driver.
      Signed-off-by: default avatarBai Ping <ping.bai@nxp.com>
      Acked-by: default avatarAisheng Dong <aisheng.dong@nxp.com>
      Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      c1c9d413
    • Ramon Fried's avatar
      pinctrl.txt: Remove outdated information · 12742835
      Ramon Fried authored
      Returning -EAGAIN is no longer supported by pin_config_group_set()
      since ad42fc6c ("pinctrl: rip out the direct pinconf API")
      
      Remove the relevant section from the documentation.
      Signed-off-by: default avatarRamon Fried <ramon.fried@linux.intel.com>
      Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      12742835
  2. 24 Jan, 2019 12 commits
  3. 22 Jan, 2019 1 commit
  4. 21 Jan, 2019 19 commits