1. 13 Apr, 2015 2 commits
    • Kristian Nielsen's avatar
      MDEV-7936: Assertion `!table || table->in_use == _current_thd()' failed on... · 60d094ae
      Kristian Nielsen authored
      MDEV-7936: Assertion `!table || table->in_use == _current_thd()' failed on parallel replication in optimistic mode
      
      Make sure that in parallel replication, we execute wait_for_prior_commit()
      before setting table->in_use for a temporary table. Otherwise we can end up
      with two parallel replication worker threads competing with each other for
      use of a temporary table.
      
      Re-factor the use of find_temporary_table() to be able to handle errors
      in the caller (as wait_for_prior_commit() can return error in case of
      deadlock kill).
      60d094ae
    • Kristian Nielsen's avatar
      MDEV-7668: Intermediate master groups CREATE TEMPORARY with INSERT, causing... · c47fe0e9
      Kristian Nielsen authored
      MDEV-7668: Intermediate master groups CREATE TEMPORARY with INSERT, causing parallel replication failure
      
      [This commit cherry-picked to be able to merge MDEV-7936, of which it
      is a pre-requisite, into both 10.0 and 10.1.]
      
      Parallel replication depends on locking (table locks, row locks, etc.) to
      prevent two conflicting transactions from running and committing in parallel.
      But temporary tables are designed to be visible only to one thread, and have
      no such locking.
      
      In the concrete issue, an intermediate master could commit a CREATE TEMPORARY
      TABLE in the same group commit as in INSERT into that table. Thus, a
      lower-level master could attempt to run them in parallel and get an error.
      
      More generally, we need protection from parallel replication trying to run
      transactions in parallel that access a common temporary table.
      
      This patch simply causes use of a temporary table from parallel replication
      to wait for all previous transactions to commit, serialising the replication
      at that point.
      
      (A more fine-grained locking could be added later, possibly. However,
      using temporary tables in statement-based replication is in any case
      normally undesirable; for example a restart of the server will lose
      temporary tables and can break replication).
      
      Note that row-based replication is not affected, as it does not do any
      temporary tables on the slave-side.
      
      This patch also cleans up the locking around protecting the list of
      temporary tables in Relay_log_info. This used to take the
      rli->data_lock at the end of every statement, which is very bad for
      concurrency. With this patch, the lock is not taken unless temporary
      tables (with statement-based binlogging) are in use on the slave.
      c47fe0e9
  2. 09 Apr, 2015 1 commit
    • Kristian Nielsen's avatar
      MDEV-7940: Sporadic failure in rpl.rpl_gtid_until · 15a2b5aa
      Kristian Nielsen authored
      Fix a race in the test case. When we do start_slave.inc immediately
      followed by stop_slave.inc, it is possible to kill the IO thread while
      it is still running inside get_master_version_and_clock(), and this
      gives warnings in the error log that cause the test to fail.
      15a2b5aa
  3. 08 Apr, 2015 1 commit
  4. 06 Mar, 2015 7 commits
  5. 05 Mar, 2015 3 commits
  6. 04 Mar, 2015 3 commits
    • Kristian Nielsen's avatar
      3ef0b9b2
    • Kristian Nielsen's avatar
      MDEV-6403: Temporary tables lost at STOP SLAVE in GTID mode if master has not... · 78c74dbe
      Kristian Nielsen authored
      MDEV-6403: Temporary tables lost at STOP SLAVE in GTID mode if master has not rotated binlog since restart
      
      The binlog contains specially marked format description events to mark
      when a master restart happened (which could have caused temporary
      tables to be silently dropped). Such events also cause slave to close
      temporary tables.
      
      However, there was a bug that if after this, slave re-connects to the
      master in GTID mode, the master can send an old format description
      event again. If temporary tables are closed when such event is seen
      for the second time, it might drop temporary tables created after that
      event, and cause replication failure.
      
      With this patch, the restart flag of the format description event is
      cleared by the master when it is sent to the slave in a subsequent
      connection, to avoid the errorneous temp table close.
      78c74dbe
    • Kristian Nielsen's avatar
      MDEV-6589: Incorrect relay log start position when restarting SQL thread after... · ad0d203f
      Kristian Nielsen authored
      MDEV-6589: Incorrect relay log start position when restarting SQL thread after error in parallel replication
      
      The problem occurs in parallel replication in GTID mode, when we are using
      multiple replication domains. In this case, if the SQL thread stops, the
      slave GTID position may refer to a different point in the relay log for each
      domain.
      
      The bug was that when the SQL thread was stopped and restarted (but the IO
      thread was kept running), the SQL thread would resume applying the relay log
      from the point of the most advanced replication domain, silently skipping all
      earlier events within other domains. This caused replication corruption.
      
      This patch solves the problem by storing, when the SQL thread stops with
      multiple parallel replication domains active, the current GTID
      position. Additionally, the current position in the relay logs is moved back
      to a point known to be earlier than the current position of any replication
      domain. Then when the SQL thread restarts from the earlier position, GTIDs
      encountered are compared against the stored GTID position. Any GTID that was
      already applied before the stop is skipped to avoid duplicate apply.
      
      This patch should have no effect if multi-domain GTID parallel replication is
      not used. Similarly, if both SQL and IO thread are stopped and restarted, the
      patch has no effect, as in this case the existing relay logs are removed and
      re-fetched from the master at the current global @@gtid_slave_pos.
      ad0d203f
  7. 02 Mar, 2015 2 commits
  8. 01 Mar, 2015 4 commits
    • Olivier Bertrand's avatar
      - Make json_udf test work on Windows · b9a9b82f
      Olivier Bertrand authored
      modified:
        storage/connect/mysql-test/connect/t/json_udf.inc
      b9a9b82f
    • Olivier Bertrand's avatar
      - Making json_udf test working on linux · 5f4909b3
      Olivier Bertrand authored
      added:
        storage/connect/mysql-test/connect/t/json_udf.inc
      modified:
        storage/connect/mysql-test/connect/r/json_udf.result
        storage/connect/mysql-test/connect/t/json_udf.test
      5f4909b3
    • Olivier Bertrand's avatar
      - Remove a signed/unsigned warning. · 34c89597
      Olivier Bertrand authored
      modified:
        storage/connect/jsonudf.cpp
      34c89597
    • Olivier Bertrand's avatar
      - Fix crash when Json_Value was called without arguments. · 5c8862ee
      Olivier Bertrand authored
        Correct memory calculation in Serialize.
        Correct some UDF's messages.
        Add and modify the json tests
      removed:
        storage/connect/mysql-test/connect/std_data/biblio.jsn
        storage/connect/mysql-test/connect/std_data/expense.jsn
        storage/connect/mysql-test/connect/std_data/mulexp3.jsn
        storage/connect/mysql-test/connect/std_data/mulexp4.jsn
        storage/connect/mysql-test/connect/std_data/mulexp5.jsn
      added:
        storage/connect/mysql-test/connect/r/json_udf.result
        storage/connect/mysql-test/connect/std_data/biblio.json
        storage/connect/mysql-test/connect/std_data/expense.json
        storage/connect/mysql-test/connect/std_data/mulexp3.json
        storage/connect/mysql-test/connect/std_data/mulexp4.json
        storage/connect/mysql-test/connect/std_data/mulexp5.json
        storage/connect/mysql-test/connect/t/json_udf.test
      modified:
        storage/connect/json.cpp
        storage/connect/jsonudf.cpp
        storage/connect/mysql-test/connect/r/json.result
        storage/connect/mysql-test/connect/t/json.test
      5c8862ee
  9. 28 Feb, 2015 2 commits
    • Olivier Bertrand's avatar
      - Implement random access to ODBC tables · d862d7c0
      Olivier Bertrand authored
      modified:
        storage/connect/odbconn.cpp
        storage/connect/odbconn.h
      
      - Fix get proper length of ODBC DECIMAL column in discovery
      modified:
        storage/connect/ha_connect.cc
        storage/connect/mysql-test/connect/r/odbc_oracle.result
      
      - Implement random access to JSON tables
      modified:
        storage/connect/tabjson.cpp
        storage/connect/tabjson.h
      
      - Fix MDEV-7636
      modified:
        storage/connect/tabutil.cpp
      d862d7c0
    • Vicențiu Ciorbaru's avatar
      MDEV-6838: Using too big key for internal temp tables · 45b6edb1
      Vicențiu Ciorbaru authored
      This bug manifests due to wrong computation and evaluation of
      keyinfo->key_length. The issues were:
      * Using table->file->max_key_length() as an absolute value that must not be
        reached for a key, while it represents the maximum number of bytes
        possible for a table key.
      * Incorrectly computing the keyinfo->key_length size during
        KEY_PART_INFO creation. The metadata information regarding the key
        such the field length (for strings) was added twice.
      45b6edb1
  10. 27 Feb, 2015 2 commits
  11. 26 Feb, 2015 1 commit
  12. 25 Feb, 2015 5 commits
  13. 24 Feb, 2015 7 commits