1. 31 May, 2006 1 commit
    • unknown's avatar
      Bug#18462: mysqldump does not dump view structures correctly · c69ba255
      unknown authored
      (The above problem only occurs with -T -- create a separate file for
      each table / view.) This ChangeSet results in correct output of view-
      information while omitting the information for the view's stand-in
      table. The rationale is that with -T, the user is likely interested
      in transferring part of a database, not the db in its entirety (that
      would be difficult as replay order is obscure, the files being named
      for the table/view they contain rather than getting a sequence number).
      
      
      client/mysqldump.c:
        Added missing fclose(). Before, a view's stand-in table would get
        dumped in get_table_structure(), and the file would remain open.
        get_view_structure() would re-open the same file and write to it,
        resulting in garbage.  The way we handle it now, the table-struct
        gets closed, then the opening of the view-struct (same name)
        overwrites it. (The SQL for the view drop-if-exists the table,
        anyway.) If this were not desired and we wanted SQL for the views
        that contains the create for the stand-in table, we'd hand a mode
        to open_sql_file_for_table(), which would feature O_APPEND in
        get_view_structure(), but not in get_table_structure().
      mysql-test/r/mysqldump.result:
        prove mysqldump -T (each item gets its own file) dumps views correctly
      mysql-test/t/mysqldump.test:
        prove mysqldump -T (each item gets its own file) dumps views correctly
      c69ba255
  2. 24 May, 2006 1 commit
  3. 12 May, 2006 2 commits
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/my50-bug19709 · 42c47bcb
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint
      
      
      42c47bcb
    • unknown's avatar
      Bug#19709 rpl_tmporary fails on powermacg5 · acf18799
      unknown authored
       - Don't kill the active connection to the server, instead read 
         the connection id, switch connection and kill the first one from there.
      
      
      mysql-test/r/rpl_temporary.result:
        Update test result
      mysql-test/t/rpl_temporary.test:
        Don't kill our own connection to the server as the result code differs depending 
        on platform.
      acf18799
  4. 11 May, 2006 1 commit
  5. 10 May, 2006 14 commits
  6. 09 May, 2006 12 commits
    • unknown's avatar
      Merge xiphis.org:/home/antony/work2/p1-bug10952.1 · dac69dd4
      unknown authored
      into  xiphis.org:/home/antony/work2/mysql-5.0-engines-merge
      
      
      dac69dd4
    • unknown's avatar
      Merge acurtis@bk-internal:/home/bk/mysql-5.0-engines · f61748b7
      unknown authored
      into  xiphis.org:/home/antony/work2/p1-bug10952.1
      
      
      sql/handler.h:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      f61748b7
    • unknown's avatar
      bug#10952 · 6116d017
      unknown authored
        "alter table from MyISAM to MERGE lost data without errors and warnings"
        Add new handlerton flag which prevent user from altering table storage
        engine to storage engines which would lose data. Both 'blackhole' and 
        'merge' are marked with the new flag.
        Tests included.
      
      
      mysql-test/r/blackhole.result:
        test for bug#10952
      mysql-test/r/merge.result:
        test for bug#10952
      mysql-test/t/blackhole.test:
        test for bug#10952
      mysql-test/t/merge.test:
        test for bug#10952
      sql/ha_blackhole.cc:
        Bug#10952
          shouldn't be able to alter a table into a blackhole
      sql/ha_myisammrg.cc:
        Bug#10952
          shouldn't be able to alter a table into a merge
      sql/handler.h:
        Bug#10952
          new handlerton flag
      sql/sql_table.cc:
        Bug#10952
          If alter is changing engine, check if new engine allows creating table
          via ALTER statement.
      6116d017
    • unknown's avatar
      BUG#18068: SELECT DISTINCT (with duplicates and covering index) · baae7a97
      unknown authored
      When converting DISTINCT to GROUP BY where the columns are from the covering
      index and they are quoted twice in the SELECT list the optimizer is creating
      improper processing sequence. This is because of the fact that the columns
      of the covering index are not recognized as such and treated as non-index
      columns.
      
      Generally speaking duplicate columns can safely be removed from the GROUP
      BY/DISTINCT list because this will not add or remove new rows in the
      resulting set. Duplicates can be removed even if they are not consecutive
      (as is the case for ORDER BY, where the duplicate columns can be removed
      only if they are consecutive).
      
      So we can safely transform "SELECT DISTINCT a,a FROM ... ORDER BY a" to
      "SELECT a,a FROM ... GROUP BY a ORDER BY a" instead of 
      "SELECT a,a FROM .. GROUP BY a,a ORDER BY a". We can even transform 
      "SELECT DISTINCT a,b,a FROM ... ORDER BY a,b" to
      "SELECT a,b,a FROM ... GROUP BY a,b ORDER BY a,b".
      
      The fix to this bug consists of checking for duplicate columns in the SELECT
      list when constructing the GROUP BY list in transforming DISTINCT to GROUP
      BY and skipping the ones that are already in.
      
      
      mysql-test/r/distinct.result:
        test case for the bug without loose index scan
      mysql-test/r/group_min_max.result:
        test case for the bug
      mysql-test/t/distinct.test:
        test case for the bug without loose index scan
      mysql-test/t/group_min_max.test:
        test case for the bug
      sql/sql_select.cc:
        duplicates check and removal
      baae7a97
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-5.0 · 3923cfd9
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint
      
      
      3923cfd9
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-5.0 · 2d54e692
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint
      
      
      2d54e692
    • unknown's avatar
      Merge mskold@bk-internal.mysql.com:/home/bk/mysql-5.0 · d6c2616c
      unknown authored
      into  mysql.com:/home/marty/MySQL/mysql-5.0
      
      
      d6c2616c
    • unknown's avatar
      Merge mysql.com:/home/marty/MySQL/mysql-4.1 · 06d0f3fb
      unknown authored
      into  mysql.com:/home/marty/MySQL/mysql-5.0
      
      
      ndb/src/kernel/blocks/dbtc/DbtcInit.cpp:
        Auto merged
      06d0f3fb
    • unknown's avatar
    • unknown's avatar
      BUG#16803 "ln -s /dev/null .mysql_history" doesn't work! · 4a25f400
      unknown authored
       - Add a check to see if the .mysql_history file a symlink to /dev/null 
         and in such case, skip reading and writing to it. 
           
      
      
      client/mysql.cc:
        Add check to detect if the "mysql_history" file is a symlink to /dev/null.
        In that case, don't create histfile variable.
        That will make read_history and write_history to be skipped.
      4a25f400
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint · c7e2527c
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      
      sql/item_func.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      c7e2527c
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-5.0 · 0d3825a6
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint
      
      
      client/mysqltest.c:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      0d3825a6
  7. 08 May, 2006 6 commits
    • unknown's avatar
      No commit message · 42f20d75
      unknown authored
      No commit message
      42f20d75
    • unknown's avatar
      Merge mysql.com:/Users/kent/mysql/bk/mysql-5.0-release · db122e94
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-5.0-new
      
      
      configure.in:
        Auto merged
      db122e94
    • unknown's avatar
      Remove valgrind and compiler warnings · bc324937
      unknown authored
      Add function 'vio_end' that will cleanup resources allocated by vio and the components it uses.
      
      
      include/violite.h:
        Import patch warnings.patch
      libmysql/libmysql.c:
        Import patch warnings.patch
      sql/mysqld.cc:
        Import patch warnings.patch
      vio/test-ssl.c:
        Import patch warnings.patch
      vio/test-sslclient.c:
        Import patch warnings.patch
      vio/test-sslserver.c:
        Import patch warnings.patch
      vio/vio.c:
        Import patch warnings.patch
      vio/viosslfactories.c:
        Import patch warnings.patch
      bc324937
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/my50-maint-bug18474 · c593d1f1
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint
      
      
      c593d1f1
    • unknown's avatar
      Merge 192.168.0.20:mysql/my50-maint-yassl · fa91c7bc
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0-maint
      
      
      extra/yassl/src/ssl.cpp:
        Auto merged
      extra/yassl/taocrypt/src/make.bat:
        Auto merged
      extra/yassl/testsuite/test.hpp:
        Auto merged
      fa91c7bc
    • unknown's avatar
      Bug#19263: variables.test doesn't clean up after itself · 1a97d50b
      unknown authored
      save global server variables before fiddling with them and restore them later
      
      
      BitKeeper/deleted/.del-variables-master.opt~8a6cb6459b54545:
        Delete: mysql-test/t/variables-master.opt
      mysql-test/r/variables.result:
        save and restore globals
      mysql-test/t/variables.test:
        save and restore globals
      1a97d50b
  8. 07 May, 2006 3 commits
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-5.0 · 47302570
      unknown authored
      into  rurik.mysql.com:/home/igor/mysql-5.0
      
      
      mysql-test/r/rpl_user_variables.result:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/t/rpl_user_variables.test:
        Manual merge
      47302570
    • unknown's avatar
      Post-merge fixes. · 5aa69d34
      unknown authored
      5aa69d34
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/dev/mysql-4.1-0 · 30a7094f
      unknown authored
      into  rurik.mysql.com:/home/igor/dev/mysql-5.0-0
      
      
      mysql-test/r/having.result:
        Auto merged
      mysql-test/t/having.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      mysql-test/r/rpl_user_variables.result:
        Manual merge
      mysql-test/t/rpl_user_variables.test:
        Manual merge
      sql/sql_lex.cc:
        Manual merge
      sql/sql_prepare.cc:
        Manual merge
      sql/sql_select.cc:
        Manual merge
      30a7094f