No L2CAP or RFCOMM stats doesn't imply no support for Bluetooth; merely a
protocol missing.

An address type field was added, messing up our l2cap status parsing.

When an interface has transferred exbibytes
(> 0.8 EiB, i.e. > 819 PiB) of traffic,
the short display is rounded incorrectly.

For example:
bytes 2154408931384050514 (275.0 PiB)
while correct is (1913.4 PiB)

This happens because we times the rx/tx bytes values by 10,
then calculate the short version from that result:

lib/interface.c:ife_print_long()

tx = ptr->stats.tx_bytes;
short_tx = tx * 10;
if (tx > 1125899906842624ull) {
  short_tx /= 1125899906842624ull;
  Text = "PiB";
}

But multiplying anything more than 819 PiB by 10 overflows a ull
which is a uint64_t (max value of 9223372036854775807).

We'll never get accuracy over 8192 PiB (2^64) when using ull,
but we can at least correctly handle values between 819 - 8192 PiB.

The reason is that debugfs is accessible only by root user:
_PATH_SYS_BLUETOOTH_L2CAP  /sys/kernel/debug/bluetooth/l2cap
_PATH_SYS_BLUETOOTH_RFCOMM /sys/kernel/debug/bluetooth/rfcom

URL: https://www.kernel.org/doc/Documentation/filesystems/debugfs.txt
URL: https://bugzilla.redhat.com/show_bug.cgi?id=1162284

This reverts commit 343192d1.

This fix from RedHat was actually a fix for one of their custom patches.
Applying it to mainline breaks interface stats.

When using a bucket of protocols (like -A inet), do not warn/abort when
some protocols are not supported.

URL: https://bugzilla.redhat.com/1063906
URL: https://bugzilla.redhat.com/1063913

For virtual interfaces created using the ifcfg-ethN:X scripts the
ifconfig and netstat -i report statistics of the last real adapter
listed in /proc/dev/net.

URL: https://bugzilla.redhat.com/143981

The display of "netstat -o" (on|off|keepalive|unkn-X) is not accurate.
I think that "unkn-4" should be "probe0" that is working "probe0 timer
(= ICSK_TIME_PROBE0 status = TCP Window Size is Zero)" in kernel.

URL: https://bugzilla.redhat.com/466845

A bunch of these funcs are only used by interface.c, so drop them from
interface.h and mark them static.  Also mark a bunch of buffers as const
when they aren't written to.

Yay for the ABI breakage.

Signed-off-by: Catalin Patulea <cat@vv.carleton.ca>

After coverity tool scan, some warnings about signed/unsigned conflicts in
sscanf format string were found. Not a serious problem, but better to be
correct.

RHBZ#1032563

Patch from TAKADA Yoshihito
https://bugzilla.redhat.com/show_bug.cgi?id=1021109

They are needed to be able to install binaries into
/usr/bin & /usr/sbin instead of /bin & /sbin.

1) Fall-back to numeric address if getnameinfo fails.
   Reverse lookup is not mandatory, therefore its fail
   is not an error. Just return numeric address in that case.
   This makes netstat/route show IPv6 address instead of
   [UNKNOWN] in case of DNS problems.

2) Pass length of 'name' buffer into function.
   'name' is a pointer and therefore sizeof(name)
   returns size of pointer and not size of the buffer.
   see http://stackoverflow.com/questions/14298710/c-pointers-and-arrays-sizeof-operator
   The sizeof() usage was added with commit 604785ad,
   so I checked all the other changes in that commit
   and they seem to be OK.

3) remove unused 's' variable

Thanks to Elias Probst for mentioning the problem.

Signed-off-by: Lehner Florian <dev@der-flo.net>

Signed-off-by: Lehner Florian <dev@der-flo.net>