Commit 62fb0e85 authored by Kirill Smelkov's avatar Kirill Smelkov

.

parent ac999990
...@@ -842,6 +842,8 @@ func (δBtail *ΔBtail) GetAt(root zodb.Oid, key Key, at zodb.Tid) (value Value, ...@@ -842,6 +842,8 @@ func (δBtail *ΔBtail) GetAt(root zodb.Oid, key Key, at zodb.Tid) (value Value,
// //
// the caller must not modify returned slice. // the caller must not modify returned slice.
// //
// Only tracked keys are guaranteed to be present.
//
// Note: contrary to regular go slicing, low is exclusive while high is inclusive. // Note: contrary to regular go slicing, low is exclusive while high is inclusive.
// //
// XXX root -> *Tree ? // XXX root -> *Tree ?
......
...@@ -502,7 +502,8 @@ func (δFtail *ΔFtail) ForgetPast(revCut zodb.Tid) { ...@@ -502,7 +502,8 @@ func (δFtail *ΔFtail) ForgetPast(revCut zodb.Tid) {
δFtail.δBtail.ForgetPast(revCut) δFtail.δBtail.ForgetPast(revCut)
// XXX locking // XXX locking
// XXX keep index which file changed epoch where (similarly to ΔBtail),
// TODO keep index which file changed epoch where (similarly to ΔBtail),
// and, instead of scanning all files, trim vδE only on files that is really necessary. // and, instead of scanning all files, trim vδE only on files that is really necessary.
for _, δftail := range δFtail.byFile { for _, δftail := range δFtail.byFile {
δftail.forgetPast(revCut) δftail.forgetPast(revCut)
...@@ -538,7 +539,7 @@ func (δftail *_ΔFileTail) forgetPast(revCut zodb.Tid) { ...@@ -538,7 +539,7 @@ func (δftail *_ΔFileTail) forgetPast(revCut zodb.Tid) {
// //
// the caller must not modify returned slice. // the caller must not modify returned slice.
// //
// XXX only tracked blocks are guaranteed to be present. // Only tracked blocks are guaranteed to be present.
// //
// Note: contrary to regular go slicing, low is exclusive while high is inclusive. // Note: contrary to regular go slicing, low is exclusive while high is inclusive.
func (δFtail *ΔFtail) SliceByFileRev(zfile *ZBigFile, lo, hi zodb.Tid) /*readonly*/[]*ΔFile { func (δFtail *ΔFtail) SliceByFileRev(zfile *ZBigFile, lo, hi zodb.Tid) /*readonly*/[]*ΔFile {
...@@ -546,7 +547,6 @@ func (δFtail *ΔFtail) SliceByFileRev(zfile *ZBigFile, lo, hi zodb.Tid) /*reado ...@@ -546,7 +547,6 @@ func (δFtail *ΔFtail) SliceByFileRev(zfile *ZBigFile, lo, hi zodb.Tid) /*reado
xtail.AssertSlice(δFtail, lo, hi) xtail.AssertSlice(δFtail, lo, hi)
// XXX locking // XXX locking
// XXX rebuild
// query .δBtail.SliceByRootRev(file.blktab, lo, hi) + // query .δBtail.SliceByRootRev(file.blktab, lo, hi) +
// merge δZBlk history with that. // merge δZBlk history with that.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment