- 12 Feb, 2019 1 commit
-
-
Arnaud Fontaine authored
ZODB Components: Likewise Document, add Mixin (erp5.component.mixin) and Interface (erp5.component.interface). * One Mixin/Interface class per ZODB Component. => Already the case for FS Mixin, not for Interfaces. * ZODB Components module name ('reference' property) and class name: + Mixin: FooMixin. + Interface: IFoo. Rationale: + Avoid current FS hacks: registry (Mixins, mixin_class_registry) or import all classes explicitly in __init__.py (Products.ERP5Type.interfaces). + Consistent naming. + Consistent with ZODB Documents Components. Also, modify pylint checker to handle Zope Interfaces: + E: 4, 0: Inheriting 'Interface', which is not a class. (inherit-non-class) + E: 5, 2: Method has no argument (no-method-argument)
-
- 11 Feb, 2019 3 commits
-
-
Romain Courteaud authored
Follow 1664e541 It seems developpers didn't update their instances.
-
Romain Courteaud authored
-
Romain Courteaud authored
-
- 07 Feb, 2019 2 commits
-
-
Stemmermann authored
-
Stemmermann authored
-
- 04 Feb, 2019 10 commits
-
-
Romain Courteaud authored
Creating a Software Publication doesn't require to change the Software Product.
-
Romain Courteaud authored
And so, simplify the code logic, as product is always created before the publication
-
Romain Courteaud authored
-
Romain Courteaud authored
Do not wait too long when pushing a new application.
-
Romain Courteaud authored
Do not modify document history if nothing changed
-
Romain Courteaud authored
Set the wildcard URL on a system preference.
-
Romain Courteaud authored
Those web site do not work in offline mode, so client must revalidate the components.
-
Romain Courteaud authored
Update appcache Drop unused scripts Thanks to Vincent Bechu for his work on this commit.
-
Romain Courteaud authored
-
Vincent Pelletier authored
As noted in a comment in this BT's Base_redirect implementation, original code does raise when abort_transaction is true. Not raising in this implementation means that this script will return to caller, while it never does on original code. Also, to add insult to injury, this utterly bogus implementation interferes with transaction boundaries. So suddenly, a single publication spans over 2 transactions, which can lead to: - ZODB Connection sharing, breaking transaction isolation - the second transaction implicitly created by this abort (actually, by the next transactional connector registration to transaction) may be committed, in which case anything done after Base_redirect returns will be persistently committed, against caller's explicitly specified intent, and against all developer expectations. NEVER TOUCH TRANSACTION ! Only CMFActivity and unittests are allowed this level of access (and CMFActivity should be modified out of this exceptional state).
-
- 01 Feb, 2019 2 commits
-
-
Romain Courteaud authored
Linshare Use the same configuration than ERP5 Thanks to Vincent Bechu for his work on this topic.
-
Romain Courteaud authored
-
- 31 Jan, 2019 2 commits
-
-
Romain Courteaud authored
-
Romain Courteaud authored
-
- 29 Jan, 2019 2 commits
-
-
Sebastien Robin authored
This reverts commit fba5767e. Sorry, I went too quickly, there was difference between self and context
-
Sebastien Robin authored
-
- 28 Jan, 2019 1 commit
-
-
Jérome Perrin authored
This reverts commit 7aa5fb76 > this change makes title empty when reply !823 (comment 73439) /reviewed-on !826
-
- 25 Jan, 2019 2 commits
-
-
Romain Courteaud authored
-
Xiaowu Zhang authored
-
- 21 Jan, 2019 5 commits
-
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Xiaowu Zhang authored
1. a inventory report module is added which user can add inventory report 2. in inventory report, user should put information such as Owner, Warehouse... then call calculate product stock action 3. one line per product is then added automatically with current total quantity and total asset price ![Screenshot_2018-12-12_at_17.42.24](/uploads/98f8a4af66faadfdfd1d99b4400ff687/Screenshot_2018-12-12_at_17.42.24.png) /reviewed-on nexedi/erp5!806
-
Xiaowu Zhang authored
if i have a url like: https://erp5xxx/form_idxxx?relative_item_relative_url=item_module/7817 with the old way, form id will be 7817 /reviewed-on nexedi/erp5!824
-
Jérome Perrin authored
According to pep-0263, python scripts can define encoding magic on first or second line. If we use for example such a script: ```python # coding: utf-8 return "héhé" ``` then using .read() was wrong, because it return the script with headers, ie: ```python ## Script (Python) "test_coding" ##bind container=container ##bind context=context ##bind namespace= ##bind script=script ##bind subpath=traverse_subpath ##parameters= ##title= ## # coding: utf-8 return "héhé" ``` so the coding magic is no longer in first line and pylint complains with error like: Cannot decode using encoding "ascii", unexpected byte at position 11 (invalid-encoded-data)] /reviewed-on nexedi/erp5!825
-
- 18 Jan, 2019 10 commits
-
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
only calculate exchange rate if necessary use transaction cache make getExchangeRate as local function
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-
Xiaowu Zhang authored
-