File "product/TimerService/timerserver/TimerServer.py", line 71, in run
    s.send('GET / HTTP/1.1\r\n\r\n')
TypeError: a bytes-like object is required, not 'str'

And Zope4 now mandates it to be a string ({Shared.DC.ZRDB.TM.TM,ITransactionManager}.sortKey()).

This changes the API to implement similar feature in Python3, but this should
not be an issue because Interactor are only for non-ERP5 object...

py3: AccessControl users_with_local_roles() returns a dict_keys() instead of a subscriptable object.

Submitted upstream:
  https://github.com/zopefoundation/AccessControl/pull/128

py3: DCWorkflow is python2-only so make ERP5Site creation work on Python3 WITH_LEGACY_WORKFLOW=False.

ERP5 Workflow implementation should ideally not depend on DCWorkflow at all so
that legacy DCWorkflow can be disabled for Python2 but this would require much
more work.

Mainly for maintenance sake and to update the code before porting it to python3.

See merge request nexedi/erp5!1614

Seems required for Chameleon 3.2

See also commit 8c222bd5
("Switch to class-based completely instead of id-based styling").

See merge request nexedi/erp5!1611

we may get stopped SM in some case, maybe it's because sql is not updated.

here is some trackback:
------
2022-05-02 09:30:17,457 INFO InvoiceTransaction_selectInvoiceMovement, 37: <object object at 0x7f707a6e61f0> started  sm
------
2022-05-02 09:30:17,459 INFO InvoiceTransaction_selectInvoiceMovement, 37: <object object at 0x7f707a6e61f0> started  sm
------
2022-05-02 09:30:17,579 INFO InvoiceTransaction_selectDelivery, 27: <object object at 0x7f707a6e61f0> {<Sale Invoice Transaction at /nexedi/accounting_module/20220502-3DD4B45>: 1}
==> slappart8/var/log/zope-0-event.log <==               ***************************** deliver sale invoice transaction
------
2022-05-02 09:30:21,512 INFO RuleTool Updating simulation for /nexedi/accounting_module/20220502-3DD4B45: {'create_root': 1, 'index_related': 1}

==> slappart5/var/log/zope-0-event.log <==
------
2022-05-02 09:30:22,892 WARNING SQLDict Exception raised when invoking messages (uid, path, method_id) [(275788776658006010L, ('', 'nexedi', 'accounting_module', '20220502-3DD4B45'),
'_localBuild')]
Traceback (most recent call last):
  File "/srv/slapgrid/slappart16/srv/runner/software/cc627918c55102e3f1a6c6a0077f41bb/parts/erp5/product/CMFActivity/Activity/SQLBase.py", line 868, in dequeueMessage
    transaction.commit()
  File "/srv/slapgrid/slappart16/srv/runner/software/cc627918c55102e3f1a6c6a0077f41bb/eggs/transaction-1.7.0-py2.7.egg/transaction/_manager.py", line 123, in commit
    return self.get().commit()
  File "/srv/slapgrid/slappart16/srv/runner/software/cc627918c55102e3f1a6c6a0077f41bb/eggs/transaction-1.7.0-py2.7.egg/transaction/_transaction.py", line 280, in commit
    reraise(t, v, tb)
  File "/srv/slapgrid/slappart16/srv/runner/software/cc627918c55102e3f1a6c6a0077f41bb/eggs/transaction-1.7.0-py2.7.egg/transaction/_transaction.py", line 271, in commit
    self._commitResources()
  File "/srv/slapgrid/slappart16/srv/runner/software/cc627918c55102e3f1a6c6a0077f41bb/eggs/Products.TIDStorage-5.5.0-py2.7.egg/Products/TIDStorage/transaction_transaction.py", line 25
1, in _commitResources
    result = original__commitResources(self, *args, **kw)
  File "/srv/slapgrid/slappart16/srv/runner/software/cc627918c55102e3f1a6c6a0077f41bb/eggs/transaction-1.7.0-py2.7.egg/transaction/_transaction.py", line 416, in _commitResources
    reraise(t, v, tb)
  File "/srv/slapgrid/slappart16/srv/runner/software/cc627918c55102e3f1a6c6a0077f41bb/eggs/transaction-1.7.0-py2.7.egg/transaction/_transaction.py", line 390, in _commitResources
    rm.commit(self)
  File "/srv/slapgrid/slappart16/srv/runner/software/cc627918c55102e3f1a6c6a0077f41bb/eggs/ZODB-4.4.5-py2.7.egg/ZODB/Connection.py", line 582, in commit
    self._commit(transaction)
  File "/srv/slapgrid/slappart16/srv/runner/software/cc627918c55102e3f1a6c6a0077f41bb/eggs/ZODB-4.4.5-py2.7.egg/ZODB/Connection.py", line 630, in _commit
    raise ConflictError(object=obj)
ConflictError: database conflict error (oid 0x0c78a313, class erp5.portal_type.Sale Invoice Transaction)
------
******************* /nexedi/accounting_module/20220502-3DD4B45 localbuild restart because of ConflictError

2022-05-02 09:30:23,340 INFO InvoiceTransaction_selectInvoiceMovement, 37: <object object at 0x7f707a6e61f0> stopped sm
------
2022-05-02 09:30:23,342 INFO InvoiceTransaction_selectInvoiceMovement, 37: <object object at 0x7f707a6e61f0> stopped sm
------
2022-05-02 09:30:23,381 INFO InvoiceTransaction_selectDelivery, 27: <object object at 0x7f707a6e61f0> {<Sale Invoice Transaction at /nexedi/accounting_module/20220502-3DD4B45>: 1}

using json in 37b795fb was wrong,
because not all arguments can be converted to json (for example
DateTime instances)

This also enable the format using pprint.pformat for args, instead
of a simple str that was done in ActivityTool_getMessageList.

See merge request nexedi/erp5!1600

   The portal_skins was choosen to store the images to use proper http
cache.

   It is really not required, so we follow up the same as google oauth.

See merge request nexedi/erp5!1607

See merge request nexedi/erp5!1608

When spawning an activity, store the current security context's user in
the Message object itself, so the activity security context can be
re-created with the same security during activity execution.
This allows a user to be modified (different groups, global roles, maybe
removed altogether) after they spawned activities and before these activities
could run.
It also means that any temporary custom group or global role granted to
that user (by a privilege elevation mechanism out of the scope of this
change) will still be effective during the activity execution.
This follows the principle that
  foo.activate(...).bar(...)
should be equivalent to its "immediate execution" version
  foo.bar(...)
by ensuring that the security context of the activity is the same as the
one which was applied to the code which spawned that activity,
independently of any intermediate configuration change - hence improving
(deferred and fragmentary) transaction isolation.

This also removes the need to look the user up, then looking up their
assignments (and other documents involved in group computation), etc,
saving the cost of these calls.

Also, remove redundant user_name argument of Message.changeUser method.

The action was removed in 6dce55b0 (dms: drop PDF thumbnail view, 2021-06-01)
but some CSS declarations were not removed.

Also remove some old commented out javascript that was referencing the
old PDF preview

When a validated component is edited, `mixin.component.RecordablePropertyMetaClass`
records the `text_content` property. This recorded property will be cleared afterwards
if no errors are found, but this causes differences in business template XML for each
component the first time they are edited.

This change is about removing the `_recorded_property_dict` when there are no property
recorded, which leads to slightly smaller pickles (and business template XML, because
they are also pickles).

See merge request !1605

This makes smaller pickles