promise: Improve bot status problem reporting in check_surykatka_json

slapos/promise/plugin/check_surykatka_json.py

@@ -64,7 +64,9 @@ class RunPromise(GenericPromise):
       return
     bot_status = bot_status_list[0]
     if bot_status.get('text') != 'loop':
-      appendError("No type loop detected in %r", self.json_file)
+      appendError(
+        "bot_status is %r instead of 'loop' in %r",
+        bot_status.get('text'), self.json_file)
       return
     timetuple = email.utils.parsedate(bot_status['date'])
     last_bot_datetime = datetime.datetime.fromtimestamp(time.mktime(timetuple))

slapos/test/promise/plugin/test_check_surykatka_json.py

@@ -118,6 +118,32 @@ class TestCheckSurykatkaJSONBotStatus(CheckSurykatkaJSONMixin):
       "UTC now is Wed, 13 Dec 2222 09:11:12 -0000"
     )
 
+  def test_no_loop(self):
+    self.writeSurykatkaPromise(
+      {
+        'report': 'bot_status',
+        'json-file': self.json_file,
+        'test-utcnow': 'Wed, 13 Dec 2222 09:11:12 -0000'
+      }
+    )
+    self.writeSurykatkaJson("""{
+    "bot_status": [
+        {
+            "date": "Wed, 13 Dec 2222 09:10:11 -0000",
+            "text": "error"
+        }
+    ]
+}
+""")
+    self.configureLauncher(enable_anomaly=True)
+    with self.assertRaises(PromiseError):
+      self.launcher.run()
+    self.assertFailedMessage(
+      self.getPromiseResult(self.promise_name),
+      "bot_status: ERROR bot_status is u'error' instead of 'loop' in '%s'" % (
+        self.json_file,)
+    )
+
   def test_bot_status_future(self):
     self.writeSurykatkaPromise(
       {