- 24 Jan, 2020 1 commit
-
-
Jérome Perrin authored
Wrapping a method in a workflow method should not change the publishable state the method. If the original method is not publishable, wrapping it in a workflow method should not make it publishable. If the original method is publishable, then the wrapped method should still be publishable. This was always intended to work like this, as we can see in the code comment in `WorkflowMethod.__init__` but was not properly tested and got broken at some point. It's important to restore the behavior, because workflow methods such as `validate` should not be published, users must only be able to use the user interface transitions freely, workflow methods transitions are only available if developer expose them in a script - and perform the necessary consistency and security checks in that script.
-
- 23 Jan, 2020 3 commits
-
-
Jérome Perrin authored
-
Jérome Perrin authored
Only "user action" methods needs a security declaration.
-
Jérome Perrin authored
If we rename a script used as external validator, we don't have way of detecting that this script might be used, so add to the "static checks" a check that for every field referencing an external validator, this validator can actually be traversed. /reviewed-on !1031
-
- 22 Jan, 2020 2 commits
-
-
Jérome Perrin authored
-
Jérome Perrin authored
Check that script exists.
-
- 20 Jan, 2020 4 commits
-
-
Vincent Pelletier authored
Like a real-world user.
-
Vincent Pelletier authored
-
Vincent Pelletier authored
__ac_name & __ac_password are only useful to get a cookie, so only use them when the test is actually expecting a cookie.
-
Vincent Pelletier authored
One inline javascript snippet less.
-
- 17 Jan, 2020 3 commits
-
-
Kazuhiko Shiozaki authored
-
Romain Courteaud authored
-
Arnaud Fontaine authored
-
- 15 Jan, 2020 6 commits
-
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Arnaud Fontaine authored
ZODB Components: Preparation of erp5_base migration from FS: Fix pylint no-name-in-module on newTempXXX (04b49859).
-
Jérome Perrin authored
Change upgrader internal API to use `filter_dict` instead of `filter` which is a builtin. Remove a lot of unused code in extensions /reviewed-on nexedi/erp5!1014
-
- 14 Jan, 2020 12 commits
-
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
ZODB Components: Preparation of erp5_base migration from FS: Fix pylint no-name-in-module on newTempXXX (04b49859).
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
ZODB Components: BusinessTemplate: On migration dialog, ignore source files not available anymore (ex: change branch).
-
Jérome Perrin authored
Test should not depend on external websites, we already use erp5.com for some other tests, so let's use it also for RSS. /reviewed-on !1028
-
Vincent Pelletier authored
Deleting matrix cells with manage_delObjects is not a good solution, as this breaks matrix index consistency. Also, call isBasePricePerSlice rather than introspecting wrapped method arguments - the only wrapped method is _setBasePricePerSlice anyway ! Also, explicitly trigger SupplyCell_updateSliceBasePrice as it depends on isBasePricePerSlice value at line level, and it just changed, and cell-level interaction workflow does not trigger on line changes. Also, get rid of a trivial local variable. Also, fix the exception expected from list.index . Also, raise if multiple quantity criterion are somehow found.
-
- 13 Jan, 2020 2 commits
-
-
Arnaud Fontaine authored
-
Jérome Perrin authored
When server replies with a non XML content type feeparser attempt to parse anyway, but set the bozo flag. https://universal-feedparser.readthedocs.io/en/latest/#handling-incorrectly-declared-media-types If parsing fail because the feed is not a valid RSS XML stream, feedparser fail in other ways, so we can safely ignore this error. This should repair recent failures with testFeedReaderGadget now that le monde changed configuration on their website: $ curl -sD - -o /dev/null https://www.lemonde.fr/rss/une.xml | grep Content-Type Content-Type: text/html;charset=UTF-8 /reviewed-on nexedi/erp5!1027
-
- 10 Jan, 2020 7 commits
-
-
Romain Courteaud authored
See nexedi/erp5@b678a025
-
Romain Courteaud authored
-
Romain Courteaud authored
Introduce the object_jio_jump action category to mark all compatible actions. erp5_xhtml_style supports object_jio_jump. A correct redirection is needed to jump in both UI. ERP5JS will display modules on the current document context, as if the jump was instead a object_view action.
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-