Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
dream
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
1
Issues
1
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
dream
Commits
b6501b94
Commit
b6501b94
authored
Nov 29, 2014
by
Jérome Perrin
Committed by
Ioannis Papagiannopoulos
Dec 18, 2014
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Graph editor: Do not pass useless parameters
parent
a8ba680d
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
15 additions
and
6 deletions
+15
-6
dream/platform/src/jsplumb/jsplumb.js
dream/platform/src/jsplumb/jsplumb.js
+15
-6
No files found.
dream/platform/src/jsplumb/jsplumb.js
View file @
b6501b94
...
...
@@ -438,14 +438,23 @@
return
expanded_class_definition
;
}
// TODO: remove class_definition from this function and callees signature
function
openNodeDialog
(
gadget
,
element
,
class_definition
)
{
function
openNodeDialog
(
gadget
,
element
)
{
var
node_id
=
getNodeId
(
gadget
,
element
.
id
),
node_data
=
gadget
.
props
.
data
.
graph
.
node
[
node_id
],
node_edit_popup
=
$
(
gadget
.
props
.
element
).
find
(
'
#popup-edit-template
'
),
schema
=
expandSchema
(
class_definition
,
gadget
.
props
.
data
)
,
schema
,
fieldset_element
,
delete_promise
;
// If we have no definition for this, we do not allow edition.
if
(
gadget
.
props
.
data
.
class_definition
[
node_data
.
_class
]
===
undefined
)
{
return
;
}
schema
=
expandSchema
(
gadget
.
props
.
data
.
class_definition
[
node_data
.
_class
],
gadget
.
props
.
data
);
if
(
node_edit_popup
.
length
!==
0
)
{
node_edit_popup
.
remove
();
...
...
@@ -528,13 +537,13 @@
});
}
function
waitForNodeClick
(
gadget
,
node
,
config_dict
)
{
function
waitForNodeClick
(
gadget
,
node
)
{
gadget
.
props
.
nodes_click_monitor
.
monitor
(
loopEventListener
(
node
,
'
dblclick
'
,
false
,
openNodeDialog
.
bind
(
null
,
gadget
,
node
,
config_dict
)
openNodeDialog
.
bind
(
null
,
gadget
,
node
)
));
}
...
...
@@ -576,7 +585,7 @@
).
querySelector
(
'
.window
'
);
render_element
.
append
(
domElement
);
waitForNodeClick
(
gadget
,
domElement
,
class_definition
);
waitForNodeClick
(
gadget
,
domElement
);
box
=
$
(
gadget
.
props
.
element
).
find
(
"
#
"
+
dom_element_id
);
absolute_position
=
convertToAbsolutePosition
(
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment