ERP5Form: Really ignore the form if it is in the ignore list.
Showing
-
Owner
I think this was intentional to check these even for ignored skins. As we can see in this comment ( https://lab.nexedi.com/nexedi/erp5/blob/8e945c95a263cf4b50fa36ef507491b8ec8aa96e/product/ERP5Form/Form.py#L1348 )
# For ignored_skin_id_set, we only ignore naming of the form itself.
Are there some problems that are impossible to fix ?
-
Owner
Yes, in case of Ticket_viewAsHateoas:
We want the non-translated value (and the translated one too), since this is part of expected API not for displaying to the user.
[<ObjectMessage object at 0x7fbd870fc5f0 'object_relative_url': '/portal_skins/slapos_hal_json_style/Ticket_viewAsHateoas' 'message': 'erp5-Guideline.Use.Correct.Names.For.Simulation.And.Validation.Titles: Workflow state fields should be named my_translated_${state_variable}_title' 'mapping': {}>]
In such case, there is also an hardcoded value for a certain fields:
def isNonTranslatedWorkflowStateField(f): return not_translated_workflow_state_field_re.match(f.getId()) and f.getId() not in ( # exception for some properties containing "state" in their names 'my_initial_implementation_state', 'my_hot_reindexing_state', 'my_message_different_state', )
So why what is on ignore list, can't be ignored after all? I'm not sure if there are other ways to handle it.
-
mentioned in merge request !1479 (merged)
Please register or sign in to comment