1. 10 Oct, 2019 5 commits
    • Jérome Perrin's avatar
      testERP5TestNode: remove outdated XXX comment · 1172ff04
      Jérome Perrin authored
      When running tests the path to git command is just git, because we have
      set $PATH
    • Jérome Perrin's avatar
      testnode: fix Computer.updateConfiguration call · b76875d6
      Jérome Perrin authored
      updateConfiguration is a method to set the list of partitions, not to
      add partitions to an existing computer. The previous (slapos.core
      <1.5.0) implementation of slap proxy was incorrect and was adding more
      partitions each time it was called, but that was never the indented
      Prepare the list of partitions and call updateConfiguration only once to
      set all partitions.
      This should fix SLAPOS-SR-TEST that are still using erp5.util
    • Jérome Perrin's avatar
      testERP5TestNode: make tests properly isolated · 0e0e240f
      Jérome Perrin authored
      Some tests where patching SlapOSControler to replace methods by a no-op,
      but this was never reset. I believe we should rewrite this using mock
      which takes care of un-doing the patches for us and makes this testing
      easier, but for now I'm just reseting the missing methods like all
      others were already reseted.
    • Jérome Perrin's avatar
      testERP5TestNode: fix fake config · 4b752bdb
      Jérome Perrin authored
      configparser read options as strings, node_quantity is not supposed to
      be an int.
    • Jérome Perrin's avatar
      testnode: python3 support · dab9e278
      Jérome Perrin authored
      pkg_resources.resource_string reads the file as binary, if we want to
      substitute in this string we need to decode it.
  2. 09 Oct, 2019 7 commits
  3. 08 Oct, 2019 4 commits
  4. 07 Oct, 2019 7 commits
  5. 05 Oct, 2019 3 commits
  6. 04 Oct, 2019 5 commits
    • Julien Muchembled's avatar
      Optimize WorkflowHistoryList · 1ca655a3
      Julien Muchembled authored
      This is done by inheriting most of the code of ConflictFreeLog,
      i.e. using a doubly-linked list:
      - for fast iteration of the first elements, and in particular
        immediate access to the first element (used for creation date);
      - that keeps track of the history length;
      - that implement fast reverse iteration (although it could
        have been done without changing the data structure).
      The size of buckets is not fixed anymore to 16 items:
      like ConflictFreeLog, WorkflowHistoryList is also a good candidate
      to look at the estimated serialized size of the bucket in order to
      decide if elements should be added to a new one or not.
      Then developers won't have to care about using Pdata or not.
      The size is bigger than the ConflictFreeLog default,
      because workflow items look a lot alike and adding
      a few more is cheap when the ZODB compresses.
      No more optimized __getstate__ (except for workflow histories that
      have not been migrated) so BT export will be a bit more verbose.
      The BBB code is because of
      /reviewed-on !941
    • Arnaud Fontaine's avatar
      ZODB Components: Before migrating Interfaces from FS, there must be one... · 694c9fee
      Arnaud Fontaine authored
      ZODB Components: Before migrating Interfaces from FS, there must be one Interface class per source file matching its name.
      Same as Document class: this avoids registering Interfaces at startup and just do it
      when using the Interface. In assuming that portal_components/XXX has a class
      name equals to XXX.getRference(), it is easier to:
       * List all existing Interfaces (for example in Portal Type Class view): getReference()
         on all validated 'Interface Component' in portal_components.
       * Lookup for an 'Interface Component': 'from erp5.component.interfaces.XXX import XXX'.
    • Arnaud Fontaine's avatar
      ZODB Components: Properly handle addition of template_* properties in... · d9627917
      Arnaud Fontaine authored
      ZODB Components: Properly handle addition of template_* properties in BusinessTemplate PropertySheet.
      On the plus side, this avoids an ugly 'except AttributeError: pass' which does
      not work anyway with the scenario below.
      Assuming the following:
        * template_XXX Property (accessor: getTemplateXXX) recently added to BusinessTemplate PropertySheet.
        * erp5_YYY sets template_A Property (erp5_YYY/bt/template_XXX.xml).
        This commit handles the following:
          1. Stop instance with old ERP5 without template_XXX.
          2. Update erp5.git.
          3. Start instance.
          4. Upgrade erp5_property_sheets and erp5_YYY bt5s in *one* transaction from portal_templates UI.
          => When upgrading erp5_YYY, BusinessTemplate.importFile() imports erp5_YYY/bt/*.xml where the
             list of files is based on BusinessTemplate class propertyMap(), but at this point accessors
             have not been re-generated yet, thus template_XXX is not returned by propertyMap() and
             erp5_YYY/bt/template_XXX.xml is not imported.
             => portal_templates/erp5_YYY new BT does not have template_XXX property set at all.
    • Ivan Tyagov's avatar
      Default ERP5 instanciation uses following schema for naming all zope nodes: · 0a66e514
      Ivan Tyagov authored
        <family_name>-0..9 when number of nodes <= 10
        <family_name>-01..09 (or n) when number of nodes > 10
      In scalability tests instance keeps track of old used nodes and when nodes > 10
      will pick by default sort "activity-0" which is NO longer an existing zope process.
      This is an ugly fix and real woraround is to have something like activities-000x schema by default
    • Arnaud Fontaine's avatar
      runUnitTest: 6f1c45c6 wrongly assumed that '--erp5_sql_connection_string' is always passed. · a3c40d0b
      Arnaud Fontaine authored
      This is the case with runUnitTest wrapper created by SlapOS but is not actually required
      as manage_addERP5Site has 'test test' as default value.
      This fixes:
        File "custom_zodb.py", line 70, in <module>
          sql_db = Products.ZMySQLDA.db.DB(os.environ['erp5_sql_connection_string'])
        File "UserDict.py", line 40, in __getitem__
          raise KeyError(key)
      KeyError: 'erp5_sql_connection_string'
  7. 03 Oct, 2019 3 commits
  8. 02 Oct, 2019 6 commits