Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 139
    • Merge requests 139
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !1099

Merged
Created Apr 11, 2020 by Arnaud Fontaine@arnauDeveloper

WIP: providesI<INTERFACE_NAME> accessors were not created for ZODB Components

  • Overview 11
  • Commits 6
  • Changes 26

@nexedi provideI<INTERFACE_NAME> (such as providesIPredicate) accessors are currently generated by importLocalInterface() and then set on Base class. These accessors were not generated for ZODB Components, so this MR is about fixing that. All Unit Tests and CodingStyle Tests pass.

As these accessors need to be re-generated on reset, I put them in BaseAccessorHolder. For unification sake, I moved accessors of filesystem Interfaces from Base to BaseAccessorHolder. While doing so, I found out that ERP5Form and CertificateAuthorityTool were still being created by Document instanciation directly (which has been banned since we moved to erp5.portal_type) rather than through newContent() (or constructInstance()), so I have fixed that and added proper Portal Types in portal_types for ERP5 Form in (moved from erp5_hal_json_style to erp5_core) and Certificate Authority Tool. At the same time I got rid of direct Document instanciation, I removed _getAcquireLocalRoles() hardcoded methods on these Documents (added by @vpelletier in 58d4ab8e).

@rafael Is that okay for you that erp5_promise now depends on erp5_certificate_authority_tool (where portal_types/Certificate Authority Tool and portal_certificate_authority are)? BTW, this is unrelated to this MR but I wanted to ask: I have heard from @jerome that Certificate Authority Tool is supposed to superseeded by Caucase so it is probably not worth it migrating it to ZODB Components?

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: arnau-RD-Components-providesIFoo
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7