This breaks the following test:
======================================================================
ERROR: test_09_runTestSuite (erp5.tests.testERP5TestNode.ERP5TestNode)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/srv/slapgrid/slappart7/srv/testnode/ij/inst/test0-0/parts/erp5-util/erp5/tests/testERP5TestNode.py", line 542, in test_09_runTestSuite
checkRunTestSuiteParameters()
File "/srv/slapgrid/slappart7/srv/testnode/ij/inst/test0-0/parts/erp5-util/erp5/tests/testERP5TestNode.py", line 532, in checkRunTestSuiteParameters
runner.runTestSuite(node_test_suite,"http://foo.bar")
File "/srv/slapgrid/slappart7/srv/testnode/ij/inst/test0-0/parts/erp5-util/erp5/util/testnode/UnitTestRunner.py", line 151, in runTestSuite
'--frontend_url', slapos_controler.config['frontend_url']])
KeyError: 'frontend_url'
I think I've fixed it (the test now passes). Can you review the related change in 40a3804e, and in particular in erp5/util/testnode/UnitTestRunner.py
?
Apart from that, such change implies that we update the existing runTestSuite
scripts that we have in several SR, to teach them the new option. Is it necessary? I was about to suggest using an environment variable instead but I see there's already something in UnitTestRunner
to drop optional parameters that aren't implemented (see getSupportedParameterSet
). BTW, --node_quantity
should also be made optional.
I must admit I don't really understand how --frontend_url
works. Can we make it optional?