Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 136
    • Merge requests 136
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !282

Merged
Created Jun 08, 2017 by Jérome Perrin@jeromeOwner

Fix EnvironmentError: All displays locked : [':123', ':124', ':125', .. on test node

  • Overview 6
  • Commits 1
  • Changes 1

@luke @rafael @vincentB see commit message:

test: Do not check presence of lockfile in /tmp/ to assume Xvfb is running for this display

This caused two problems:

  • If Xfvb was killed and left a stale lock file, we don't reuse this display. After some time we end up having "All display locked" exception but no Xvfb process running.
  • Xvfb's slapos is patched to store control sockets and lockfiles in $TMPDIR ( slapos@58462c24 ). We don't have $TMPDIR set in testnodes, but this would be a problem if we ever set it.

Because Xvfb can detect a stale lock file upon startup and start anyway, the easy way running Xvfb for each display and see if it's still running after a few seconds.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix/xvfb_all_displays_locked
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7