Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 140
    • Merge requests 140
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !893

Closed
Created Jun 18, 2019 by Vincent Pelletier@vpelletierOwner
  • Report abuse
Report abuse

Reduce bt content duplication

  • Overview 21
  • Commits 9
  • Changes 43

This is part of my preparatory work on fixing index/delete race-condition. These commits are not expected to introduce any functional change, they only remove some indexable objects which are present multiple Business Templates and those Business Templates get installed during any of the unit tests we have.

This removal covers only a tiny part of what is actually duplicated (enough to get tests to pass if one does not delete all pending activities when their context document gets deleted), of which a part can be listed using:

for duplicate in $( \
  find bt5/*/*TemplateItem/*/ -name "*.xml" | cut -f 3- -d/ | sort | uniq -d \
); do \
  for duplicate_path in bt5/*/$duplicate; do \
    echo "$duplicate_path"; \
  done; \
done | sort | less

which emits 1.2k lines on current master.

I believe these cleanups are good, whatever the fix we want to apply for the main issue.

@seb @jm @jerome @romain @aurel : please review, and please involve (@-mention) anyone you know who might be familiar with each BT.

Special note for erp5_banking_core: site and variation Base Category from erp5_pdm do differ slightly in their settings from the ones which I'm deleting here: pdm's variation does not acquire from delivery, pdm's site does not have any acquisition portal type. I believe it should be acceptable, and it does not cause any error in banking tests, and I have no other idea on how we are supposed to override these within the generic repository otherwise: maybe in a project-specific BT, maybe a project-specific fork would customise the categories in erp5_pdm directly...

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: reduce_bt_content_duplication
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7