Commit 02b695ce authored by Fabio Pitino's avatar Fabio Pitino

Merge branch 'pcalder-remove-buy-ci-minutes-version-a' into 'master'

Remove feature flag buy_ci_minutes_version_a_experiment_percentage

See merge request gitlab-org/gitlab!41632
parents 5db3f5d4 a9e8a903
...@@ -7,7 +7,7 @@ module EE ...@@ -7,7 +7,7 @@ module EE
BUY_PIPELINE_MINUTES_NOTIFICATION_DOT = 'buy_pipeline_minutes_notification_dot' BUY_PIPELINE_MINUTES_NOTIFICATION_DOT = 'buy_pipeline_minutes_notification_dot'
def show_buy_pipeline_minutes?(project, namespace) def show_buy_pipeline_minutes?(project, namespace)
return false unless experiment_enabled?(:ci_notification_dot) || experiment_enabled?(:buy_ci_minutes_version_a) return false unless experiment_enabled?(:ci_notification_dot)
show_out_of_pipeline_minutes_notification?(project, namespace) show_out_of_pipeline_minutes_notification?(project, namespace)
end end
......
...@@ -91,16 +91,6 @@ RSpec.describe EE::Ci::RunnersHelper do ...@@ -91,16 +91,6 @@ RSpec.describe EE::Ci::RunnersHelper do
it_behaves_like 'minutes notification' do it_behaves_like 'minutes notification' do
before do before do
allow(helper).to receive(:experiment_enabled?).with(:ci_notification_dot).and_return(experiment_status) allow(helper).to receive(:experiment_enabled?).with(:ci_notification_dot).and_return(experiment_status)
allow(helper).to receive(:experiment_enabled?).with(:buy_ci_minutes_version_a).and_return(false)
end
end
end
context 'when experiment is "ci_minutes_version_a"' do
it_behaves_like 'minutes notification' do
before do
allow(helper).to receive(:experiment_enabled?).with(:ci_notification_dot).and_return(false)
allow(helper).to receive(:experiment_enabled?).with(:buy_ci_minutes_version_a).and_return(experiment_status)
end end
end end
end end
......
...@@ -42,9 +42,6 @@ module Gitlab ...@@ -42,9 +42,6 @@ module Gitlab
ci_notification_dot: { ci_notification_dot: {
tracking_category: 'Growth::Expansion::Experiment::CiNotificationDot' tracking_category: 'Growth::Expansion::Experiment::CiNotificationDot'
}, },
buy_ci_minutes_version_a: {
tracking_category: 'Growth::Expansion::Experiment::BuyCiMinutesVersionA'
},
upgrade_link_in_user_menu_a: { upgrade_link_in_user_menu_a: {
tracking_category: 'Growth::Expansion::Experiment::UpgradeLinkInUserMenuA' tracking_category: 'Growth::Expansion::Experiment::UpgradeLinkInUserMenuA'
}, },
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment