Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
0353dab5
Commit
0353dab5
authored
Nov 11, 2021
by
Eduardo Bonet
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Logging instead of raising error for ipynb errors
parent
bee7ab2a
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
2 deletions
+2
-2
app/presenters/blob_presenter.rb
app/presenters/blob_presenter.rb
+1
-1
lib/gitlab/diff/file.rb
lib/gitlab/diff/file.rb
+1
-1
No files found.
app/presenters/blob_presenter.rb
View file @
0353dab5
...
...
@@ -133,7 +133,7 @@ class BlobPresenter < Gitlab::View::Presenter::Delegated
@transformed_blob
||=
blob
.
data
rescue
IpynbDiff
::
InvalidNotebookError
=>
e
Gitlab
::
ErrorTracking
.
track_exception
(
e
,
issue_url:
'https://gitlab.com/gitlab-org/gitlab/-/issues/344676'
)
Gitlab
::
ErrorTracking
.
log_exception
(
e
)
blob
.
data
end
end
lib/gitlab/diff/file.rb
View file @
0353dab5
...
...
@@ -466,7 +466,7 @@ module Gitlab
Gitlab
::
AppLogger
.
info
({
message:
new_diff
?
'IPYNB_DIFF_GENERATED'
:
'IPYNB_DIFF_NIL'
})
rescue
IpynbDiff
::
InvalidNotebookError
=>
e
Gitlab
::
ErrorTracking
.
track_exception
(
e
,
issue_url:
'https://gitlab.com/gitlab-org/gitlab/-/issues/344676'
)
Gitlab
::
ErrorTracking
.
log_exception
(
e
)
end
def
alternate_viewer_class
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment