Commit 0353dab5 authored by Eduardo Bonet's avatar Eduardo Bonet

Logging instead of raising error for ipynb errors

parent bee7ab2a
...@@ -133,7 +133,7 @@ class BlobPresenter < Gitlab::View::Presenter::Delegated ...@@ -133,7 +133,7 @@ class BlobPresenter < Gitlab::View::Presenter::Delegated
@transformed_blob ||= blob.data @transformed_blob ||= blob.data
rescue IpynbDiff::InvalidNotebookError => e rescue IpynbDiff::InvalidNotebookError => e
Gitlab::ErrorTracking.track_exception(e, issue_url: 'https://gitlab.com/gitlab-org/gitlab/-/issues/344676') Gitlab::ErrorTracking.log_exception(e)
blob.data blob.data
end end
end end
...@@ -466,7 +466,7 @@ module Gitlab ...@@ -466,7 +466,7 @@ module Gitlab
Gitlab::AppLogger.info({ message: new_diff ? 'IPYNB_DIFF_GENERATED' : 'IPYNB_DIFF_NIL' }) Gitlab::AppLogger.info({ message: new_diff ? 'IPYNB_DIFF_GENERATED' : 'IPYNB_DIFF_NIL' })
rescue IpynbDiff::InvalidNotebookError => e rescue IpynbDiff::InvalidNotebookError => e
Gitlab::ErrorTracking.track_exception(e, issue_url: 'https://gitlab.com/gitlab-org/gitlab/-/issues/344676') Gitlab::ErrorTracking.log_exception(e)
end end
def alternate_viewer_class def alternate_viewer_class
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment