Merge branch 'mk/avoid-unnecessary-file-creation-in-spec' into 'master'

Avoid unnecessary file creation in spec

See merge request gitlab-org/gitlab!67156

.gitlab/issue_templates/Geo Replicate a new Git repository type.md

@@ -454,7 +454,7 @@ That's all of the required database changes.
   ```
 
 - [ ] Update `REGISTRY_CLASSES` in `ee/app/workers/geo/secondary/registry_consistency_worker.rb`.
-- [ ] Update `def model_class_factory_name` in `ee/spec/services/geo/registry_consistency_service_spec.rb`.
+- [ ] Add a custom factory name if needed in `def model_class_factory_name` in `ee/spec/services/geo/registry_consistency_service_spec.rb`.
 - [ ] Update `it 'creates missing registries for each registry class'` in `ee/spec/workers/geo/secondary/registry_consistency_worker_spec.rb`.
 - [ ] Add `cool_widget_registry` to `ActiveSupport::Inflector.inflections` in `config/initializers_before_autoloader/000_inflections.rb`.
 - [ ] Create `ee/spec/factories/geo/cool_widget_registry.rb`:

.gitlab/issue_templates/Geo Replicate a new blob type.md

@@ -421,7 +421,7 @@ That's all of the required database changes.
   ```
 
 - [ ] Update `REGISTRY_CLASSES` in `ee/app/workers/geo/secondary/registry_consistency_worker.rb`.
-- [ ] Update `def model_class_factory_name` in `ee/spec/services/geo/registry_consistency_service_spec.rb`.
+- [ ] Add a custom factory name if needed in `def model_class_factory_name` in `ee/spec/services/geo/registry_consistency_service_spec.rb`.
 - [ ] Update `it 'creates missing registries for each registry class'` in `ee/spec/workers/geo/secondary/registry_consistency_worker_spec.rb`.
 - [ ] Add `cool_widget_registry` to `ActiveSupport::Inflector.inflections` in `config/initializers_before_autoloader/000_inflections.rb`.
 - [ ] Create `ee/spec/factories/geo/cool_widget_registry.rb`:

ee/spec/services/geo/registry_consistency_service_spec.rb

@@ -19,10 +19,7 @@ RSpec.describe Geo::RegistryConsistencyService, :geo, :use_clean_rails_memory_st
     {
       Geo::DesignRegistry => :project_with_design,
       Geo::MergeRequestDiffRegistry => :external_merge_request_diff,
-      Geo::PackageFileRegistry => :package_file_with_file,
-      Geo::SnippetRepositoryRegistry => :snippet_repository,
-      Geo::TerraformStateVersionRegistry => :terraform_state_version,
-      Geo::PipelineArtifactRegistry => :ci_pipeline_artifact
+      Geo::PackageFileRegistry => :package_file
      }.fetch(registry_class, default_factory_name)
   end