Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
1c904be3
Commit
1c904be3
authored
Jun 01, 2021
by
Cheryl Li
Committed by
Marcel Amirault
Jun 01, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update docs warning about using % of time FF rollouts
parent
016b001a
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
9 additions
and
3 deletions
+9
-3
doc/development/feature_flags/controls.md
doc/development/feature_flags/controls.md
+9
-3
No files found.
doc/development/feature_flags/controls.md
View file @
1c904be3
...
...
@@ -213,9 +213,6 @@ actors.
Feature
.
enabled?
(
:some_feature
,
group
)
```
**Percentage of time**
rollout is not a good idea if what you want is to make sure a feature
is always on or off to the users. In that case,
**Percentage of actors**
rollout is a better method.
Lastly, to verify that the feature is deemed stable in as many cases as possible,
you should fully roll out the feature by enabling the flag
**globally**
by running:
...
...
@@ -226,6 +223,15 @@ you should fully roll out the feature by enabling the flag **globally** by runni
This changes the feature flag state to be
**enabled**
always, which overrides the
existing gates (e.g.
`--group=gitlab-org`
) in the above processes.
##### Percentage of actors vs percentage of time rollouts
If you want to make sure a feature is always on or off for users, use a
**Percentage of actors**
rollout. Avoid using percentage of _time_ rollouts in this case.
A percentage of _time_ rollout can introduce inconsistent behavior when
`Feature.enabled?`
is used multiple times in the code because the feature flag value is randomized each time
`Feature.enabled?`
is called on your code path.
##### Disabling feature flags
To disable a feature flag that has been globally enabled you can run:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment