Merge branch '224038-fix-user_sees_sidebar_spec' into 'master'

Fix user_sees_sidebar_spec when vue_issuables_list ff is off

See merge request gitlab-org/gitlab!38415

app/views/projects/issues/_issues.html.haml

-- if Feature.enabled?(:vue_issuables_list, @project)
+- is_project_overview = local_assigns.fetch(:is_project_overview, false)
+
+- if Feature.enabled?(:vue_issuables_list, @project) && !is_project_overview
   - data_endpoint = local_assigns.fetch(:data_endpoint, expose_path(api_v4_projects_issues_path(id: @project.id)))
   - default_empty_state_meta = { create_issue_path: new_project_issue_path(@project), svg_path: image_path('illustrations/issues.svg') }
   - data_empty_state_meta = local_assigns.fetch(:data_empty_state_meta, default_empty_state_meta)

spec/features/projects/user_sees_sidebar_spec.rb

@@ -6,10 +6,6 @@ RSpec.describe 'Projects > User sees sidebar' do
   let(:user) { create(:user) }
   let(:project) { create(:project, :private, public_builds: false, namespace: user.namespace) }
 
-  before do
-    stub_feature_flags(vue_issuables_list: false)
-  end
-
   # NOTE: See documented behaviour https://design.gitlab.com/regions/navigation#contextual-navigation
   context 'on different viewports', :js do
     include MobileHelpers
@@ -134,6 +130,7 @@ RSpec.describe 'Projects > User sees sidebar' do
 
   context 'as guest' do
     let(:guest) { create(:user) }
+    let!(:issue) { create(:issue, :opened, project: project, author: guest) }
 
     before do
       project.add_guest(guest)