Merge branch 'remove_store_instance_statistics_measurements_ff' into 'master'

Remove store_instance_statistics_measurements FF

See merge request gitlab-org/gitlab!44566

app/workers/analytics/instance_statistics/count_job_trigger_worker.rb

@@ -14,8 +14,6 @@ module Analytics
       idempotent!
 
       def perform
-        return if Feature.disabled?(:store_instance_statistics_measurements, default_enabled: true)
-
         recorded_at = Time.zone.now
 
         worker_arguments = Gitlab::Analytics::InstanceStatistics::WorkersArgumentBuilder.new(

changelogs/unreleased/remove_store_instance_statistics_measurements_ff.yml

+---
+title: Remove the `store_instance_statistics_measurements` feature flag
+merge_request: 44566
+author:
+type: changed

config/feature_flags/development/store_instance_statistics_measurements.yml

----
-name: store_instance_statistics_measurements
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/41300
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/247871
-group: group::analytics
-type: development
-default_enabled: true

spec/workers/analytics/instance_statistics/count_job_trigger_worker_spec.rb

@@ -14,16 +14,4 @@ RSpec.describe Analytics::InstanceStatistics::CountJobTriggerWorker do
       expect(Analytics::InstanceStatistics::CounterJobWorker.jobs.count).to eq(expected_count)
     end
   end
-
-  context 'when the `store_instance_statistics_measurements` feature flag is off' do
-    before do
-      stub_feature_flags(store_instance_statistics_measurements: false)
-    end
-
-    it 'does not trigger any CounterJobWorker job' do
-      subject.perform
-
-      expect(Analytics::InstanceStatistics::CounterJobWorker.jobs.count).to eq(0)
-    end
-  end
 end