Commit a17818c1 authored by Bob Van Landuyt's avatar Bob Van Landuyt

Merge branch 'issue#325836-fix-empty-line-after-let-it-be-gitlab-github-import' into 'master'

Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab/github_import

See merge request gitlab-org/gitlab!58256
parents dd84b326 691eaacf
......@@ -806,9 +806,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
- spec/lib/gitlab/git_access_project_spec.rb
- spec/lib/gitlab/git_access_wiki_spec.rb
- spec/lib/gitlab/gitaly_client/operation_service_spec.rb
- spec/lib/gitlab/github_import/importer/pull_request_merged_by_importer_spec.rb
- spec/lib/gitlab/github_import/importer/pull_request_review_importer_spec.rb
- spec/lib/gitlab/github_import/milestone_finder_spec.rb
- spec/lib/gitlab/gl_repository/repo_type_spec.rb
- spec/lib/gitlab/group_search_results_spec.rb
- spec/lib/gitlab/hook_data/issue_builder_spec.rb
......
---
title: Fix EmptyLineAfterFinalLetItBe offenses spec/lib/gitlab/github_import
merge_request: 58256
author: Huzaifa Iftikhar @huzaifaiftikhar
type: fixed
......@@ -4,6 +4,7 @@ require 'spec_helper'
RSpec.describe Gitlab::GithubImport::Importer::PullRequestMergedByImporter, :clean_gitlab_redis_cache do
let_it_be(:merge_request) { create(:merged_merge_request) }
let(:project) { merge_request.project }
let(:merged_at) { Time.new(2017, 1, 1, 12, 00).utc }
let(:client_double) { double(user: double(id: 999, login: 'merger', email: 'merger@email.com')) }
......
......@@ -6,6 +6,7 @@ RSpec.describe Gitlab::GithubImport::Importer::PullRequestReviewImporter, :clean
using RSpec::Parameterized::TableSyntax
let_it_be(:merge_request) { create(:merge_request) }
let(:project) { merge_request.project }
let(:client_double) { double(user: double(id: 999, login: 'author', email: 'author@email.com')) }
let(:submitted_at) { Time.new(2017, 1, 1, 12, 00).utc }
......
......@@ -5,6 +5,7 @@ require 'spec_helper'
RSpec.describe Gitlab::GithubImport::MilestoneFinder, :clean_gitlab_redis_cache do
let_it_be(:project) { create(:project) }
let_it_be(:milestone) { create(:milestone, project: project) }
let(:finder) { described_class.new(project) }
describe '#id_for' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment