Merge branch 'issue#325836-fix-empty-line-after-let-it-be-gitlab-github-import' into 'master'

Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab/github_import

See merge request gitlab-org/gitlab!58256

.rubocop_manual_todo.yml

@@ -806,9 +806,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - spec/lib/gitlab/git_access_project_spec.rb
     - spec/lib/gitlab/git_access_wiki_spec.rb
     - spec/lib/gitlab/gitaly_client/operation_service_spec.rb
-    - spec/lib/gitlab/github_import/importer/pull_request_merged_by_importer_spec.rb
-    - spec/lib/gitlab/github_import/importer/pull_request_review_importer_spec.rb
-    - spec/lib/gitlab/github_import/milestone_finder_spec.rb
     - spec/lib/gitlab/gl_repository/repo_type_spec.rb
     - spec/lib/gitlab/group_search_results_spec.rb
     - spec/lib/gitlab/hook_data/issue_builder_spec.rb

changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-gitlab-github-import.yml

+---
+title: Fix EmptyLineAfterFinalLetItBe offenses spec/lib/gitlab/github_import
+merge_request: 58256
+author: Huzaifa Iftikhar @huzaifaiftikhar
+type: fixed

spec/lib/gitlab/github_import/importer/pull_request_merged_by_importer_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Gitlab::GithubImport::Importer::PullRequestMergedByImporter, :clean_gitlab_redis_cache do
   let_it_be(:merge_request) { create(:merged_merge_request) }
+
   let(:project) { merge_request.project }
   let(:merged_at) { Time.new(2017, 1, 1, 12, 00).utc }
   let(:client_double) { double(user: double(id: 999, login: 'merger', email: 'merger@email.com')) }

spec/lib/gitlab/github_import/importer/pull_request_review_importer_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe Gitlab::GithubImport::Importer::PullRequestReviewImporter, :clean
   using RSpec::Parameterized::TableSyntax
 
   let_it_be(:merge_request) { create(:merge_request) }
+
   let(:project) { merge_request.project }
   let(:client_double) { double(user: double(id: 999, login: 'author', email: 'author@email.com')) }
   let(:submitted_at) { Time.new(2017, 1, 1, 12, 00).utc }

spec/lib/gitlab/github_import/milestone_finder_spec.rb

@@ -5,6 +5,7 @@ require 'spec_helper'
 RSpec.describe Gitlab::GithubImport::MilestoneFinder, :clean_gitlab_redis_cache do
   let_it_be(:project) { create(:project) }
   let_it_be(:milestone) { create(:milestone, project: project) }
+
   let(:finder) { described_class.new(project) }
 
   describe '#id_for' do