Merge branch 'djadmin-scanner-profile-revert-submit-button' into 'master'

Revert: Enable submit by default in DAST Scanner Profile

See merge request gitlab-org/gitlab!59245

ee/app/assets/javascripts/security_configuration/dast_scanner_profiles/components/dast_scanner_profile_form.vue

@@ -141,7 +141,7 @@ export default {
       );
     },
     isSubmitDisabled() {
-      return this.isPolicyProfile;
+      return this.formHasErrors || this.requiredFieldEmpty || this.isPolicyProfile;
     },
     isPolicyProfile() {
       return Boolean(this.profile?.referencedInSecurityPolicies?.length);

ee/changelogs/unreleased/djadmin-scanner-profile-composable.yml

----
-title: Always display submit button for DAST Scanner Profile form
-merge_request: 56928
-author:
-type: changed

ee/spec/frontend/security_configuration/dast_scanner_profiles_form/components/dast_scanner_profiles_form_spec.js

@@ -94,18 +94,18 @@ describe('DAST Scanner Profile', () => {
       createComponent();
     });
 
-    describe('is enabled even if', () => {
+    describe('is disabled if', () => {
       it('form contains errors', async () => {
         findProfileNameInput().vm.$emit('input', profileName);
         await findSpiderTimeoutInput().vm.$emit('input', '12312');
-        expect(findSubmitButton().props('disabled')).toBe(false);
+        expect(findSubmitButton().props('disabled')).toBe(true);
       });
 
       it('at least one field is empty', async () => {
         findProfileNameInput().vm.$emit('input', '');
         await findSpiderTimeoutInput().vm.$emit('input', spiderTimeout);
         await findTargetTimeoutInput().vm.$emit('input', targetTimeout);
-        expect(findSubmitButton().props('disabled')).toBe(false);
+        expect(findSubmitButton().props('disabled')).toBe(true);
       });
     });