An error occurred fetching the project authors.
  1. 10 May, 2019 1 commit
  2. 12 Apr, 2019 1 commit
  3. 05 Apr, 2019 1 commit
    • Sam Bigelow's avatar
      Improve diff navigation header · bf47270e
      Sam Bigelow authored
      - Compare versions header is full width except in the unified diff mode
      with no tree sidebar
        - Bar is always full width, but the content within stays centered when
      unified and no tree sidebar
      - File header is the same height as the "Compare versions header"
      - aligns with the design system grid guidelines => 56px
      - Diff file headers use a button group, switch icon order to open file
      externally being the last option, all buttons will become icon buttons
      (icon delivery by @dimitrieh)
      - If a file header becomes sticky no rounded corner/double border
      problem is visible anymore
      bf47270e
  4. 19 Mar, 2019 1 commit
  5. 27 Feb, 2019 1 commit
    • Denys Mishunov's avatar
      Set up basic keyboard next/previous navigation in diff list · 0aff8e27
      Denys Mishunov authored
      Mousetrap is used as the help-tool to listen to keystrokes
      
      Added currentDiffIndex getter to store that holds
      the index of currently active diff file in the list
      
      Instead of computing it on the component, we will take advantage of it
      being available for all components in DiffsApp
      
      Testing keyboard navigation and jumpToFile()
      0aff8e27
  6. 15 Feb, 2019 1 commit
  7. 05 Feb, 2019 1 commit
  8. 13 Dec, 2018 2 commits
  9. 30 Nov, 2018 1 commit
  10. 22 Nov, 2018 1 commit
  11. 20 Nov, 2018 1 commit
  12. 16 Nov, 2018 1 commit
  13. 14 Nov, 2018 1 commit
    • Phil Hughes's avatar
      Made diff & note data consistent · 234563ba
      Phil Hughes authored
      This caused many pain points when working with it.
      Part of the data was camel cased the other snake case.
      Other parts where snake case & then getting converted in components,
      this conversion has the potential for leaking memory.
      
      This changes that & makes it consistent with what it returned from the
      API, snake case.
      234563ba
  14. 09 Nov, 2018 1 commit
  15. 07 Nov, 2018 1 commit
  16. 05 Nov, 2018 1 commit
    • Phil Hughes's avatar
      Re-implemented image commenting on diffs · f7df9ddb
      Phil Hughes authored
      This re-implements image commenting in merge request diffs.
      This feature was previously lost when the merge request
      page was refactored into Vue.
      
      With this, we create an overlay component. The overlay
      component handles displaying the comment badges
      and the comment form badge.
      Badges are displayed based on the position attribute
      sent with the discussion.
      
      Comment forms for diff files are controlled through
      a different state property. This is so we don't
      tie comment forms to diff files directly creating
      deep nested state. Instead we create a flat array
      which holds the file hash & the X & Y position of
      the comment form.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/48956
      f7df9ddb
  17. 30 Oct, 2018 1 commit
  18. 25 Oct, 2018 1 commit
    • Phil Hughes's avatar
      Update the state, not a param · 0fba7cca
      Phil Hughes authored
      Also fixed a bug where discussions wouldn't be assigned to a line
      when switching from discussion tab to changes tab
      0fba7cca
  19. 24 Oct, 2018 1 commit
  20. 06 Oct, 2018 1 commit
  21. 03 Oct, 2018 1 commit
    • Phil Hughes's avatar
      Added file tree to merge request diffs · 33c4c5b8
      Phil Hughes authored
      This file tree displays all the diff files in a tree like format
      Each file is taken and converted into a tree with folders
      Each folder can be toggled open & closed
      Clicking a file will scroll to the diff file & highlight with a glow affect
      
      Searching the tree list will search only files & return a list of the
      files without any folders
      
      Each file row contains an icon to show changed, new file or deleted
      Each row will also contain the added & removed lines count
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/14249
      33c4c5b8
  22. 26 Sep, 2018 1 commit
  23. 11 Sep, 2018 1 commit
  24. 07 Sep, 2018 5 commits
  25. 08 Aug, 2018 2 commits
  26. 17 Jul, 2018 1 commit
  27. 12 Jul, 2018 1 commit
  28. 06 Jul, 2018 1 commit
    • Filipa Lacerda's avatar
      Transforms diffs module to a namespaced one to avoid console error due to rewire export. · 156a9d39
      Filipa Lacerda authored
      Detailed: Because of rewire we need to export a default empty object in our actions to prevent it to export the wrong default in karma. Vuex getters are global, and because the Vuex store uses several non namespaced moduled, there was already a getter named default, due to the same empty export.
      In order to solve it I chose to namespace the module. Could also be fixed by importing the getters explicitly instead of all of them.
      156a9d39
  29. 30 Jun, 2018 1 commit
  30. 29 Jun, 2018 1 commit
  31. 26 Jun, 2018 1 commit
  32. 21 Jun, 2018 1 commit