Merge branch '53954-resolved-non-diff-discussions-on-merge-requests-no-longer-show-who-resolved-them-and-when-at-a-glance' into 'master'

Show who resolved non-diff discussions

Closes #53954

See merge request gitlab-org/gitlab-ce!23449

Add new predefined variable CI_COMMIT_SHORT_SHA

Closes #48061

See merge request gitlab-org/gitlab-ce!23822

Add externalized strings for clusters error messages

Closes #45310

See merge request gitlab-org/gitlab-ce!23753

Updates gitlab-svg dependency

See merge request gitlab-org/gitlab-ce!23871

- Add resolution text to notes in MR Discussions
- Use slots to do so

Revert "Merge branch 'auto_devops_kubernetes_active' into 'master'"

See merge request gitlab-org/gitlab-ce!23826

Improve & clean up the PROCESS.md doc

See merge request gitlab-org/gitlab-ce!23769

Remove the project_cleanup feature flag

Closes #55230

See merge request gitlab-org/gitlab-ce!23814

Clarify messaging on what fails for too many failed lines

See merge request gitlab-org/gitlab-ce!23862

Fixed duplicated inline diff discussions

Closes #55388

See merge request gitlab-org/gitlab-ce!23843

Change `page_filter_path` to not exclude `label_name` by default

See merge request gitlab-org/gitlab-ce!23825

Fix deprecation: Comparing equality between ActionController::Parameters and a Hash is deprecated

See merge request gitlab-org/gitlab-ce!23855

Remove deprecated ActionDispatch::ParamsParser

See merge request gitlab-org/gitlab-ce!23848

Merge branch '55433-un-revert-https-gitlab-com-gitlab-org-gitlab-ce-commit-00acef43-revert' into 'master'

Resolve "Un-revert https://gitlab.com/gitlab-org/gitlab-ce/commit/00acef434031b5dc0bf39576a9e83802c7806842 revert"

Closes #55433

See merge request gitlab-org/gitlab-ce!23861

Resolve "User profile page: Enhance horizonal whitespace between Overview columns"

Closes #55252

See merge request gitlab-org/gitlab-ce!23803

Signed-off-by: Rémy Coutable <remy@rymai.me>

Remove rails4 specific code

See merge request gitlab-org/gitlab-ce!23847

Clearly state web terminal is not supported at all on GitLab.com

See merge request gitlab-org/gitlab-ce!23821

Show clusters of ancestors in cluster list page

Closes #34758

See merge request gitlab-org/gitlab-ce!22996

Resolve "Encoding issue with the user centric tooltips"

Closes #55276

See merge request gitlab-org/gitlab-ce!23794

Passing the separator argument as a positional parameter is deprecated

See merge request gitlab-org/gitlab-ce!23334

Added Cop for injecting EE modules

See merge request gitlab-org/gitlab-ce!23802

CE-EE parity for prepare_build script

See merge request gitlab-org/gitlab-ce!23819

Add Registry S3 chunksize troubleshooting section

See merge request gitlab-org/gitlab-ce!23841

Fix RSpec/HookArgument rubocop offense

See merge request gitlab-org/gitlab-ce!23776

This reverts commit 00acef43.

This reverts merge request
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22929

Given the note is about how to interpret ancestor clusters, use the
finder which actually knows if there are any ancestor clusters to find
out if the note should be shown, rather than passing the same info via a
view to a helper

Added note about Kaminari.paginate_array

Link to followup issue too

This is in addtion to the can checks we have in the controller, as a
finder can be used elsewhere in the future.

Part of the code such as #show_path is already present on the presenter.
Also avoid having code in two places (helper and presenter)

Sanitize and assert html_safe. Additional layer of defense - on top of
GitLab already requiring group names to be composed of small set of
chars A-Z, - and spaces.

Only link to cluster if user can read cluster

Make clear that arg is a GroupClusterablePresenter

Add more specs for completeness

- Use sprite_icon instead of hardcoded html
- Use a more descriptive method name
- Changes specs to use html_safe matcher

- Moves logic into ClustersHelp
- Add CSS to ensure compatibility with EE view.

Add specs

Make link clear in note box

Also update strings to be translatable