- 17 Dec, 2018 22 commits
-
-
Jan Provaznik authored
Epic state uses enum for saving state (other issuables use string), because of this inconsistency we override `count_key` which should return state as string converted to symbol (.e.g. :closed). In rails 5 these integer states are automatically converted to strings by Active Record. But if subquery is used (to optimize searching), Active Record doesn't convert state into string automatically (probably it can not deal with the more complex query). This means that epic state can be either integer (if subquery is used) or string (if AR converted state to string automatically), so in `count_key` we should convert state into string only if it's an integer.
-
Rémy Coutable authored
EE: Remove rails4 specific code See merge request gitlab-org/gitlab-ee!8870
-
Achilleas Pipinellis authored
Document omnibus config for smartcard auth See merge request gitlab-org/gitlab-ee!8795
-
Achilleas Pipinellis authored
Docs: follow up from "Clearly state web terminal is not supported at all on GitLab.com" Closes #8866 See merge request gitlab-org/gitlab-ee!8866
-
Marcia Ramos authored
-
Achilleas Pipinellis authored
Merge branch 'docs/8884-update-group-security-dashboard-documentation-to-remove-auto-devops-incompatibility' into 'master' Resolve "Update Group Security Dashboard documentation to remove Auto DevOps incompatibility" Closes #8884 See merge request gitlab-org/gitlab-ee!8878
-
Fabio Busatto authored
-
GitLab Bot authored
-
Dmitriy Zaporozhets authored
Show clusters of ancestors in cluster list page Closes #34758 See merge request gitlab-org/gitlab-ce!22996
-
Tim Zallmann authored
Resolve "Encoding issue with the user centric tooltips" Closes #55276 See merge request gitlab-org/gitlab-ce!23794
-
GitLab Bot authored
-
Rémy Coutable authored
Passing the separator argument as a positional parameter is deprecated See merge request gitlab-org/gitlab-ce!23334
-
Achilleas Pipinellis authored
Remove unnecessary warning and add other minor improvements See merge request gitlab-org/gitlab-ee!8722
-
Evan Read authored
-
Rémy Coutable authored
Added Cop for injecting EE modules See merge request gitlab-org/gitlab-ce!23802
-
Rémy Coutable authored
EE: Added Cop for injecting EE modules See merge request gitlab-org/gitlab-ee!8843
-
Rémy Coutable authored
CE-EE parity for prepare_build script See merge request gitlab-org/gitlab-ce!23819
-
Rémy Coutable authored
[EE] CE-EE parity for prepare_build script See merge request gitlab-org/gitlab-ee!8846
-
GitLab Bot authored
-
Achilleas Pipinellis authored
Add Registry S3 chunksize troubleshooting section See merge request gitlab-org/gitlab-ce!23841
-
Rémy Coutable authored
Fix RSpec/HookArgument rubocop offense See merge request gitlab-org/gitlab-ce!23776
-
Rémy Coutable authored
Fix RSpec/HookArgument rubocop offense See merge request gitlab-org/gitlab-ee!8856
-
- 16 Dec, 2018 13 commits
-
-
Thong Kuah authored
Given the note is about how to interpret ancestor clusters, use the finder which actually knows if there are any ancestor clusters to find out if the note should be shown, rather than passing the same info via a view to a helper Added note about Kaminari.paginate_array Link to followup issue too
-
Thong Kuah authored
This is in addtion to the can checks we have in the controller, as a finder can be used elsewhere in the future.
-
Thong Kuah authored
Part of the code such as #show_path is already present on the presenter. Also avoid having code in two places (helper and presenter) Sanitize and assert html_safe. Additional layer of defense - on top of GitLab already requiring group names to be composed of small set of chars A-Z, - and spaces. Only link to cluster if user can read cluster Make clear that arg is a GroupClusterablePresenter Add more specs for completeness
-
Mayra Cabrera authored
- Use sprite_icon instead of hardcoded html - Use a more descriptive method name - Changes specs to use html_safe matcher
-
Mayra Cabrera authored
- Moves logic into ClustersHelp - Add CSS to ensure compatibility with EE view.
-
Thong Kuah authored
Add specs
-
Mike Greiling authored
Make link clear in note box Also update strings to be translatable
-
Mike Greiling authored
-
Mike Greiling authored
-
Thong Kuah authored
Show both the cluster(s) of the clusterable, and the cluster(s) of ancestor groups.
-
Jasper Maes authored
-
GitLab Bot authored
-
Stan Hu authored
Merge branch '55402-broken-master-karma-test-failing-in-spec-javascripts-boards-components-issue_due_date_spec-js' into 'master' Resolve "Broken master: karma test failing in spec/javascripts/boards/components/issue_due_date_spec.js" Closes #55402 See merge request gitlab-org/gitlab-ce!23845
-
- 15 Dec, 2018 5 commits
-
-
GitLab Bot authored
-
Nick Thomas authored
Fixed upload file button not working for repo cleanup See merge request gitlab-org/gitlab-ee!8858
-
Nick Thomas authored
Display empty files properly on MR diffs Closes #54786 See merge request gitlab-org/gitlab-ce!23671
-
Martin Wortschack authored
-
GitLab Bot authored
-