- 11 May, 2018 36 commits
-
-
Robert Speicher authored
Resolve "[Rails5] Fix spec/controllers/projects/jobs_controller_spec.rb" Closes #46227 See merge request gitlab-org/gitlab-ce!18891
-
Robert Speicher authored
Replace the `project/merge_requests/references.feature` spinach test with an rspec analog See merge request gitlab-org/gitlab-ce!18794
-
Lin Jen-Shin authored
Merge branch 'docs-fixed-typo-microsoft-teams-slug' into 'master' See merge request gitlab-org/gitlab-ce!18908
-
Achilleas Pipinellis authored
Fix: API Documentation typo on Microsoft Teams slug See merge request gitlab-org/gitlab-ee!5412
-
Douwe Maan authored
Enforce terms acceptance before configuring 2FA Closes #46256 See merge request gitlab-org/gitlab-ce!18896
-
Douwe Maan authored
Block access to API & git when terms are enforced Closes #45849 See merge request gitlab-org/gitlab-ce!18816
-
Kamil Trzciński authored
Vendor Auto DevOps template See merge request gitlab-org/gitlab-ce!18876
-
Fabio Busatto authored
-
Phil Hughes authored
Resolve "Remove modal box confirmation when retrying a pipeline" Closes #45715 See merge request gitlab-org/gitlab-ce!18879
-
Filipa Lacerda authored
-
Douwe Maan authored
Remove Gitlab::RepoPath.strip_storage_path See merge request gitlab-org/gitlab-ce!18904
-
Bob Van Landuyt authored
Allow builds that have been triggered by a user before terms were enforced access to git. That way the builds can complete as usual.
-
Bob Van Landuyt authored
This prevents a redirect loop when a user has to enable 2FA and accept the terms. Now they will need to accept the terms, then enable 2FA, or any other requirements.
-
Zeger-Jan van de Weg authored
This used to be executed because of the post receive worker, but this uses Gitlab::GlRepository.parse now. So this removes dead code and reduces the number of calls on `#legacy_storage_path`.
-
Douwe Maan authored
Add 2FA filter to group members page See merge request gitlab-org/gitlab-ce!18483
-
Douwe Maan authored
Wiki Find Page to opt_out Closes gitaly#894 See merge request gitlab-org/gitlab-ce!18895
-
Douwe Maan authored
Resolve "[Rails5] Bump Rails5 to 5.0.7" Closes #46234 See merge request gitlab-org/gitlab-ce!18888
-
Douwe Maan authored
Resolve "[Rails5] Fix `NoMethodError: undefined method `-' for "3":String`" Closes #46233 See merge request gitlab-org/gitlab-ce!18892
-
Douwe Maan authored
Resolve "[Rails5] Fix `Route source can't be blank`" Closes #46228 See merge request gitlab-org/gitlab-ce!18890
-
Douwe Maan authored
Resolve "[Rails5] Fix app/views/groups/issues.html.haml" Closes #46225 See merge request gitlab-org/gitlab-ce!18889
-
Tim Zallmann authored
Support `js-close` as a removal class in UserCallout See merge request gitlab-org/gitlab-ce!18790
-
Lukas Eipert authored
-
Filipa Lacerda authored
Fixed none merge request files not being openable in the web IDE See merge request gitlab-org/gitlab-ce!18881
-
Kamil Trzciński authored
Backport EE specific cluster spec changes to CE See merge request gitlab-org/gitlab-ce!18866
-
Kamil Trzciński authored
Add missing tooltip to creation date on container registry overview Closes #34229 See merge request gitlab-org/gitlab-ce!18767
-
Kamil Trzciński authored
Remove method call to deprecated method See merge request gitlab-org/gitlab-ce!18815
-
Kamil Trzciński authored
Ensure runner_type is updated correctly when assigning shared runner to project See merge request gitlab-org/gitlab-ce!18874
-
Tim Zallmann authored
Resolve "Terms acceptance dropdown menu" Closes #46210 See merge request gitlab-org/gitlab-ce!18862
-
Phil Hughes authored
Resolve "Move external link icon to end of link instead of front" Closes #40725 See merge request gitlab-org/gitlab-ce!18828
-
Zeger-Jan van de Weg authored
Closes https://gitlab.com/gitlab-org/gitaly/issues/894
-
Achilleas Pipinellis authored
Add documentation for Runner Registration API Closes #42067 See merge request gitlab-org/gitlab-ce!16484
-
Achilleas Pipinellis authored
CE: Helm init before helm repo add See merge request gitlab-org/gitlab-ce!18882
-
Zeger-Jan van de Weg authored
Given the settings initializer creates Gitaly Storage Settings objects already, the calls to path can be moved to that initializer.
-
blackst0ne authored
In Rails 5 the `per_page` argument came from `params` is String but an Integer is expected. This commit explicitly converts `per_page` to an Integer. It fixes the errors like: ``` 1) Groups::ChildrenController GET #index for subgroups filtering children succeeds if multiple pages contain matching subgroups Failure/Error: hash[page] = second_collection.page(second_collection_page) .per(per_page - paginated_first_collection(page).size) .padding(offset) NoMethodError: undefined method `-' for "3":String Did you mean? -@ # ./lib/gitlab/multi_collection_paginator.rb:42:in `block in paginated_second_collection' # ./lib/gitlab/multi_collection_paginator.rb:46:in `paginated_second_collection' # ./lib/gitlab/multi_collection_paginator.rb:14:in `paginate' # ./app/finders/group_descendants_finder.rb:52:in `children' # ./app/finders/group_descendants_finder.rb:34:in `execute' # ./app/controllers/groups/children_controller.rb:36:in `setup_children' # ./app/controllers/groups/children_controller.rb:18:in `index' # ./lib/gitlab/i18n.rb:50:in `with_locale' # ./lib/gitlab/i18n.rb:56:in `with_user_locale' # ./app/controllers/application_controller.rb:351:in `set_locale' # ./spec/controllers/groups/children_controller_spec.rb:182:in `block (5 levels) in <top (required)>' # ./spec/spec_helper.rb:198:in `block (2 levels) in <top (required)>' ```
-
blackst0ne authored
In Rails 5.0 `response.content_type` does not return charset which is expected in specs. This commit replaces `response.content_type` with `response.headers["Content-Type"]` in specs.
-
blackst0ne authored
In Rails 5.0 automatic inverse does not work for polymorphic relathionships. It was fixed in Rails 5.2: https://github.com/rails/rails/pull/28808 Until that the `inverse_of: :source` argument should be set explicitly.
-
- 10 May, 2018 4 commits
-
-
blackst0ne authored
Fixes the errors like: ``` ActionView::Template::Error: Attempting to generate a URL from non-sanitized request parameters! An attacker can inject malicious data into the generated URL, such as changing the host. Whitelist and sanitize passed parameters to be secure. ```
-
blackst0ne authored
atomic 1.1.100 was yanked by its author.
-
Clement Ho authored
Resolve "Wiki headings no longer show anchor link" Closes #44956 See merge request gitlab-org/gitlab-ce!18591
-
Stan Hu authored
ShaAttribute crashes with ArgumentError if column doesn't exist See merge request gitlab-org/gitlab-ce!18880
-