Commit c5d19a6e authored by Heiner Kallweit's avatar Heiner Kallweit Committed by David S. Miller

net: convert additional drivers to use phy_do_ioctl

The first batch of driver conversions missed a few cases where we can
use phy_do_ioctl too.
Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4f2c17e0
...@@ -1005,18 +1005,13 @@ static int nb8800_stop(struct net_device *dev) ...@@ -1005,18 +1005,13 @@ static int nb8800_stop(struct net_device *dev)
return 0; return 0;
} }
static int nb8800_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
{
return phy_mii_ioctl(dev->phydev, rq, cmd);
}
static const struct net_device_ops nb8800_netdev_ops = { static const struct net_device_ops nb8800_netdev_ops = {
.ndo_open = nb8800_open, .ndo_open = nb8800_open,
.ndo_stop = nb8800_stop, .ndo_stop = nb8800_stop,
.ndo_start_xmit = nb8800_xmit, .ndo_start_xmit = nb8800_xmit,
.ndo_set_mac_address = nb8800_set_mac_address, .ndo_set_mac_address = nb8800_set_mac_address,
.ndo_set_rx_mode = nb8800_set_rx_mode, .ndo_set_rx_mode = nb8800_set_rx_mode,
.ndo_do_ioctl = nb8800_ioctl, .ndo_do_ioctl = phy_do_ioctl,
.ndo_validate_addr = eth_validate_addr, .ndo_validate_addr = eth_validate_addr,
}; };
......
...@@ -790,9 +790,7 @@ static int octeon_mgmt_ioctl(struct net_device *netdev, ...@@ -790,9 +790,7 @@ static int octeon_mgmt_ioctl(struct net_device *netdev,
case SIOCSHWTSTAMP: case SIOCSHWTSTAMP:
return octeon_mgmt_ioctl_hwtstamp(netdev, rq, cmd); return octeon_mgmt_ioctl_hwtstamp(netdev, rq, cmd);
default: default:
if (netdev->phydev) return phy_do_ioctl(netdev, rq, cmd);
return phy_mii_ioctl(netdev->phydev, rq, cmd);
return -EINVAL;
} }
} }
......
...@@ -509,13 +509,6 @@ ltq_etop_change_mtu(struct net_device *dev, int new_mtu) ...@@ -509,13 +509,6 @@ ltq_etop_change_mtu(struct net_device *dev, int new_mtu)
return 0; return 0;
} }
static int
ltq_etop_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
{
/* TODO: mii-toll reports "No MII transceiver present!." ?!*/
return phy_mii_ioctl(dev->phydev, rq, cmd);
}
static int static int
ltq_etop_set_mac_address(struct net_device *dev, void *p) ltq_etop_set_mac_address(struct net_device *dev, void *p)
{ {
...@@ -616,7 +609,7 @@ static const struct net_device_ops ltq_eth_netdev_ops = { ...@@ -616,7 +609,7 @@ static const struct net_device_ops ltq_eth_netdev_ops = {
.ndo_stop = ltq_etop_stop, .ndo_stop = ltq_etop_stop,
.ndo_start_xmit = ltq_etop_tx, .ndo_start_xmit = ltq_etop_tx,
.ndo_change_mtu = ltq_etop_change_mtu, .ndo_change_mtu = ltq_etop_change_mtu,
.ndo_do_ioctl = ltq_etop_ioctl, .ndo_do_ioctl = phy_do_ioctl,
.ndo_set_mac_address = ltq_etop_set_mac_address, .ndo_set_mac_address = ltq_etop_set_mac_address,
.ndo_validate_addr = eth_validate_addr, .ndo_validate_addr = eth_validate_addr,
.ndo_set_rx_mode = ltq_etop_set_multicast_list, .ndo_set_rx_mode = ltq_etop_set_multicast_list,
......
...@@ -1344,15 +1344,6 @@ static int pxa168_smi_write(struct mii_bus *bus, int phy_addr, int regnum, ...@@ -1344,15 +1344,6 @@ static int pxa168_smi_write(struct mii_bus *bus, int phy_addr, int regnum,
return 0; return 0;
} }
static int pxa168_eth_do_ioctl(struct net_device *dev, struct ifreq *ifr,
int cmd)
{
if (dev->phydev)
return phy_mii_ioctl(dev->phydev, ifr, cmd);
return -EOPNOTSUPP;
}
#ifdef CONFIG_NET_POLL_CONTROLLER #ifdef CONFIG_NET_POLL_CONTROLLER
static void pxa168_eth_netpoll(struct net_device *dev) static void pxa168_eth_netpoll(struct net_device *dev)
{ {
...@@ -1387,7 +1378,7 @@ static const struct net_device_ops pxa168_eth_netdev_ops = { ...@@ -1387,7 +1378,7 @@ static const struct net_device_ops pxa168_eth_netdev_ops = {
.ndo_set_rx_mode = pxa168_eth_set_rx_mode, .ndo_set_rx_mode = pxa168_eth_set_rx_mode,
.ndo_set_mac_address = pxa168_eth_set_mac_address, .ndo_set_mac_address = pxa168_eth_set_mac_address,
.ndo_validate_addr = eth_validate_addr, .ndo_validate_addr = eth_validate_addr,
.ndo_do_ioctl = pxa168_eth_do_ioctl, .ndo_do_ioctl = phy_do_ioctl,
.ndo_change_mtu = pxa168_eth_change_mtu, .ndo_change_mtu = pxa168_eth_change_mtu,
.ndo_tx_timeout = pxa168_eth_tx_timeout, .ndo_tx_timeout = pxa168_eth_tx_timeout,
#ifdef CONFIG_NET_POLL_CONTROLLER #ifdef CONFIG_NET_POLL_CONTROLLER
......
...@@ -1939,9 +1939,7 @@ static int sxgbe_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) ...@@ -1939,9 +1939,7 @@ static int sxgbe_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
case SIOCGMIIPHY: case SIOCGMIIPHY:
case SIOCGMIIREG: case SIOCGMIIREG:
case SIOCSMIIREG: case SIOCSMIIREG:
if (!dev->phydev) ret = phy_do_ioctl(dev, rq, cmd);
return -EINVAL;
ret = phy_mii_ioctl(dev->phydev, rq, cmd);
break; break;
default: default:
break; break;
......
...@@ -1740,12 +1740,6 @@ static int netsec_netdev_set_features(struct net_device *ndev, ...@@ -1740,12 +1740,6 @@ static int netsec_netdev_set_features(struct net_device *ndev,
return 0; return 0;
} }
static int netsec_netdev_ioctl(struct net_device *ndev, struct ifreq *ifr,
int cmd)
{
return phy_mii_ioctl(ndev->phydev, ifr, cmd);
}
static int netsec_xdp_xmit(struct net_device *ndev, int n, static int netsec_xdp_xmit(struct net_device *ndev, int n,
struct xdp_frame **frames, u32 flags) struct xdp_frame **frames, u32 flags)
{ {
...@@ -1830,7 +1824,7 @@ static const struct net_device_ops netsec_netdev_ops = { ...@@ -1830,7 +1824,7 @@ static const struct net_device_ops netsec_netdev_ops = {
.ndo_set_features = netsec_netdev_set_features, .ndo_set_features = netsec_netdev_set_features,
.ndo_set_mac_address = eth_mac_addr, .ndo_set_mac_address = eth_mac_addr,
.ndo_validate_addr = eth_validate_addr, .ndo_validate_addr = eth_validate_addr,
.ndo_do_ioctl = netsec_netdev_ioctl, .ndo_do_ioctl = phy_do_ioctl,
.ndo_xdp_xmit = netsec_xdp_xmit, .ndo_xdp_xmit = netsec_xdp_xmit,
.ndo_bpf = netsec_xdp, .ndo_bpf = netsec_xdp,
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment