- 23 Oct, 2011 39 commits
-
-
Mark Einon authored
In nic_send_packet(), by the time 'frag' is checked to be zero, it never is - the for loop has been entered (as nr_frags is always > 0) and frag has been incremented at least once. Remove the check and associated error return. Signed-off-by:
Mark Einon <mark.einon@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Mark Einon authored
- Whitespace changes to appease checkpatch warnings - Removed unneeded braces around single line if/else Signed-off-by:
-
Mark Einon authored
Moved functions in et131x.c file to remove the forward declarations of: et131x_rx_dma_disable et131x_rx_dma_enable et131x_init_send et131x_tx_dma_enable Signed-off-by:
-
Mark Einon authored
Moved functions in et131x.c file to remove the forward declarations of: et1310_in_phy_coma et1310_phy_access_mii_bit et131x_phy_mii_read et131x_mii_write et131x_rx_dma_memory_free Signed-off-by:
-
Mark Einon authored
Moved functions in et131x.c file to remove the forward declarations of: et1310_setup_device_for_multicast et1310_setup_device_for_unicast et131x_up et131x_down et131x_enable_txrx et131x_disable_txrx Signed-off-by:
-
Mark Einon authored
Moved functions in et131x.c file to remove the following forward declarations: et131x_soft_reset et131x_isr_handler et131x_device_alloc Signed-off-by:
-
Mark Einon authored
Also associated function movements within et131x.c file Signed-off-by:
-
Mark Einon authored
Moved functions in et131x.c file to remove the following forward declarations: et131x_align_allocated_memory et131x_disable_interrupts et131x_enable_interrupts et131x_error_timer_handler Signed-off-by:
-
Mark Einon authored
tx_ring.recv_packet_pool is unused, even in the original driver code. Removed. Signed-off-by:
-
Mark Einon authored
pci_find_capability is called, but not used and is now redundant as power management is handled elsewhere. Removed. Signed-off-by:
-
Mark Einon authored
This call doesn't do anything useful - only warns on the receive list being empty, so removed it. Signed-off-by:
-
Mark Einon authored
rx_ring.recv_buffer_pool is unused, even in the original driver code. Remove from stuct, and also remove some comments regarding it. Signed-off-by:
-
Kevin McKinney authored
This patch fixes three initialization errors. One is an incorrect initialization of a static variable. The other two are incorrect initializations in an if statement. These errors were found by checkpatch.pl. Signed-off-by:
Kevin McKinney <klmckinney1@gmail.com> Signed-off-by:
-
Kevin McKinney authored
This patch fixes multiple coding style issues in file, InterfaceDld.c, found by checkpatch.pl. Signed-off-by:
-
Lars-Peter Clausen authored
This patch adds support for the Analog Devices AD5360, AD5361, AD5362, AD5363, AD5370, AD5371, AD5372, AD5373 multi-channel digital-to-analog converters. Signed-off-by:
Lars-Peter Clausen <lars@metafoo.de> Acked-by:
Jonathan Cameron <jic23@cam.ac.uk> Acked-by:
Michael Hennerich <michael.hennerich@analog.com> Signed-off-by:
-
Lars-Peter Clausen authored
Signed-off-by:
-
Dan Carpenter authored
There were no range checks in the original code so the user could write past the end of the array. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Dan Carpenter authored
The indents didn't line up at all in the original code. I also fixed a bunch of other white issues as I went along. I changed the comment style and removed some commented out code. Signed-off-by:
-
Dan Carpenter authored
We need to verify that we're not writing past the end of the array. Signed-off-by:
-
Dan Carpenter authored
The indents on this file didn't line up so it was hard to work with. I changed other white space issues as I came across them. I also deleted or changed some couple comments and the comment style. Signed-off-by:
-
Mark Einon authored
Some defines are no longer referenced in the code, so removed them. Signed-off-by:
-
Mark Einon authored
Replaced pci map/unmap and set_mask calls with their dma equivalents. Also updated comments to reflect this. Signed-off-by:
-
Mark Einon authored
* Currently the tx queue is only stopped when the current packet fails. Check if the next packet will fail, and stop the queue if so. * Removed associated item from TODO list in the README. * Also minor fixup as adapter was being declared as null and immediately set to a value. Signed-off-by:
-
Mark Einon authored
Used the convenience macros DEFINE_PCI_DEVICE_TABLE and PCI_VDEVICE to tidy up the device table definition. Also remove the corresponding TODO item from the README. Signed-off-by:
-
Mark Einon authored
Previous update was to replace pci_alloc with dma_alloc calls. I missed replacing the corresponding pci_free_ calls with the dma versions. Now done. Thanks to Denis Kirjanov <kirjanov@gmail.com> for pointing this out. Signed-off-by:
-
Mark Einon authored
Use dma_allocs instead of pci_allocs, so we can use GFP_KERNEL allocations. Also removed this item from the TODO list Signed-off-by:
-
Mark Einon authored
* Following on from making rx_ring.fbr use a common structure - reversed the fbr[] array indicies so that index 1 = FBR0 and index 0 = FBR1, which allows USE_FBR0 define to work. * Also fixed up minor issues where indexes into the array were out of bounds in some places. * Removed rx_ring.fbr common stuct TODO item from README Signed-off-by:
-
Mark Einon authored
Sharing a common structure by moving common structure items into fbr_lookup. TODO - Currently will not work if USE_FBR0 = 0 as FBR1 uses fbr[1] which is removed in this case Signed-off-by:
-
Mark Einon authored
Two helper functions for adding 10bit/12bit umbers with wrapping are defined in the header. Moved them to the driver .c file. Signed-off-by:
-
Mark Einon authored
Driver now resides in a single file with a separate header with registers, updated the README TODO list. Signed-off-by:
-
Mark Einon authored
Move et1310_tx.h contents into et131x.c and delete et1310_tx.h Signed-off-by:
-
Mark Einon authored
Move et1310_rx.h contents into et131x.c and delete et1310_rx.h Signed-off-by:
-
Mark Einon authored
Move et131x_defs.h contents into et131x.c and delete et131x_defs.h Signed-off-by:
-
Mark Einon authored
Move et131x_adapter.h contents into et131x.c and delete et131x_adapter.h Signed-off-by:
-
Mark Einon authored
Move et1310_phy.h register defines into et131x.h and delete et1310_phy.h Signed-off-by:
-
Mark Einon authored
Move et1310_address_map.h register defines into et131x.h and delete et1310_address_map.h Signed-off-by:
-
Mark Einon authored
Header file should only have register defines, moved non-register defines to et131x.c Signed-off-by:
-
Mark Einon authored
The function declarations in et131x.h are no longer used now all functions are in one file. Removed declarations from et131x.h and added any required forward declarations to et131x.c. Signed-off-by:
-
Mark Einon authored
Created one big .c file for the driver, moving the contents of all driver .c files into it. Signed-off-by:
-
- 19 Oct, 2011 1 commit
-
-
Lars-Peter Clausen authored
Currently it is possible to write negative values to the ad5686's raw attribute. This will cause undefined behaviour, so reject negative values. Signed-off-by:
-
